From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id u69EKf0sBmdcGwcAWB0awg (envelope-from ) for ; Wed, 09 Oct 2024 03:13:01 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=arm.com header.i=@arm.com header.a=rsa-sha256 header.s=selector1 header.b=qF8oh/Bs; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.a=rsa-sha256 header.s=selector1 header.b=qF8oh/Bs; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 765C71E357; Wed, 9 Oct 2024 03:13:01 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.0 (2022-12-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-6.8 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_BLOCKED,RCVD_IN_VALIDITY_CERTIFIED,RCVD_IN_VALIDITY_RPBL, RCVD_IN_VALIDITY_SAFE,UNPARSEABLE_RELAY,URIBL_BLOCKED, URIBL_DBL_BLOCKED_OPENDNS autolearn=ham autolearn_force=no version=4.0.0 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 14A1C1E354 for ; Wed, 9 Oct 2024 03:12:58 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 9B946384F01B for ; Wed, 9 Oct 2024 07:12:56 +0000 (GMT) Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on20600.outbound.protection.outlook.com [IPv6:2a01:111:f403:2614::600]) by sourceware.org (Postfix) with ESMTPS id D57D6385DDCF for ; Wed, 9 Oct 2024 07:12:28 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D57D6385DDCF Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=arm.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org D57D6385DDCF Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=2a01:111:f403:2614::600 ARC-Seal: i=3; a=rsa-sha256; d=sourceware.org; s=key; t=1728457951; cv=pass; b=NbEjTZOZwvY+gWwDsXaVagMkmx94ju8f0Yh8b54k3O3wb33mqNa0bq3oXcK7aqMzVlyN3Z2TEZHZuEu1u/5gGnSBgW1liHjo03tL3k7tYRPO0yyHwCoZoT1Hi4Z1k4Hjc9RNUiHzjYZ7ROARMZjhe0cHS+iRh0gxpgByXhlv3co= ARC-Message-Signature: i=3; a=rsa-sha256; d=sourceware.org; s=key; t=1728457951; c=relaxed/simple; bh=RI7MNWdReHm1BON+0x6dJXENpbftBKqNxF9yQGowarY=; h=DKIM-Signature:DKIM-Signature:Message-ID:Date:Subject:To:From: MIME-Version; b=I0jw+q4911EHnT57PRIfIQ0soOIQ04+tXmvcbW8KgqojmjSbghU10hftk/1SPdmhbdVCj3vVuNjN4YLWuCQZjilyVtefWDyVh6yjaJlmV385bbH4ViKMHQ7w3w8vuITKUTKRkbT6mH8PzRjJborRrASvfATyIcXlKhtAtuwzCNw= ARC-Authentication-Results: i=3; server2.sourceware.org ARC-Seal: i=2; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=pass; b=fzF47TyZtTikIMia/f7AsEAj9ucdM/7LJDmF+gdNilQKDOFVrdId/lafLQkLB+ZfEjwq2xfbBThriO6W3pB6qYhToDkGhW8w4iue4sngYm9SZ9rxseDjzU/ZVEu2AZUQBfBAcpFU2mKY5lMk4w+JnFhUOjs/NiPYovzAKrK04pr04v17l2jd2rtVXur7Ajix35LwHtevrQ9R7C56Pm3m9LAahIXLewS/q9TaHHugm7NiCdRUDJF63meSKT55tvRpaqutMhsc7IZjZ5G/riJulesRhUSUuWOPwbHTa3/FWFihsHJDNz6kyfnkIUfVdvLZdtlaWWK1ysOI0kiFkEDaSw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=vHBbRpmpGNKXoH7j1crYp/5GRaeKL2Hpw8zxdPkZ91E=; b=bfOJy9zbK444NCX10ur6mDC0qMhqIgVBH27h6Wj5Gh/UVSWnvr+JZlabH08pjeuJ751dGk6QzjiV4GHiHXBt6T5eLOlR5ADCMNGcGqfFCS4OgvCax6Rwa0ttnLY5s9NC5AT8IqIk4G/YEKV1mVDRcwKpkmRmCWlH4CsqOezb9+WYVYQzKpjVJ3s1WDe5Leyb/xeIypJ/HFHquoPnGlIVvCNmZKqvz1W+d0+E7W6m2wm5fQqnDXtxvfbi1GKPoScscRg8VMBMIpp6jzuVoi9EVyIIJRDyEX7es6M5Ju/2eKYWfbVLI7780tTZQCDwwbqfsFiVi4Wqe0P0xfIpSahXEQ== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=sourceware.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=arm.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arm.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vHBbRpmpGNKXoH7j1crYp/5GRaeKL2Hpw8zxdPkZ91E=; b=qF8oh/BsLCy5Yo5bmO4vXT0QECoPODNhF4Q0ROB4Gf3j/1WsygAk9yWkKric7cWwSyFv0HFoKkrR+BoNBL3NFIvF079sanpSgmirHrr+00c7BiVunpAOZYBUT+mD44CU+74hQmFcCcT1//aqerSJimurTrwcLi+jaY4aLlAgVuM= Received: from AM6PR10CA0107.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:209:8c::48) by PAVPR08MB9209.eurprd08.prod.outlook.com (2603:10a6:102:30a::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8048.16; Wed, 9 Oct 2024 07:12:26 +0000 Received: from AM2PEPF0001C70E.eurprd05.prod.outlook.com (2603:10a6:209:8c:cafe::74) by AM6PR10CA0107.outlook.office365.com (2603:10a6:209:8c::48) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8026.23 via Frontend Transport; Wed, 9 Oct 2024 07:12:26 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=arm.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM2PEPF0001C70E.mail.protection.outlook.com (10.167.16.202) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.7918.13 via Frontend Transport; Wed, 9 Oct 2024 07:12:25 +0000 Received: ("Tessian outbound 994fc319cf83:v473"); Wed, 09 Oct 2024 07:12:25 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 946125ab0c575456 X-TessianGatewayMetadata: +1LFgRCfk1bNOism9yevjcJsgVIHsvzix8nQOBI/ZzJ36EQH6QAG44fFq/K9kh/iusDgNsEtFTcGVIBT+wrqQDIk8yTamSn1tdsEMhZWmAWETUi46/iy9zN/9p1JpyXDGPKehDGp8KQ6ue8z8W5o4LT/2FTBTr2NF3l2/EWSfkA= X-CR-MTA-TID: 64aa7808 Received: from L4d9a9158c949.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id B1E07189-474C-4CD8-B4E8-A181498B5728.1; Wed, 09 Oct 2024 07:12:19 +0000 Received: from EUR03-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id L4d9a9158c949.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 09 Oct 2024 07:12:19 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=JbaRZCk5SPaqFOEApEj4JFb/qMulSvdBMmcvWFpHa8YhVPyghhNOOnqWC9x73tPXFSkT0Rwcb/8Q31UDJK2OivBC8GaI5dvQ3wY1O34k/Dxi+0Iu1gs5YwGl334VktgIN4HYFYGbkinAqJryzUYR3gfZpIsn/lWIqMGSu2AbVvvJvWGqaQfjA0Jba+UkbtNOYAnpUbMFF+RIaaivVoB7uvtFkBNYFtONAdrNoCLW6gyQPJzOz9db1p7bzyZLLIvyRBEx0chX0xPPENVrkVgYw+tii5uMa8EEyEXJevAd1BKBNUYI93czbSQon8qH/Ez3pc0dG+4tB4YmqiuGfnxdxA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=vHBbRpmpGNKXoH7j1crYp/5GRaeKL2Hpw8zxdPkZ91E=; b=WNi3vBNzo5g7MUdJUuJtW8e7N43BMQR/+7kn57ZB6Fy25QoZGpdWQ3qS6Z2xRJrKXknwfFCoax4Xe/xtyKTZDI0q+dINZ+4Kx5zzBPr8WKejws0IwCkzLoYc/scD0+5Gfmf7CgkK7JBIALcMsijRPycbgMGQOF5zxgPs9G4yxuvdMytQQXHjAB1v04W7FGKF4DtQ12xruUBnfeP6mDUjXLt1j4shPB4Fxp/7UU+DZRwtF5pVtshWYwXQqAn9HRRRhobeyj8YiM+6Ns4uxWcsZIMeYjtZUe5m/n3/WgYbAX2Orx/XChWqyUtHVIG9XD6x+QLkZR/l15Xmn/myhcp2+g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arm.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vHBbRpmpGNKXoH7j1crYp/5GRaeKL2Hpw8zxdPkZ91E=; b=qF8oh/BsLCy5Yo5bmO4vXT0QECoPODNhF4Q0ROB4Gf3j/1WsygAk9yWkKric7cWwSyFv0HFoKkrR+BoNBL3NFIvF079sanpSgmirHrr+00c7BiVunpAOZYBUT+mD44CU+74hQmFcCcT1//aqerSJimurTrwcLi+jaY4aLlAgVuM= Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from PR3PR08MB5852.eurprd08.prod.outlook.com (2603:10a6:102:8e::21) by DB9PR08MB7583.eurprd08.prod.outlook.com (2603:10a6:10:307::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8048.16; Wed, 9 Oct 2024 07:12:15 +0000 Received: from PR3PR08MB5852.eurprd08.prod.outlook.com ([fe80::f44:d113:1c29:825d]) by PR3PR08MB5852.eurprd08.prod.outlook.com ([fe80::f44:d113:1c29:825d%5]) with mapi id 15.20.8026.017; Wed, 9 Oct 2024 07:12:15 +0000 Message-ID: <6cd076bd-972c-4fc0-a2fe-000af8d282f1@arm.com> Date: Wed, 9 Oct 2024 08:12:14 +0100 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 4/5] gdb/gdbserver: change shared set_tdesc_osabi to take gdb_osabi Content-Language: en-US To: Andrew Burgess , gdb-patches@sourceware.org References: From: Luis Machado In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO6P265CA0011.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:339::17) To PR3PR08MB5852.eurprd08.prod.outlook.com (2603:10a6:102:8e::21) MIME-Version: 1.0 X-MS-TrafficTypeDiagnostic: PR3PR08MB5852:EE_|DB9PR08MB7583:EE_|AM2PEPF0001C70E:EE_|PAVPR08MB9209:EE_ X-MS-Office365-Filtering-Correlation-Id: 0b22df98-a86e-4e87-ce5e-08dce831ba57 x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0;ARA:13230040|1800799024|376014|366016; X-Microsoft-Antispam-Message-Info-Original: =?utf-8?B?enBCWkQ1enBPYzdzTVU2SEwvWHgwZDJEb0lKaElINExUWnVBOE1aR1Z1aFZI?= =?utf-8?B?U1R1Wmt1V3dia0F3SUt6OWxJVFkvUlRDOXhoN1R5R0FOVWFmdFFtamRtU0dy?= =?utf-8?B?UTZBWTVKeEdEdXM3a2h1UVhjTllHTit2ZTVOVGdKdUdZanNLa2VvZWkvMUVQ?= =?utf-8?B?RHExVCttRk55b2tPYTR6M1BXdWhkTTY2RlhVNHpEWUFOMnIrMm9aZHhFMXha?= =?utf-8?B?a0p3WWRZbkJDWGM3bC96amVzYys1aGtRakpxVVNsUXNvaWdrYnlwSm1Ra3hh?= =?utf-8?B?UTc0M09WQVF1UDBMcnZDMkJ4cXpzYXhVcE9FcUNKMkR3clU4SHllOGNnNmhH?= =?utf-8?B?L1pPSkp3ZW94T05ZZzlXWStqNGJTcXNqZk5pb1h3eldIZCtDWlpmUjdEVUxW?= =?utf-8?B?SzM1L1ppK0VtaWlkZVllR3NWSVduMG1nUjVpMDNFUEJZOU1qRGpzV2wvS05N?= =?utf-8?B?NzJlcjM0VDJBdU5ra1ZhMk1Ka0J1bFBmNkh0aFdSb3FsNXV4Yk9KMno5NWRG?= =?utf-8?B?a2tYUW9oRFpzQzdUNitwY3ZxeE1LZzBCMm9qbHhiN0pVT0JGb1lSaVhDMjZv?= =?utf-8?B?ZHZKdGd5SllHVWxPOWU0UDg2VG1xOUJDeUFXcFcxcUxzdDBMcmNaR0htTVFF?= =?utf-8?B?b0ZOU00rcklBMGN5czBPZURDUU5XdzVGNWdLd3ZGN1grUFY4REhaUXc2T1Zy?= =?utf-8?B?ZWE5M0VpY1JlUldtQSt4cE1TMFlNdTF6Zit4bjR4emorUDlwdkh0WGk4bEZM?= =?utf-8?B?VUFZa0sxbHl4MmRITzlWUUN4Slk4akdYUXhGcWQ4a0FRZjIrNHZHZFVodGRi?= =?utf-8?B?ZnZFQzY0MWhheUdXYUJJWmNEYUNVM1VqK1doL1p3aTZxeW9PQmQ2NXNBZjV4?= =?utf-8?B?TStJcnd5ck9QNHZOWGNmTFowRm1NMmVkdmVDTEtxZkJyK2EyQ2haWEJjMlJL?= =?utf-8?B?VnhyVDdGS2daRHNqRmlCdHk1ei9yMFkwVGRaZEUyU2Zwb1ZTOHJaQmxhV1Vj?= =?utf-8?B?MU9PRXFWMkNrZ0RZLytFaVhLV1hCSGJXUFh2QWZPSTZrOG5lYVMwcnJsVCti?= =?utf-8?B?ZWl5Z0RSVE9PZkw0VHVFQzVHcktyTXFKUkpqNFVuVG5pOGxzRXlUTWx1dVdC?= =?utf-8?B?NEVldzVaRkp5Y1hXbFJTdzkzZkJBWFF6dTRpSzZqRy94UW5BYnN3TWJJeEMy?= =?utf-8?B?TDNTSUZTSWp0YlcyS2dPM2pjOWJpS2hWRnA4NDV3Uk1YYzI0VURTWU9HVnFa?= =?utf-8?B?bzRLQXlXNCthYTB4WFNHSEpGSitZWTV1OHExdkdHMGRqWldPdTBNb0hZcGRj?= =?utf-8?B?R0NZWUI5VWorYUtZN0FaSjJPeDNLV1JDcDFzWDZHNVVjWTkwb3QyajFManhG?= =?utf-8?B?dVAzek92Wm4rNVVabEM0VTREU2N6T2Q3d1hWVkZuWFZqTFhweVpIZXRTSlcy?= =?utf-8?B?MWdBdkI5d05YNWh2eGRYU21WM1U5NXY3SE9XVzBMVXZ2UEYwcHVBTStzNU0r?= =?utf-8?B?ZWlVcGpRa1dXWjZWZWlpdlhqbzFJVXFjZXpZeC8zQUZqUXpXNlA4OTdiNVR0?= =?utf-8?B?TXovK1pJeGhxRGRXUkxFVkVtQVVSMW52c2NOb081aTlwbGNMaXBIc1FncW1Y?= =?utf-8?B?aFRiMitzQkQ1WDk0LzYrTEo3UXgvdFE2NGY1elNobVM0SnBEaER5L1R6UXhX?= =?utf-8?B?WnlmZ3BVZ3UyckZLcWJ6SzhGMm9aQ3VoRzk2QjNvZm5LakJnOEJqdVFBPT0=?= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PR3PR08MB5852.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(1800799024)(376014)(366016); DIR:OUT; SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB7583 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-SkipListedInternetSender: ip=[2603:10a6:102:8e::21]; domain=PR3PR08MB5852.eurprd08.prod.outlook.com X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM2PEPF0001C70E.eurprd05.prod.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: d16144f5-453e-4090-d860-08dce831b452 X-Microsoft-Antispam: BCL:0; ARA:13230040|1800799024|376014|36860700013|82310400026|35042699022; X-Microsoft-Antispam-Message-Info: =?utf-8?B?bGovbkpiQkJ1Q054SzIyK3liZlFZemFmT25Jb050dTJaR3U0Zmc5Z0thYTVS?= =?utf-8?B?eUs2Vm94amFnMi9TZXVuRnhtZWtmMXBBbUJMWjNpZnhLY3NHN1p6Yk9QUHVK?= =?utf-8?B?Mmt6d3RheHljKzhGWER2SldNbXRDRk9Ja3ZUNTlXTGtxdDdLK3lSaVFhOURl?= =?utf-8?B?Z0ovVktWZWRmUFVzN25NcDhWWk1JTEJQVWxKd3ZJaC9HaThCbzZUN3FpZGlC?= =?utf-8?B?aUVDOXZUVjh1YWp0d1phOVJKbTVLdGNoUmZPa0MvYzZMUUFneCtYNG03YnVM?= =?utf-8?B?QzRYdkg0OHA3dFVNU1JXNjVsVFdrNDE4UUZzejZId0Y1dTNrNjR0ME50cGcx?= =?utf-8?B?cWM1SFRYd1J1SFpEbUozdWdsL2VEQ25SMm45ZmFJREdxUGd5OENqaHBFbzRR?= =?utf-8?B?bGZRamFDSlFtbm05a1pYNFlFd3grYUVGNExzSUUrQ2hJWnowb2daVXdzTUVh?= =?utf-8?B?WDZKTG1LQmxVZEVCaXpzdy9jVnMrTEw2TlYyMXFNNW95VnI4S3lheC8yYkc1?= =?utf-8?B?RnI0ZUVxRGUvNzNqc29PUGk3YVFLQUNGODh2OFN0c2FTQzA3bEk3RjdpQ1A0?= =?utf-8?B?R045S0E3ZGhKM1JxeWYxdXdtRnZscWU3ZnI1dC9iaC9ZYXcxNThIRFZDcUM1?= =?utf-8?B?U2VwQ3NMK1RuQW95UCsxSUtNSjczWXlWQ3dJR2QxSWdBYy9oa3RKKytXS2tu?= =?utf-8?B?TmQ0b1NON29NUm5VRVZvYnJJSy8zVEVaWHZDd1NhM2RpR0FWOUNQYWxPcFNs?= =?utf-8?B?YzQvSkdZTnZYK0JEbzlYUkJaRExhREZYUXg4WUhVbE9uYktxQUMrdHhyWGNZ?= =?utf-8?B?amJFcnJxSkRQSG1JeEovU1V5ZlhRVS94aU43UGNQNFlad1M3MCtkKytGdk8r?= =?utf-8?B?QmV3Vlc0YmYwZ2I4NmZTaytQeGxDUHpmcy9yNHRiRTVtaU1CN296SEVFYWM0?= =?utf-8?B?YURKdkd2ZlJ6MWp2a0oyRGtiSmRmdTRPelBlZkszb24zQTVTZUwvVjRqVGpP?= =?utf-8?B?ZCtiTFJnZmdwdHkxR29ELytKdEkybWpPNFBqNXNITzE5T25LU1AvR095dTBV?= =?utf-8?B?dFh3L0UxZmJFS0J0S29hM2o5QnpYUGhKYUd5Z1liUTRneVRHUmtUYlpjaUJJ?= =?utf-8?B?ZTQ1amxOakJoVXpTc1NzTk9maklZQmExNjIxWjEzY0hJYUZEeVpFOUdCQnBZ?= =?utf-8?B?RGtyUWVYc1J4d0J4RzlwQ0VCalN2WDAydlVsUzVFZlNnVEJvMklLaklOSTNH?= =?utf-8?B?bXgyK0ZYT2d0a1Y5ZlcrTUJ4UHY0eDdTMU9veWVYdnpsQjl5cy9XRzVzZEVX?= =?utf-8?B?OCtCM2dpNnNmTkxZSTRFOUZXNUZ4TUtxNDJHVmxYWE9vN1lDV1VxKzBKcW9V?= =?utf-8?B?WEZvM2w1UWQzWVdqYXcrQU80d2p5VXhNSnNPYmxsRTZsT1lOLzVOczRQSCt2?= =?utf-8?B?UXdsL2xJYmpaeTVDR3hlOVRxMDd0cGIxbGx6TE95TnRGTTVZL2xsd3dIVCs0?= =?utf-8?B?ZjNxd1FjOUc3bVIzT0pEVGtsUGoyRXBLRm4ySndQT1ZzWFAxb3FWc1YvWjg4?= =?utf-8?B?MHRMSWtsS0Z0WnF0QlFjQjMzS0VxeFBpc2lvZHgxQ0VMTDhZYUllOTRKY2hr?= =?utf-8?B?R0FFOTZXUDFIUzdCTkt6ZWNLWEZObFZLTHVPT0pMaGVxVGFmVzdNOTRCRVd0?= =?utf-8?B?T09PalVUK1pJK01WeEs2a0NRbTVjSTNsOTBhKzJXbTlJVm9leUJMWUVjRzF6?= =?utf-8?B?NjV1Q0VkOGI4V1pLbmRBZmgrbTl5UGVGdVh3N2pvOGh6NzVXall5LzM0dFZB?= =?utf-8?B?QmppRURQY3hKT1F3Vk84ZVFJVVhqTW1SRFZMeENzbUxpUmtDY0ZuUG1hSk80?= =?utf-8?Q?es7tqeZRRjTCx?= X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFS:(13230040)(1800799024)(376014)(36860700013)(82310400026)(35042699022); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Oct 2024 07:12:25.6344 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 0b22df98-a86e-4e87-ce5e-08dce831ba57 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM2PEPF0001C70E.eurprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAVPR08MB9209 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Just nits... On 10/8/24 18:11, Andrew Burgess wrote: > There is a single declaration of set_tdesc_osabi that is shared > between gdbserver/ and gdb/, this declaration takes a 'const char *' > argument which is the string representing an osabi. > > Then in gdb/ we have an overload of set_tdesc_osabi which takes an > 'enum gdb_osabi'. > > In this commit I change the shared set_tdesc_osabi to be the version > which takes an 'enum gdb_osabi', and I remove the version which takes > a 'const char *'. All users of set_tdesc_osabi are updated to pass an > 'enum gdb_osabi'. > > The features/ code, which is generated from the xml files, requires a > new function to be added to osabi.{c,h} which can return a string > representation of an 'enum gdb_osabi'. With that new function in > place the features/ code is regenerated. > > This change is being made to support the next commit. In the next > commit gdbserver will be updated to call set_tdesc_osabi in more > cases. The problem is that gdbserver stores the osabi as a string. > The issue here is that a typo in the gdbserver/ code might go > unnoticed and result in gdbserver sending back an invalid osabi > string. > > To fix this we want gdbserver to pass an 'enum gdb_osabi' to the > set_tdesc_osabi function. With that requirement in place it seems to > make sense if all calls to set_tdesc_osabi pass an 'enum gdb_osabi'. > > There should be no user visible changes after this commit. > --- > gdb/arch/amd64.c | 3 ++- > gdb/arch/i386.c | 3 ++- > gdb/arch/tic6x.c | 3 ++- > gdb/features/mips-dsp-linux.c | 2 +- > gdb/features/mips-linux.c | 2 +- > gdb/features/or1k-linux.c | 2 +- > gdb/features/sparc/sparc32-solaris.c | 2 +- > gdb/features/sparc/sparc64-solaris.c | 2 +- > gdb/osabi.c | 29 ++++++++++++++++++++++++++++ > gdb/osabi.h | 4 ++++ > gdb/target-descriptions.c | 11 ++--------- > gdb/target-descriptions.h | 1 - > gdbserver/tdesc.cc | 3 ++- > gdbsupport/tdesc.h | 4 +++- > 14 files changed, 51 insertions(+), 20 deletions(-) > > diff --git a/gdb/arch/amd64.c b/gdb/arch/amd64.c > index 548b32f252f..a04fcddd215 100644 > --- a/gdb/arch/amd64.c > +++ b/gdb/arch/amd64.c > @@ -17,6 +17,7 @@ > > #include "amd64.h" > #include "gdbsupport/x86-xstate.h" > +#include "gdbsupport/osabi-common.h" > #include > > #include "../features/i386/64bit-avx.c" > @@ -45,7 +46,7 @@ amd64_create_target_description (uint64_t xcr0, bool is_x32, bool is_linux, > is_x32 ? "i386:x64-32" : "i386:x86-64"); > > if (is_linux) > - set_tdesc_osabi (tdesc.get (), "GNU/Linux"); > + set_tdesc_osabi (tdesc.get (), GDB_OSABI_LINUX); > #endif > > long regnum = 0; > diff --git a/gdb/arch/i386.c b/gdb/arch/i386.c > index 49375e7c495..72159d8ed70 100644 > --- a/gdb/arch/i386.c > +++ b/gdb/arch/i386.c > @@ -18,6 +18,7 @@ > #include "i386.h" > #include "gdbsupport/tdesc.h" > #include "gdbsupport/x86-xstate.h" > +#include "gdbsupport/osabi-common.h" > #include > > #include "../features/i386/32bit-core.c" > @@ -38,7 +39,7 @@ i386_create_target_description (uint64_t xcr0, bool is_linux, bool segments) > #ifndef IN_PROCESS_AGENT > set_tdesc_architecture (tdesc.get (), "i386"); > if (is_linux) > - set_tdesc_osabi (tdesc.get (), "GNU/Linux"); > + set_tdesc_osabi (tdesc.get (), GDB_OSABI_LINUX); > #endif > > long regnum = 0; > diff --git a/gdb/arch/tic6x.c b/gdb/arch/tic6x.c > index 680a7942070..c1082d48eea 100644 > --- a/gdb/arch/tic6x.c > +++ b/gdb/arch/tic6x.c > @@ -16,6 +16,7 @@ > along with this program. If not, see . */ > > #include "gdbsupport/tdesc.h" > +#include "gdbsupport/osabi-common.h" > #include "tic6x.h" > > #include "../features/tic6x-core.c" > @@ -30,7 +31,7 @@ tic6x_create_target_description (enum c6x_feature feature) > target_desc_up tdesc = allocate_target_description (); > > set_tdesc_architecture (tdesc.get (), "tic6x"); > - set_tdesc_osabi (tdesc.get (), "GNU/Linux"); > + set_tdesc_osabi (tdesc.get (), GDB_OSABI_LINUX); > > long regnum = 0; > > diff --git a/gdb/features/mips-dsp-linux.c b/gdb/features/mips-dsp-linux.c > index 17d30aac68f..4873037b69d 100644 > --- a/gdb/features/mips-dsp-linux.c > +++ b/gdb/features/mips-dsp-linux.c > @@ -11,7 +11,7 @@ initialize_tdesc_mips_dsp_linux (void) > target_desc_up result = allocate_target_description (); > set_tdesc_architecture (result.get (), bfd_scan_arch ("mips")); > > - set_tdesc_osabi (result.get (), "GNU/Linux"); > + set_tdesc_osabi (result.get (), GDB_OSABI_LINUX); > > struct tdesc_feature *feature; > > diff --git a/gdb/features/mips-linux.c b/gdb/features/mips-linux.c > index a43526db24e..5ff2e5fb92d 100644 > --- a/gdb/features/mips-linux.c > +++ b/gdb/features/mips-linux.c > @@ -11,7 +11,7 @@ initialize_tdesc_mips_linux (void) > target_desc_up result = allocate_target_description (); > set_tdesc_architecture (result.get (), bfd_scan_arch ("mips")); > > - set_tdesc_osabi (result.get (), "GNU/Linux"); > + set_tdesc_osabi (result.get (), GDB_OSABI_LINUX); > > struct tdesc_feature *feature; > > diff --git a/gdb/features/or1k-linux.c b/gdb/features/or1k-linux.c > index 551b38f59c0..85a681f89ba 100644 > --- a/gdb/features/or1k-linux.c > +++ b/gdb/features/or1k-linux.c > @@ -11,7 +11,7 @@ initialize_tdesc_or1k_linux (void) > target_desc_up result = allocate_target_description (); > set_tdesc_architecture (result.get (), bfd_scan_arch ("or1k")); > > - set_tdesc_osabi (result.get (), "GNU/Linux"); > + set_tdesc_osabi (result.get (), GDB_OSABI_LINUX); > > struct tdesc_feature *feature; > > diff --git a/gdb/features/sparc/sparc32-solaris.c b/gdb/features/sparc/sparc32-solaris.c > index ce57abaaaf2..70affdbc5b5 100644 > --- a/gdb/features/sparc/sparc32-solaris.c > +++ b/gdb/features/sparc/sparc32-solaris.c > @@ -11,7 +11,7 @@ initialize_tdesc_sparc32_solaris (void) > target_desc_up result = allocate_target_description (); > set_tdesc_architecture (result.get (), bfd_scan_arch ("sparc")); > > - set_tdesc_osabi (result.get (), "Solaris"); > + set_tdesc_osabi (result.get (), GDB_OSABI_SOLARIS); > > struct tdesc_feature *feature; > > diff --git a/gdb/features/sparc/sparc64-solaris.c b/gdb/features/sparc/sparc64-solaris.c > index 92cc88cd5cf..98edabe3864 100644 > --- a/gdb/features/sparc/sparc64-solaris.c > +++ b/gdb/features/sparc/sparc64-solaris.c > @@ -11,7 +11,7 @@ initialize_tdesc_sparc64_solaris (void) > target_desc_up result = allocate_target_description (); > set_tdesc_architecture (result.get (), bfd_scan_arch ("sparc:v9")); > > - set_tdesc_osabi (result.get (), "Solaris"); > + set_tdesc_osabi (result.get (), GDB_OSABI_SOLARIS); > > struct tdesc_feature *feature; > > diff --git a/gdb/osabi.c b/gdb/osabi.c > index 6c00228fb4a..47ef349c6be 100644 > --- a/gdb/osabi.c > +++ b/gdb/osabi.c > @@ -524,6 +524,35 @@ generic_elf_osabi_sniffer (bfd *abfd) > > return osabi; > } > + > +/* See osabi.h. */ Missing newline here. > +const char * > +gdbarch_osabi_enum_name (enum gdb_osabi osabi) > +{ > + switch (osabi) > + { > +#define GDB_OSABI_DEF_FIRST(Enum, Name, Regex) \ > + case GDB_OSABI_ ## Enum: \ > + return "GDB_OSABI_" #Enum; > + > +#define GDB_OSABI_DEF(Enum, Name, Regex) \ > + case GDB_OSABI_ ## Enum: \ > + return "GDB_OSABI_" #Enum; > + > +#define GDB_OSABI_DEF_LAST(Enum, Name, Regex) \ > + case GDB_OSABI_ ## Enum: \ > + return "GDB_OSABI_" #Enum; > + > +#include "gdbsupport/osabi-common.def" > + > +#undef GDB_OSABI_DEF_LAST > +#undef GDB_OSABI_DEF > +#undef GDB_OSABI_DEF_FIRST > + } > + > + gdb_assert_not_reached (); > +} > + Spurious newline above. > > static void > set_osabi (const char *args, int from_tty, struct cmd_list_element *c) > diff --git a/gdb/osabi.h b/gdb/osabi.h > index 984bdd4e5dc..02ac5503db3 100644 > --- a/gdb/osabi.h > +++ b/gdb/osabi.h > @@ -52,4 +52,8 @@ void gdbarch_init_osabi (struct gdbarch_info, struct gdbarch *); > void generic_elf_osabi_sniff_abi_tag_sections (bfd *, asection *, > enum gdb_osabi *); > > +/* Return a string version of OSABI. This is used when generating code > + which calls set_tdesc_osabi and an 'enum gdb_osabi' value is needed. */ > +const char *gdbarch_osabi_enum_name (enum gdb_osabi osabi); > + > #endif /* OSABI_H */ > diff --git a/gdb/target-descriptions.c b/gdb/target-descriptions.c > index c165750c6c5..1bd22c273a2 100644 > --- a/gdb/target-descriptions.c > +++ b/gdb/target-descriptions.c > @@ -1199,12 +1199,6 @@ set_tdesc_architecture (struct target_desc *target_desc, > > /* See gdbsupport/tdesc.h. */ > > -void > -set_tdesc_osabi (struct target_desc *target_desc, const char *name) > -{ > - set_tdesc_osabi (target_desc, osabi_from_tdesc_string (name)); > -} > - > void > set_tdesc_osabi (struct target_desc *target_desc, enum gdb_osabi osabi) > { > @@ -1317,9 +1311,8 @@ class print_c_tdesc : public tdesc_element_visitor > if (tdesc_osabi (e) > GDB_OSABI_UNKNOWN > && tdesc_osabi (e) < GDB_OSABI_INVALID) > { > - gdb_printf > - (" set_tdesc_osabi (result.get (), \"%s\");\n", > - gdbarch_osabi_name (tdesc_osabi (e))); > + const char *enum_name = gdbarch_osabi_enum_name (tdesc_osabi (e)); > + gdb_printf (" set_tdesc_osabi (result.get (), %s);\n", enum_name); > gdb_printf ("\n"); > } > > diff --git a/gdb/target-descriptions.h b/gdb/target-descriptions.h > index d708dbd3589..dc83db0acf2 100644 > --- a/gdb/target-descriptions.h > +++ b/gdb/target-descriptions.h > @@ -219,7 +219,6 @@ int tdesc_register_in_reggroup_p (struct gdbarch *gdbarch, int regno, > > void set_tdesc_architecture (struct target_desc *, > const struct bfd_arch_info *); > -void set_tdesc_osabi (struct target_desc *, enum gdb_osabi osabi); > void set_tdesc_property (struct target_desc *, > const char *key, const char *value); > void tdesc_add_compatible (struct target_desc *, > diff --git a/gdbserver/tdesc.cc b/gdbserver/tdesc.cc > index 7f11120c318..d052f43c76e 100644 > --- a/gdbserver/tdesc.cc > +++ b/gdbserver/tdesc.cc > @@ -179,8 +179,9 @@ tdesc_osabi_name (const struct target_desc *target_desc) > /* See gdbsupport/tdesc.h. */ > > void > -set_tdesc_osabi (struct target_desc *target_desc, const char *name) > +set_tdesc_osabi (struct target_desc *target_desc, enum gdb_osabi osabi) > { > + const char *name = gdbarch_osabi_name (osabi); > target_desc->osabi = make_unique_xstrdup (name); > } > > diff --git a/gdbsupport/tdesc.h b/gdbsupport/tdesc.h > index fa9431b5b65..0a9be1dc4d1 100644 > --- a/gdbsupport/tdesc.h > +++ b/gdbsupport/tdesc.h > @@ -18,6 +18,8 @@ > #ifndef COMMON_TDESC_H > #define COMMON_TDESC_H > > +#include "gdbsupport/osabi-common.h" > + > struct tdesc_feature; > struct tdesc_type; > struct tdesc_type_builtin; > @@ -339,7 +341,7 @@ void set_tdesc_architecture (target_desc *target_desc, > const char *tdesc_architecture_name (const struct target_desc *target_desc); > > /* Set TARGET_DESC's osabi by NAME. */ > -void set_tdesc_osabi (target_desc *target_desc, const char *name); > +void set_tdesc_osabi (target_desc *target_desc, enum gdb_osabi osabi); > > /* Return the osabi associated with this target description as a string, > or NULL if no osabi was specified. */ Otherwise looks good to me. Approved-By: Luis Machado