From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id FWt/Dn5BNWpZXA8AWB0awg (envelope-from ) for ; Fri, 19 Jun 2026 09:17:50 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=d+bixScL; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 280E21E098; Fri, 19 Jun 2026 09:17:50 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-6.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [IPv6:2620:52:6:3111::32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 7B61A1E024 for ; Fri, 19 Jun 2026 09:17:49 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id DEC3D4BAE7F4 for ; Fri, 19 Jun 2026 13:17:47 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org DEC3D4BAE7F4 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=d+bixScL Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTP id 396984BAE7E6 for ; Fri, 19 Jun 2026 13:16:52 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 396984BAE7E6 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 396984BAE7E6 Authentication-Results: sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1781875012; cv=none; b=c76cTz6u6Rx9MjWxxyk2zgnTyqvv2gylltBqYoES1oH+mI/yGKC7IuzfEqGEmRVofpD5v/iRTjdkVj95OEJ7Rr5IkmrXcEh5k2GMvEMutsjarYiTUroP7qyQtiuOPUIr7CyOhcCe+DaLAcOxGk/kxFJgPEeIUrTc8kY+0GZm1yI= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1781875012; c=relaxed/simple; bh=5TadP1PREvyBN66oK9ZAO5pZFjqXru2ot2Qa79yKy7E=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=EaKEUuAFu2M3XbH5qWS+YFEdbjFY47z0wDu7BFKxyY5TtNdNLd4PEZhRT/JHnzVVDCRubrnZ9NAwDBfViiA8ALi4isI1Cq97T+JBsTO48/Ok14SVOej5CD1Pt62HHiKMbhIellaK4iyUewuZhMS9iBf33gutS7vWYUFcMw5M1GM= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=d+bixScL DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 396984BAE7E6 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1781875011; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=WIHfHrPSKSNUypy078U3c+cNNON0oHeZj+8EgYmC3YQ=; b=d+bixScL0DJfsBlkL1l5TUbKPyH7hJ9xQo1CJ5ingT/jVFJ+9tOc1VV1W1a7nPAgsnDpcs EGp4RmQ2zvRhG6JJf0SqB62keFroFZUeAmwFuQ6prCpGpR6EDbqAZdrOjMCw++i7q/4gPr Du21J1NeBPw1xYSEuhjokQDv3pgM4vM= Received: from mail-ua1-f70.google.com (mail-ua1-f70.google.com [209.85.222.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-281-DcPtikLEM8KO9hb1DkS_NA-1; Fri, 19 Jun 2026 09:16:49 -0400 X-MC-Unique: DcPtikLEM8KO9hb1DkS_NA-1 X-Mimecast-MFC-AGG-ID: DcPtikLEM8KO9hb1DkS_NA_1781875009 Received: by mail-ua1-f70.google.com with SMTP id a1e0cc1a2514c-963d7e5ac77so789470241.2 for ; Fri, 19 Jun 2026 06:16:49 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781875009; x=1782479809; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=WIHfHrPSKSNUypy078U3c+cNNON0oHeZj+8EgYmC3YQ=; b=Iv2ZjRE/T0xCH7EGVytacFkxAcFbxZFgR3jyksX+0eROGu5gbnlM+ylyya7Z+MdDaV 3LDyLllUIr4G/qBTv7azL3k/PZwIxtp09N61xucsZ6bkfutf4+LswRuqYwIYHRSbWIeQ 1+2zvLYbNSBiuYYHmZfzuQ5iKFmMGgVPmEvCfgW5RIneNfFqtUMsQcinIOu6gwtLbS2A B9wiQLIC/JEVb5eGe1zo7HVRzYGsLALhtDPZh/0ecJOrtVct2HGaAo6CE4eZXxU3QGTF R5IcVjKMiRBMzMIUvHGXT+r1DzwTJqPwc+7I2oVnwhtW8ITfaKZp4m0edakx4enj1IZr +rfw== X-Forwarded-Encrypted: i=1; AFNElJ/Ha27GBu/FAcRKTvNTY2mu2S+WqMH1SesJghZQTVLBhJ6WIHhVVhU37bnVsoKjXwn2EhI7+GWcaiJ4lQ==@sourceware.org X-Gm-Message-State: AOJu0YwzRIF0q9fRuAgZ6Az0PnTtS5ZisUu5feMUReOlmBCMAoJhL7HF 6nEBFnGCfAWeAS9qQrfxfpoEiBUoX0TYUEVSBc48egnF5VY4P3pZy7CaF4vO9FIo7+8cmsrIOAZ wPHYbjNMigLw0ZCdSFElfS8KVlMR5CTtxEu8X4TCw4hogN04iW+0BODjSlWqP100s5qKAgrA= X-Gm-Gg: AfdE7cmOCGBsRF3cBvwPcVxMf4Puf8JdpWHutAjBTDOcoLoIwk8QYxJL1p3I2HnCTPw vvgmvLq6A1yOaUuBgRdqcbUpdQUunCkib5D5EOM5I/F0Av0ecZB2q2mFGUnYBiucIhhWnJBaG8e FiAJvMX+DQe4ln4itC7wi0U6cgZEbOm89vPoWZzkC0gQk0nX+E9MuYrf44RvGLPWoehCz1N2RUW qEZhS7utPpnqYElBEkxDUxK7crGs37Qt5vGWLjcrzej1srYOFsLl1Tp+LnJgOx2tP9KNDpUgeZY 7iYKKJORLcg8+5appAe82cDLDwZNMr2Qu+StP5Lv7n96nZojPvmfOXdkrAj/t3Hu5iwVDSQzsyT cwBgUw6VsxZjQauaqgJhJ X-Received: by 2002:a05:6102:3e83:b0:728:f34d:f410 with SMTP id ada2fe7eead31-72a1d413ea2mr1948519137.7.1781875009047; Fri, 19 Jun 2026 06:16:49 -0700 (PDT) X-Received: by 2002:a05:6102:3e83:b0:728:f34d:f410 with SMTP id ada2fe7eead31-72a1d413ea2mr1948472137.7.1781875008552; Fri, 19 Jun 2026 06:16:48 -0700 (PDT) Received: from ?IPV6:2804:14d:8084:993e::75d? ([2804:14d:8084:993e::75d]) by smtp.gmail.com with ESMTPSA id af79cd13be357-920a4c5d743sm236863485a.40.2026.06.19.06.16.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 19 Jun 2026 06:16:47 -0700 (PDT) Message-ID: <6cbaf2d8-0d2e-45bd-b929-8570316ef755@redhat.com> Date: Fri, 19 Jun 2026 10:16:43 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] [testsuite] Log gdb_do_cache misses only, not hits To: Luis Machado , gdb-patches@sourceware.org References: <20260619081655.2166546-1-luis.machado@amd.com> From: Guinevere Larsen In-Reply-To: <20260619081655.2166546-1-luis.machado@amd.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: T-u9HfJnHSvOa2WPHcgasiXiLt0AP8G6Vdmlf9o8Emk_1781875009 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 6/19/26 5:16 AM, Luis Machado wrote: > The verbose -log in gdb_do_cache fired unconditionally on every call, > including cache hits. With many tests calling gdb_caching_procs like > get_compiler_info_1 per compilation, this produced dozens of repeated > identical lines per test file in the log, like so: > > gdb_do_cache: get_compiler_info_1 ( c ) > gdb_do_cache: get_compiler_info_1 ( c ) > gdb_do_cache: get_compiler_info_1 ( c ) > gdb_do_cache: get_compiler_info_1 ( c ) > gdb_do_cache: get_compiler_info_1 ( c ) > gdb_do_cache: get_compiler_info_1 ( c ) > gdb_do_cache: get_compiler_info_1 ( c ) > gdb_do_cache: get_compiler_info_1 ( c ) > > Move the log to just before actual computation, after both the > in-memory and on-disk cache checks. This helps keep the logs clean. Yeah, this looks like a good idea, and would definitely reduce the noise at the top of the log Reviewed-By: Guinevere Larsen > --- > gdb/testsuite/lib/cache.exp | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/gdb/testsuite/lib/cache.exp b/gdb/testsuite/lib/cache.exp > index 71688ee373e..1ba8c881716 100644 > --- a/gdb/testsuite/lib/cache.exp > +++ b/gdb/testsuite/lib/cache.exp > @@ -103,8 +103,6 @@ proc gdb_do_cache {name args} { > global gdb_data_cache objdir > global GDB_PARALLEL > > - verbose -log "gdb_do_cache: $name ( $args )" > - > # Normally, if we have a cached value, we skip computation and return > # the cached value. If set to 1, instead don't skip computation and > # verify against the cached value. > @@ -195,6 +193,7 @@ proc gdb_do_cache {name args} { > set old_gdb_nested_caching_proc_calls $::gdb_nested_caching_proc_calls > set ::gdb_nested_caching_proc_calls {} > > + verbose -log "gdb_do_cache: $name ( $args )" > set real_name gdb_real__$name > set gdb_data_cache(${cache_name},value) [gdb_do_cache_wrap $real_name {*}$args] > set gdb_data_cache(${cache_name},exit) $::gdb_exit_called -- Cheers, Guinevere Larsen it/its she/her (deprecated)