From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 114403 invoked by alias); 24 Feb 2017 17:45:40 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 113634 invoked by uid 89); 24 Feb 2017 17:45:32 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 24 Feb 2017 17:45:10 +0000 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id D46AB3B720; Fri, 24 Feb 2017 17:45:10 +0000 (UTC) Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id v1OHj9JW032133; Fri, 24 Feb 2017 12:45:10 -0500 Subject: Re: [PATCH v2 1/2] symtab.c: Small refactor To: Yao Qi References: <86a89cc2u6.fsf@gmail.com> <1487870642-29926-1-git-send-email-palves@redhat.com> <1487870642-29926-2-git-send-email-palves@redhat.com> <20170223214525.bynt33cs4kylqayh@localhost> Cc: gdb-patches@sourceware.org From: Pedro Alves Message-ID: <6cadfdac-d191-b6a6-4178-e09cda057aa3@redhat.com> Date: Fri, 24 Feb 2017 17:45:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <20170223214525.bynt33cs4kylqayh@localhost> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2017-02/txt/msg00690.txt.bz2 On 02/23/2017 09:45 PM, Yao Qi wrote: > On 17-02-23 17:24:01, Pedro Alves wrote: >> add_symtab_completions does the exact same as the code that it is >> replacing. >> >> gdb/ChangeLog: >> yyyy-mm-dd Pedro Alves >> >> * symtab.c (make_file_symbol_completion_list_1): Use >> add_symtab_completions. > > Patch is good to me. > Thanks, I've pushed this one in. Thanks, Pedro Alves