From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 8l9LH9p8ZGAuCwAAWB0awg (envelope-from ) for ; Wed, 31 Mar 2021 09:44:58 -0400 Received: by simark.ca (Postfix, from userid 112) id 72B861EE14; Wed, 31 Mar 2021 09:44:58 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-0.7 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,RDNS_DYNAMIC,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 9B99B1E590 for ; Wed, 31 Mar 2021 09:44:57 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 0CB72384B806; Wed, 31 Mar 2021 13:44:57 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 0CB72384B806 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1617198297; bh=lECxpm0q/Y2cZS8BtkQEPj8Fef3ZHllXgcBBkOW6ChE=; h=Subject:To:References:Date:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=ANHTWmIK+5SAB08LqEtKcRm+/9+UUIMxbfCJ8yIJQ31S3vFXkv9tBcmv8I/FAygBT ZCdARbfG+PjXBbjr5xfdWa8pOg35u4B3Mui4Lhx4rdIvQWDiOJ6eTqRp9fEx9RA3FA Ti+PD910mHGEKAgElFSeNdpXM0u6aEmqNmfFljLA= Received: from mail-qt1-x836.google.com (mail-qt1-x836.google.com [IPv6:2607:f8b0:4864:20::836]) by sourceware.org (Postfix) with ESMTPS id F3422385802E for ; Wed, 31 Mar 2021 13:44:53 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org F3422385802E Received: by mail-qt1-x836.google.com with SMTP id f12so14459591qtq.4 for ; Wed, 31 Mar 2021 06:44:53 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=lECxpm0q/Y2cZS8BtkQEPj8Fef3ZHllXgcBBkOW6ChE=; b=tHJW3cH9aeZb3ojOHxD7A9Zgk/XaWlnXDGZ35SJz8EFZ8Z3AbZO/D2tPybXLjN2JVX pMVA6KUwC2vMmkxMPoyC9Ki8/p/ZHZU/uI8TNgrvbip1v53kuWB5RvRP1nHuF6B+9CMm CM/wtJyb31b8CStc2sUuZscELgn4YIfSvgHwWkTrXb2J2bY/F9RmbGBIu8BITzqImmNa 8LyU7H+vzoh0byQAdGf5UO5AThNs7TZNugykEQJAC6qNHyluPHqK4wpp+lSkSfu+AJkO i8obYmCIVSHJxSZq9Ws13myV+a6v3O5fsQCkOTekfTDxAbTuDrQrvG4PsG5+2RxxaFxg rZUw== X-Gm-Message-State: AOAM531Z6IH2VMceRzE+XcG/JhUvgChaB4MXoF+LoCxXDDezQt4cD31r 3JZO2edQbDOJVwFfefVgS4Cbpg== X-Google-Smtp-Source: ABdhPJzza8RzzBPinz0qcy3QNcmp1NalrpE9AzFzVTeaYpCg4B9AHk8BoiSMvDUc9QrwT8KYSsK9bg== X-Received: by 2002:ac8:7768:: with SMTP id h8mr2466650qtu.185.1617198293418; Wed, 31 Mar 2021 06:44:53 -0700 (PDT) Received: from ?IPv6:2804:7f0:4841:2841:397e:3682:580a:695? ([2804:7f0:4841:2841:397e:3682:580a:695]) by smtp.gmail.com with ESMTPSA id i8sm1360513qtj.16.2021.03.31.06.44.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 31 Mar 2021 06:44:52 -0700 (PDT) Subject: Re: [PATCH] Add startswith function and use it instead of CONST_STRNEQ. To: =?UTF-8?Q?Martin_Li=c5=a1ka?= , Alan Modra , Tom Tromey , Alan Modra via Binutils , gdb-patches@sourceware.org References: <20210320070037.GR6791@bubble.grove.modra.org> <87wnu1k5z1.fsf@tromey.com> <20210321131254.GS6791@bubble.grove.modra.org> <87k0q0j5ql.fsf@tromey.com> <20210322120652.GV6791@bubble.grove.modra.org> <20210322225639.GY6791@bubble.grove.modra.org> <0520bcb8-1945-5f0f-87d1-14785b881c45@linaro.org> <20210325115413.GB5425@bubble.grove.modra.org> <1e7e6f28-c916-f138-63c5-ca27f191f994@linaro.org> Message-ID: <6c5dee84-af6b-5d4a-277c-ec9ba4ce7771@linaro.org> Date: Wed, 31 Mar 2021 10:44:49 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Luis Machado via Gdb-patches Reply-To: Luis Machado Cc: =?UTF-8?Q?Thomas_Wei=c3=9fschuh?= Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" On 3/31/21 10:12 AM, Martin Liška wrote: >> Given this has been broken for a little while, and given Alan's patch >> fixes the problem for arm/aarch64 sims (from what I tested), can we >> push this for now and get it addressed in some other way later, if >> someone wants it? >> >> I think someone's hit this on riscv as well. > > It's fixed now with Alan's patch: > > commit 57ae980e3290c0c1a9fb4a93144cc5b24457f05a > Author: Alan Modra > Date:   Wed Mar 31 10:02:08 2021 +1030 > >     Include string.h in bfd.h and delete LITMEMCPY, LITSTRCPY >     This fixes the issue that startswith depends on strncpy being >     declared, and not all projects using bfd.h include string.h before >     bfd.h.  I've also deleted some macros that don't find much use >     anywhere. >     bfd/ >             * bfd-in.h: Include string.h. >             (LITMEMCPY, LITSTRCPY): Delete. >             * bfd-in2.h: Regenerate. >     binutils/ >             * prdbg.c (pr_function_type): Replace LITSTTCPY with strcpy. > > Cheers, > Martin Thanks Alan/Martin. I've confirmed the arm/aarch64 sim failures are fixed now.