From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id slDdDkQOsGnHlyEAWB0awg (envelope-from ) for ; Tue, 10 Mar 2026 08:27:48 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=arm.com header.i=@arm.com header.a=rsa-sha256 header.s=selector1 header.b=NCnpGsM0; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.a=rsa-sha256 header.s=selector1 header.b=NCnpGsM0; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 249401E08D; Tue, 10 Mar 2026 08:27:48 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id DBF561E08D for ; Tue, 10 Mar 2026 08:27:46 -0400 (EDT) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id 66F424B9DB50 for ; Tue, 10 Mar 2026 12:27:45 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 66F424B9DB50 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=arm.com header.i=@arm.com header.a=rsa-sha256 header.s=selector1 header.b=NCnpGsM0; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.a=rsa-sha256 header.s=selector1 header.b=NCnpGsM0 Received: from OSPPR02CU001.outbound.protection.outlook.com (mail-norwayeastazlp170130007.outbound.protection.outlook.com [IPv6:2a01:111:f403:c20f::7]) by sourceware.org (Postfix) with ESMTPS id 0C5234BA23C6 for ; Tue, 10 Mar 2026 12:27:16 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 0C5234BA23C6 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=arm.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 0C5234BA23C6 Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=2a01:111:f403:c20f::7 ARC-Seal: i=3; a=rsa-sha256; d=sourceware.org; s=key; t=1773145636; cv=pass; b=bcnEnr36jZMSKrhbzq5XtkaWyd0rSsqIZFLGHoRkTtcpMBDLr5A8gegVYZrCV6sL2GRKibl1XM68TMJYLA/OHP5zO7t8lqeGHRcgLVRLAjAgykRrDeLsrfuCprJqwmaWb1r2neBf+7nT2cuZWjnmXgn4tdmBeSHMRl8XzDRr6bI= ARC-Message-Signature: i=3; a=rsa-sha256; d=sourceware.org; s=key; t=1773145636; c=relaxed/simple; bh=xJ+7R29kjGrk0L9U4z+VwVbVvPLY8fzvu0oBmQzjJnk=; h=DKIM-Signature:DKIM-Signature:Message-ID:Date:Subject:To:From: MIME-Version; b=hMlzBHm850J7P4O0e2xsMEN8HaVB2DStVsVepXh4UlZ+ZJdeG1QqIcX3iC9/fK49el2soY3Yn9y7AdQfNJb0yDwr3KEccOHSL+OQlNSj1j0HpZnfiJOpSegnkfyJXffZ/FPVujZtcLvd+M8070dd+QJnwY//1NnpaHtn/CwN3Tg= ARC-Authentication-Results: i=3; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 0C5234BA23C6 ARC-Seal: i=2; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=pass; b=QjTsdEpuP1rS63lNgZRofpkG74XuRodWZExOpVnNHp8SlFSVjS1f8Wva3u9CqSBz4ub4b5Wo3HSXSdrUGo6KJJnGkcN45mXTbjAe6VG3aDgBdHTAbEktqAvUGDEPZwi+mgQVMpBfLjyidbi2WqkALraezdbu0/gMrjNrWk0uoSSD+y4e5d2fS4vUtrthvzpsc+hnPwybG05h0Px1bVmB0iY8i7C75ula8TSNOUmclojuo85piZ3ZI65nqc8MVc/uzRUSITPGyqIBAkz3Ox4MYT6slrgdoYtVxDsmInhi0s+gMIv50qTveXEF3bR4+1+KKKNVVci05Se1ImlIadWnTg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=nYKBg1BAjfFt5ut+Y0cu2uAY/f99k8Zvst1PEGF/XJE=; b=JAZy8vPVyHMU6kGdoStDF/RaoEUp5TvPRYIxFwiX9Zk+z4ttVGRrN1cOOhbHnr3IeI1CfCiFqt71PNyMkS7sgBOasZoucU5oT3X4b0CXd/mR3SLPSdLIdb+P/ypFm2ZTZ5l18ga9coxIGIdehVZaZL3XLIvyBSipR+fH54KlOXJ83s+aVkz0mTCemBYEtYj7F9egdH3bqxZ7raq1oH1h4PKDc/kAy7MM0PgtAmim2pv9CixHBEzcPuh01JXsFmSgEdsi1Tjk6DtR61OPfp+lN/wIDAQpBljGomlpukEAHtAmtMt/I0GrW5iH5Kowc7tIFM+rViDI0kRHVQjUv3t9zg== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 4.158.2.129) smtp.rcpttodomain=tromey.com smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=arm.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arm.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=nYKBg1BAjfFt5ut+Y0cu2uAY/f99k8Zvst1PEGF/XJE=; b=NCnpGsM0NwEvg5VstwXEKctK3ipaBNu388e4nZElrK4N/bjrlujgqpiBIs5MI4pQBTEKgXXQbTl4ZtSXgozILxGyqszAfe/biWCmuCIl/4uMHZfh0Hg4o8MPjpPo6A+HMI38GpwRcxljBGa7eLwIs1aNSZEpu7bexGysfHBMNWQ= Received: from AM4PR0302CA0008.eurprd03.prod.outlook.com (2603:10a6:205:2::21) by PAWPR08MB10946.eurprd08.prod.outlook.com (2603:10a6:102:46d::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9678.25; Tue, 10 Mar 2026 12:27:10 +0000 Received: from AM3PEPF00009BA0.eurprd04.prod.outlook.com (2603:10a6:205:2:cafe::f1) by AM4PR0302CA0008.outlook.office365.com (2603:10a6:205:2::21) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9678.25 via Frontend Transport; Tue, 10 Mar 2026 12:27:13 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 4.158.2.129) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=arm.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 4.158.2.129 as permitted sender) receiver=protection.outlook.com; client-ip=4.158.2.129; helo=outbound-uk1.az.dlp.m.darktrace.com; pr=C Received: from outbound-uk1.az.dlp.m.darktrace.com (4.158.2.129) by AM3PEPF00009BA0.mail.protection.outlook.com (10.167.16.25) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9678.18 via Frontend Transport; Tue, 10 Mar 2026 12:27:10 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=onsOnHTCdf4SBlOqA7/hTpABYhIkUmwSmA7p0TXl5UTYNjyfiakeCk0l4k6In6tjkUslakfNdHfl50eh519p4x1VnZra2NF8VvLDcVV4vFAFzTUuA4sKdRKVbyPsGOux3GovaG1K+D3xdKGkbArh6x3GUi1RFXrxiSXh63xqTyh2O54/gVV3wHiEH3CfEJW5BaHjXry78K15Armk0ZQh55EbW3atAr03Q+2ojg9xlWFWfEVXcrSu6vXQovXYQqWWIO/zbCvo/HStH/YlUyb7IPu18dUW6rs2sq8QerP2NTeLIgY/out/kdOfdK93YJ5la5Qf0yyglI2CMatZ8vfK1g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=nYKBg1BAjfFt5ut+Y0cu2uAY/f99k8Zvst1PEGF/XJE=; b=e+PoXpmJZCTpVsYZLJmz8S+JadGxUuKMbD2f2I2bsVThYpS30WWyHQC3n/R1rDzeaP+WrnN710RCage7gj/mEHYmtcLEjFqNwN2P0srD+rWpY19MLosZcC5dDZm+i22WECzsFCoPTtWcrf7JZjTpD0arNXEaGT/Rfzk4Umza2qpZY/U7ERnaiP542xB6xB1P+iM2ymns8s6Jx60b51kGBrLG0K0ruT/lUEk6l6DfLgDCl+3FF/8IDrFbAIdoYE0SL435Drj9YnaNOGgGrgRMI0Qy0ljlCTJVdJunLVzyEwx3Rp2y0MGtgPQHX2+3KFtdUNH1br7YLQjzP6ocfonVug== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arm.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=nYKBg1BAjfFt5ut+Y0cu2uAY/f99k8Zvst1PEGF/XJE=; b=NCnpGsM0NwEvg5VstwXEKctK3ipaBNu388e4nZElrK4N/bjrlujgqpiBIs5MI4pQBTEKgXXQbTl4ZtSXgozILxGyqszAfe/biWCmuCIl/4uMHZfh0Hg4o8MPjpPo6A+HMI38GpwRcxljBGa7eLwIs1aNSZEpu7bexGysfHBMNWQ= Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from DU0PR08MB8663.eurprd08.prod.outlook.com (2603:10a6:10:401::6) by AS8PR08MB6024.eurprd08.prod.outlook.com (2603:10a6:20b:23d::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9678.25; Tue, 10 Mar 2026 12:26:08 +0000 Received: from DU0PR08MB8663.eurprd08.prod.outlook.com ([fe80::f957:cec9:ec8d:7968]) by DU0PR08MB8663.eurprd08.prod.outlook.com ([fe80::f957:cec9:ec8d:7968%6]) with mapi id 15.20.9678.023; Tue, 10 Mar 2026 12:26:07 +0000 Message-ID: <6c340e7f-0944-4ffe-a143-9fe026e96af3@arm.com> Date: Tue, 10 Mar 2026 12:26:07 +0000 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 4/7] gdb/python: allow ref_ptr::new_reference to accept subclasses of T To: Tom Tromey Cc: gdb-patches@sourceware.org References: <20260309175624.236491-1-matthieu.longo@arm.com> <20260309175624.236491-5-matthieu.longo@arm.com> <87a4wgx03j.fsf@tromey.com> Content-Language: en-US From: Matthieu Longo In-Reply-To: <87a4wgx03j.fsf@tromey.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: PA7P264CA0067.FRAP264.PROD.OUTLOOK.COM (2603:10a6:102:2de::12) To DU0PR08MB8663.eurprd08.prod.outlook.com (2603:10a6:10:401::6) MIME-Version: 1.0 X-MS-TrafficTypeDiagnostic: DU0PR08MB8663:EE_|AS8PR08MB6024:EE_|AM3PEPF00009BA0:EE_|PAWPR08MB10946:EE_ X-MS-Office365-Filtering-Correlation-Id: e12b123b-4a8a-4287-8f71-08de7ea059f9 x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; ARA:13230040|1800799024|366016|376014|22082099002|7142099003|7053199007; X-Microsoft-Antispam-Message-Info-Original: f0fUd3vt7wMme/kyQeaP3Bh/2u7rnGfNxfcDN1jbgKehOsaZWZeS0yI8Q8KKOCJndU7nvMDIou2H9vxxeF/M4b5aHZ49xS6risLngxBIewIIF8gfseVC3oAym0ZXpKrB2gbXzfbzljXynIMC9RRAlzklLwXEUzVplY7K56J/vc1kj/B8+BnqQyhe3odVu6BHAWNiELCw2sbHAJdU98e26tnjhbWdErlrXFPxq0Raz0CqYoD8A5uvEKUOS2JdFG3DFeIGtE3/wIT1x4POitcdVGUF+f+vXUjd7CmmVmHwf+ZjTjYPWelz5SWYKUH/fyjFoAqAtyuvTNumI6pG6mOeZ52TrP1mDRPdagFyJ2jbK965/lAPCVcRGSMV7aOTxehgT2Gz5zFt/t87rnPES6KuT1gHaL03RTFoz3sB3k5SKeeLYOVGEi9aJjTwvWsSxoLgwWB6PfeaGGkQ5mxqjPc50ZUqMyRP9M+UYMxIdezM0AaBFR+YQ1SYbeDaTC21lplX4glMJgNEQu5wlu6ywzXjQYY753HU+2+QZd9K4ub8ooNMHYyqO177/Z2U1feFywCG05aLlfvvKMKdZblV2i3WojwVsZLUbKy/mkRFHn/RIlj1UL6ARBqx7hbAmU9f2rsbaruaODfa4N31Roex8N8Da/HJn6fhpra+I/3UoXNxO8RpjWJ2uWVSwyXI9gN/oTQxhGp1YQy+DgNUeVoILonFuETzwYEQwHBd+34ZDlPq3yI= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DU0PR08MB8663.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(1800799024)(366016)(376014)(22082099002)(7142099003)(7053199007); DIR:OUT; SFP:1101; X-Exchange-RoutingPolicyChecked: F52acGAD799mt+3MjgJuQdemV0HtCsyNrL7MKRYvGxsV0ti7pVyRYXfY1RruH9K+AK/JTYDqTgRnoOuF59vqWLS7XPncKX7Q3HNIfK3nisW9Y3I7FKoMTGeyqQrnu3cRlfckm3dU3Yd6jwg3mS60A7srs0uAud3eAOgjkOUkWHUP9/ZRU/dXdZqLqI/j6HROEn9PVNnaWPV5vy6M7gw1pRZtD+fzC0uaW+GJ7DDvBf8Whe8llpKiaiJyKJEmULeo8mZncvjCRDWl3zHUDM4WyjP8inn7+U0/3EHvjbD+EICxHWTj9c570Kho8BTSeROF5zgZ3fwqlbJxg6DeCfSvWQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB6024 X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM3PEPF00009BA0.eurprd04.prod.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 80a457ba-4308-4226-cec6-08de7ea034b8 X-Microsoft-Antispam: BCL:0; ARA:13230040|376014|82310400026|14060799003|1800799024|36860700016|35042699022|22082099002|7053199007|7142099003; X-Microsoft-Antispam-Message-Info: 6PA66lynOscmYCybMpSSGkxyN5GQPGfwubBWzUCIkymjn+7jSXdsUne//FXgrwqKSV4L9fozZ1QEfsXGdWW5EGifOwctxedXQTRK4U/FAbK7OV7gR0SlSGmUenlAF3GEb5MOWhoP8SXXpy6HVM5iNUoCueLzCslzZku4MXtkB+nkSHs9tOdDornfxPfJi4qSM5x+Vn7zeTh9qPaG9lFRWEeGWExEtiHro5HfHXKLVUSY0JMVmATj/lTofTBCmP/9k+e943NMCqUwO/ekGoXu3+CUpqj/i9CJQWIm45V/Nf1/ac4hnxAWetM727jPYBpg2/flvYI4jalmj/ay7kz82UZnZ4amq027/BvCIpV9MQUU8av7fAX1KuUf1V3E3EE5wzo5VskJC4kYt5AVy2r7gu1nkdAWCOKQtoJBjjWGZ/JAZHiI/72Fauf8gRVEf5OLXBw7vdvL/UB5V/PYIl1brc+PFcQ1SDtDvqSxeK2OdspUmdKngnFvzwva5/iHCKLj3M0WtNmJyFnT+uJ6iYAOCpQRw+NsJ0qSwivSokrKBPM5rlsqEWhlFURfTe4f5AWdc0ozNC6SR2MJm7JlFGbuWRB1339j/Je5bv/o2Ur0gDXx9lICpkY7OV43Z+q15mzo7QdGY6g74Aos7dr9SlXMD90aeO7XzsVIjYKvbVsIci3hujNaa/2Axa5e64qdTCXw+6cmOoC33ezhvDiP03NDxBZnCBKNcY7FYqMoQhPl6VlcRgPbNl7kcIgCcKa6ii+4PnWoenBRaIB+J2GCVeTVzw== X-Forefront-Antispam-Report: CIP:4.158.2.129; CTRY:GB; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:outbound-uk1.az.dlp.m.darktrace.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230040)(376014)(82310400026)(14060799003)(1800799024)(36860700016)(35042699022)(22082099002)(7053199007)(7142099003); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: 5QFg3MT3wvdXEZYg+TPrrGF6ZH5oqGy4tnr8MaGkI2I4ij/J4frf81NmSardxsM4O9gpmeYHwFZk7RMdV/HnI5p0VZYmH9iKN74tpgcSIyf0FyBVnwZv7L5FIJYw5pXHY+SQJshkXWp8GTPSijqBt9Uww6B66buDmrPfpYcBzYGF/wvWBKkWTs33wJZUocqelb2/JwP29oGtRqpTlFxGI7h8YQ8qsx7ZxeHwXpPNLhLJ0k3e5pwxxZ7f/Une2OsUcpD53aYhTiaa37CrcjlzbtxtRJaVkAeu5CCx4x8C5boplXFEv9c8GeyCbJaVdpwvouctXNdWOElZCn7+Jiq9eI8rYyRaSVLFyePDfSBHuuoNOFWoDolyII2D4dXi0MHpCz/y5IRektmls33oSGKmcloBm6ZBudfV531mIHL/61M2MAkew2kiZ22RCdBS/Qnk X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Mar 2026 12:27:10.2014 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: e12b123b-4a8a-4287-8f71-08de7ea059f9 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[4.158.2.129]; Helo=[outbound-uk1.az.dlp.m.darktrace.com] X-MS-Exchange-CrossTenant-AuthSource: AM3PEPF00009BA0.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAWPR08MB10946 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 09/03/2026 19:40, Tom Tromey wrote: >>>>>> Matthieu Longo writes: > >> When ref_ptr::new_reference() is specialized for 'PyObject' >> (i.e. gdbpy_ref<>), it currently requires the argument type to be exactly >> 'PyObject *'. As a result, pointers to subclasses of 'PyObject' must be >> explicitly cast before being passed, making call sites unnecessarily >> verbose. > >> This patch makes ref_ptr::new_reference() a template method >> that accepts both T and subclasses of T, performing the cast to 'T *' >> internally when needed. This removes redundant casts at call sites >> without changing behavior. > > This seems fine but I noticed something weird. > > Approved-By: Tom Tromey > >> block_object *result = (block_object *) htab_find_with_hash (table, block, >> hash); >> if (result != nullptr) >> - return gdbpy_ref<>::new_reference ((PyObject *) result); >> + return gdbpy_ref<>::new_reference (result); > > ... this part makes sense to me. > >> for (const thread_map_t::value_type &entry : *inf_obj->threads) >> { >> - auto thr = gdbpy_ref<>::new_reference ((PyObject *) entry.second.get ()); >> + auto thr = gdbpy_ref<>::new_reference (entry.second.get ()); > > I guess it isn't super important but new_reference isn't really needed > for a gdbpy_ref<> since we already have a copy constructor. So just > > gdbpy_ref<> thr = entry.second; > > ... should do it? > I hadn't paid attention that entry.second was a gdbpy_ref<>. Changed to what you suggested. Matthieu > Perhaps an explicit new_reference is more clear. > > Tom