From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id KUnUKGHV3miVuxwAWB0awg (envelope-from ) for ; Thu, 02 Oct 2025 15:41:21 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=efficios.com header.i=@efficios.com header.a=rsa-sha256 header.s=selector1 header.b=UqpCEmyY; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id A34391E04C; Thu, 02 Oct 2025 15:41:21 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id E73721E04C for ; Thu, 02 Oct 2025 15:41:20 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 8B29F3858425 for ; Thu, 2 Oct 2025 19:41:20 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 8B29F3858425 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=efficios.com header.i=@efficios.com header.a=rsa-sha256 header.s=selector1 header.b=UqpCEmyY Received: from YT3PR01CU008.outbound.protection.outlook.com (mail-canadacentralazon11020089.outbound.protection.outlook.com [52.101.189.89]) by sourceware.org (Postfix) with ESMTPS id C64AD3858C51 for ; Thu, 2 Oct 2025 19:40:43 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C64AD3858C51 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=efficios.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=efficios.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org C64AD3858C51 Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=52.101.189.89 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1759434043; cv=pass; b=AYlv18xRaRT60BOEzYgwGQW40UQ6EouMDIH/DeRD0uS2Gv11qrivqHS8HSpKJGjvl1VCG0UMN07vguA5wR07CYCRlhEYXgnrnQ3zIvU0wNS6iV0CikKuqpNnuOzAHCBmnnjXkJNZDk3DHC0T9/m9uXe6sFsdDswHUnF8VEnzX74= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1759434043; c=relaxed/simple; bh=MzNH4UVL+0d/W+qUc1nqF7A38Q80icvm6KECl1wGAxE=; h=DKIM-Signature:Message-ID:Date:Subject:To:From:MIME-Version; b=impjQ1+KvcBo2aFCmo8DhHTtBmN9bBqMqIMSGl/yGVS+x6X2ZynKsevEk5kCgFheF/UKuyUIdJvSAyePaIeQmButQZyXNlYl6koP8NbHnRJWYpU6zb8HOtbvzYKS9dwGzYkor2l+Ukdcje/xvgarDqzrkLlMY4ywGCfO6wx7p70= ARC-Authentication-Results: i=2; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org C64AD3858C51 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=nVYLPm+WH8P9e/w/XPRJ0d22u11EScWTs1R81oFeCztbEi74bMGvv3LNe/ctmwmPFND9EYUjLgnOHlQnaMcXXgxmFE8OHRosjEVrTLrnXMnZCjlBlYBIAf6zdBDp7hNLiBZbpgI0OVVeI5uKAVOcVdEUUoKb+99r4IOHDBusy69H2qQ/dMj2s9qj4i1ATbCDA0ZAaD9kzGMEPL9TNlXVIkftJdJJL0JfUOx+Z3Z08x0W6jkj4dKZPrGZYUzFUnXNq9emuKoEc1vZUIKSg2gobd4ExGFNeL2uzYfZnTSEp5phftUUMI95xTLB1tR+kyvACTdm4x46pBWRtDDE8OnZ1g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=d0D2Ups2tYA5WReXXmf4F51E2+UhkmiFKP9xw/UjQmc=; b=ZvJL94ZTDk/KnADd0jbxO4ce0NerlAmwDmasCpe7tQ2Y4/tv8nwfhMmyCwO6J324DId2PAM1exH6SNa68LWgTx1IdnY74x48BwhR75beaNUkLy9+xpgNWNjGU+1vhsVITecQQ/CP0dIm0S5kHkmjxzp6bkbovkuP6IERvJeD2E5mLyKh+xPSPlZARVLp4O3q6a3acD/eJnmCUDOpudT37y6ACmDdn5M2j/sSwNkOsboVzw6bz+ddnP22n/96+45fsEnrzJefURcg3ZrnrdoQsvrErrwMbBwHO1wlELKYKmi1gG9D2k9uvqFBboME5kwtcPMU7/Y774qufbH7IbK1dQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=efficios.com; dmarc=pass action=none header.from=efficios.com; dkim=pass header.d=efficios.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=efficios.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=d0D2Ups2tYA5WReXXmf4F51E2+UhkmiFKP9xw/UjQmc=; b=UqpCEmyY5yXyn2ct9cdircUL5pU3zhIlekS8SpLZNbl2Q6Y8ej129o5glo2Lla+R0huzagq/8xHKxeXQGq5p2jPzWPOTvPCt82HwjHwwoRPm0Um8oaTvC7txYLBJ9quahjqsYTYjfii9SsSDW9wb0Q+RcgqiU+L19DgibKhrpBnBeS9Hvad6HiNVRT2YiuUQB/UL7unydZTlMrE9ca6btiUt3MUlVyCpY6g4/p3wvG//4LXQGJYByBNNiF1LRRY2bnPExSvVFTSBrLH4tD7gauEQaP76nGfRyRLUADqKDVBtxjC4bwdEtleUNZsIVoMKS/goSHjPqBySN9fDDFqMVA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=efficios.com; Received: from YT3PR01MB6392.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:73::5) by YQBPR01MB10660.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:c01:72::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9160.19; Thu, 2 Oct 2025 19:40:37 +0000 Received: from YT3PR01MB6392.CANPRD01.PROD.OUTLOOK.COM ([fe80::fc93:a379:fc8e:439d]) by YT3PR01MB6392.CANPRD01.PROD.OUTLOOK.COM ([fe80::fc93:a379:fc8e:439d%5]) with mapi id 15.20.9182.015; Thu, 2 Oct 2025 19:40:36 +0000 Message-ID: <6c31b667-db2d-453e-9597-9fe011c4766e@efficios.com> Date: Thu, 2 Oct 2025 15:40:12 -0400 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] gdb: ensure bp_location::section is set correct to avoid an assert To: Andrew Burgess , simark@simark.ca References: <7febb0c1-7bbd-45d5-8ebe-91c34bb4a6ce@efficios.com> <87tt0qe7qf.fsf@redhat.com> <87ldm2dxcl.fsf@redhat.com> Content-Language: fr, en-US From: =?UTF-8?Q?S=C3=A9bastien_Darche?= Cc: gdb-patches@sourceware.org In-Reply-To: <87ldm2dxcl.fsf@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: PA7P264CA0349.FRAP264.PROD.OUTLOOK.COM (2603:10a6:102:37c::13) To YT3PR01MB6392.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:73::5) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: YT3PR01MB6392:EE_|YQBPR01MB10660:EE_ X-MS-Office365-Filtering-Correlation-Id: 8b00f712-3a77-4dd6-daef-08de01eb8f36 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|1800799024|376014; X-Microsoft-Antispam-Message-Info: =?utf-8?B?eUoybm1BcVZ1N25nZERLaDhTbkFYK3JkaWp5UlNjRXZVNzhOS1V0d05TUEhj?= =?utf-8?B?MGsxRnVlM3Nhb1NuNlNLbHA5UjNNWDF5VXh3WTlqZG40NEdEUUFhYTZsU1JD?= =?utf-8?B?eWFCZUVPTXpFWWFNRG9kRFNHWG5hd0JhRmk3b1lweEhFRG1KUkM2NUJ1K2x5?= =?utf-8?B?YWlJMWE1UUtKNkRjWDRxc2U3T3kxTkdQamU0TXVLUTNSZGt3WkFuMWZwY1Fw?= =?utf-8?B?VzJNYXp5RlFVcG0yUFdRcFFIZWs4RUZhblNCZTZBbTM5NjgxN3h3bHdTczZa?= =?utf-8?B?bVdTRTRUT2Vld1dRMGhMNm00dndwZ05xUVE5aEY3QnJGNzV6YW96dWRTeDhG?= =?utf-8?B?L3BjbkFDc1hHbVJBTmxsU2ZaSVBiOVdrTGFKMGYzTUw1ZTJzZ3p6VGlkbDJM?= =?utf-8?B?WVArR3RaWGtmdXVjdDNBZzl3YjVTQWdhdlhjcUdRSWZkd3hqUGZweDlUb05G?= =?utf-8?B?TGh3Rk14SWlYUVc1U0ZhWTlZZW14aHJ0a2czREIzNVRnaWhhNkFuOGZ5cEVn?= =?utf-8?B?c1lFRW5Yc1lDWmJVQmJ3bXMxdWt2MFBCbVVyZzc0K1F3VGQydmpyVUFJTVJL?= =?utf-8?B?TG00K2pZbFI4K3FPRW5RYURESm9DVVN3OFlaY0wxUWhYNkZ6eG5zVzhsbEk2?= =?utf-8?B?YXVwT08vcEV6ZktoWStjYXFEMllzbHRlbGo5TVp1ejZMSHlQb0lZTWJzUUJy?= =?utf-8?B?UWNwL25aVzQ1cVdEVDU1QjhPZWRkbXYzNkNBU294ajZpajV5RHhsV0Q3b3ZT?= =?utf-8?B?RzhiWHVERkROTkVhcWlaTEp1QlFzWktZL2F0akxrYjhvc0o5VytPYnRHbi9t?= =?utf-8?B?cTlqK1FVS2VhTm5US3ZjclViQUk2eUVneEZGOUpjRFJ1RC8xNzkvVnljaFFn?= =?utf-8?B?Uk8zdktZMjFlYmFVYzBFaHdDdEUxclpUUkVpMUpHdVJsaXZlYVBVWTIzVnlK?= =?utf-8?B?Vzh1UDFSNjBLZi9Jckg5K3Y5eDJMWTU5NnRVSEt2TWc0MW41R0YrNnJmbHBi?= =?utf-8?B?TzRiYlVsTjVOLzVUcVBPcHhOdGZHTitNS1ViQzdQVUFRcXRxS1RjdkoxaytZ?= =?utf-8?B?b3hyQndSWDBIOU96a0UvR3RhZ0VzZ1Y4cHloWEIrS1YwRDlmRGRpMTE4WjFC?= =?utf-8?B?eDh6OGZLbDhsanc2dUhjSTNTL2RBYzVmL0xZdTZrcUdTSkNGRy9mU2ZPYlkz?= =?utf-8?B?b1ducmRSb09HSUUydXlzR0c0N2wwc1l5ZTRsdTJtUmhOMWVtTVVjSUdTeHFz?= =?utf-8?B?alc3SGIxY29DK3pKMFhpVjRTWHVpTVcySkNKU3R1WVltVi96OEFEVTVmblV6?= =?utf-8?B?V0dXbGwvVFE3Wi9BbFJielFRVjBDclVDbWNKZS9tcW9zSFNkenVQQnFxVEFB?= =?utf-8?B?cEN3OXVyWXUzNVdmdlk0SmUzUHFQakhBWXRDc0ZCVjNWTUxmYWwwNW1heVlp?= =?utf-8?B?VHA0Nk9lRkRaeVFVTFIzeTgvcUNOZDFEVVdmYVkrYUhIUVp0OCt2L1pWWHgw?= =?utf-8?B?UmdhMEtMV3FCNzN5eUpPSVRVbWFMNnRpMldhNDEwWEVkdjdBdEJJWDVvU3BZ?= =?utf-8?B?aW4ySXBucGxNNkM2Wnk4Sk1XdXNMaEplUmEzVnZYdE81RUpnRmdRRUY4MFBY?= =?utf-8?B?aDBENGJoRkJNak40SVR4ejRVOU9URU8zNEJ4dVpnMU1rWUtCWlRiTDFsaDJH?= =?utf-8?B?VFgyU3NINHNOcjRYQktvVUlLb1VyZUQ1T2VBakR4VWZZUmZBRHZxNGZMYVQ2?= =?utf-8?B?Z0Rxak5MV1pJbTVZRVV2ZFUvNThyN3JQZHFxUFhwQ01NWGlOTjZTL0QvUTJQ?= =?utf-8?B?Vk5uaU5rV21KVHpMVkV3SmpPRVE3S29xTEdkMlVLTlRBTjBFWW5IQmhZSkV4?= =?utf-8?B?RUlqUDRIUDRyUUZVQTBtWjEvV1dGalUxdVNoK2RPVDc5cEE9PQ==?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:YT3PR01MB6392.CANPRD01.PROD.OUTLOOK.COM; PTR:; CAT:NONE; SFS:(13230040)(366016)(1800799024)(376014); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dDg3NU5HOEdIaTFZc3JOVE4yY3BKN3g2Um1DWjR0YXcreUpDZmEwYzJZSGNn?= =?utf-8?B?dHRkRW41bU85M2o5SG5oeGJldEdHUFUwMXBrc0w0cklMcTIvdTJWK0tpQ2VZ?= =?utf-8?B?MlBvMDdzRUltV2hFSXlhK2JEckV0SS9WZ0c2K25jcVhoNERJam04M29ER1hm?= =?utf-8?B?dkFZWFArME52ZHhqbEtIKzM2QW1oUW5RTHlSeklkUTA2dHNLSXN0YyszVUd1?= =?utf-8?B?cDFZaTZTNllaelg1TlNabExmK05veU40bWZOMGl1Q3NhaTR4SnluNmNza1Fs?= =?utf-8?B?TzFlWnFHSHR0T21JK1ZYVDJJYmE1cS9laHkxejNWcFE5aU5wM3RoVGRoYTN0?= =?utf-8?B?Z3RJUUM0OUIzcTVrQ1c0UVczNVIvOEJCRVpucEEzZ0o2N1NqNGhZY0VCeXg0?= =?utf-8?B?R09GZlFqRDZiYzJXMitUaHdHT2dJcE5wYWVENDlNVjNvMXVmS3dzS3EzeHpw?= =?utf-8?B?OEkzSDhCTnptQlo3V1RTcW5Ia2tRZkJyL2crdnRSUnVHTk5Yb0Y5ckxlQVN6?= =?utf-8?B?a0t0emZPbHBlWDJYUHlwTEtoRWFQQVE3azFMMDJNaWJvaHRrUkRnQzV3c3BO?= =?utf-8?B?N0tzd1VkSktBeTZGTE1oRWpZMXJrU2hFc3RlOXhram02M3FXVm9YMHRWNXJL?= =?utf-8?B?ditqMjJpU04wOFIvblVIRnRLVVJnWm96SndhWVJXc0ZoeTFYdmN6YzEyV1JE?= =?utf-8?B?OWtmb2FzbndPMVo3Z3l6VmtSeVVFUEhvUlpEZkMrMFR1cXh2THBsa3lERXpB?= =?utf-8?B?ajJqckVsR05Hc04xZGFKRDk3K3RSMm9pSUpiRFptOXRwQm1OWndDemU0M21s?= =?utf-8?B?bjBpRTBaOWV3TTNManBhNklrZWQ4K0I2dlJOTjgwdkxBLzYvWlNkRzdFQTNy?= =?utf-8?B?c1FxcHZEakxQcDkxUlBIRG93a3Npc2tpZEFndkJ3bXNLQ3ZCUXd5N0lGT2xU?= =?utf-8?B?TDAzQ09rNi9EcTJna054Ymx4TWptaThkK1pxZlpsZkpkQU05K3NGWVRjdFlT?= =?utf-8?B?QTVGeEJ5VFk0WlhOaU5QYm5kV0tTL1NtdE9SL3JPMzlMMnVGcWVKZFNsSVFx?= =?utf-8?B?bkkyUUxiYk5ZeVE0S0RMazJKcHl1UFN4QVBEWmg5ZExKV2cveFdLcnVoTGd2?= =?utf-8?B?VmxFeGMrcldsR1gxbm8xaVBBSEJxUlNFTzBRSVpwU2ViOStjQlJQUzYrQ3p0?= =?utf-8?B?dlprUjk4L3RWYkVLWGFBdE9CQ0k4dUJoMU1MV01oWlNocXZLRGdFY2dPU0hE?= =?utf-8?B?WWNOQmk1dGlLZDZpdFVNYTVCN3pVa2pyOTF5WjA0KzVuMTg3aG9ibGh3cU1T?= =?utf-8?B?UG14eXk1bmExaHJWazZpTmFtZWl6ZnI2N29hem9TWUZRL3R1UjNaQTl1YXI0?= =?utf-8?B?bDlCWUNuQVVnVHc5Tjc5VWR2T1JaVkdBcFFLT2RJUk5OdFZ1cGdRLzRCd2RB?= =?utf-8?B?QXB3VHNWbTBSZklhYStwdGJreDFveFhNRDI1RFZiRnFBMlNMQ1pVR3lkUC9v?= =?utf-8?B?VHoxTHQ2ZHNFMFV2Y2xoNnpsYU5XN1g2eERJdnVWcVY0VllWZVM3UHIwOFpm?= =?utf-8?B?YzEyckdQQlZPUHpxZEdwcVk3eTVpTEZ0WXNiQWduTVFmQ3p2NUJxU0IwRUZE?= =?utf-8?B?eUVxNGt6VVAwSUswSThNampicUFUc3BpeFNSOWQxWjhnWXVqcmg5aFRhYjhX?= =?utf-8?B?VitKaDlxTDJtdStvTXVXZmttVGJxbkJXSkV4ODl3cFgwdkNVa0hpK0l0dnNx?= =?utf-8?B?WVp2L1RSYnlxZ00vQkpIZTkrM2FFL3M2QkhTSFJJYWQ0SVAzUWF1SWF5MU9h?= =?utf-8?B?enNIYlZ5Y0xQSnlubHpBZGZ0M0UzSFJsYmFMSEptZ3RVQ1kwTkxnK0IybkRr?= =?utf-8?B?WEpBZXhyNDhLRG56WFJWZkVrdDRtaHkyS3JoVXhSaE9JNUtMVFpzc3JNRWhn?= =?utf-8?B?UTR2SFRVMlhhNWZSMlpVV08rR2JBRlBlN3RCREVuNkZGcFpxK1pmMmxQcndU?= =?utf-8?B?NG16Uk9KWTFyazBQcklYQUFMMUNmcFJwZGpib1hIeTFRYlIzczJROFJwZFVR?= =?utf-8?B?R2h4YmxjQU1HMlJmVnFEM2RRcnBOVE95bStRYm5XMzE5VllxNXBkSCszMEdR?= =?utf-8?Q?wF4Q45qKLZG8zZnKU0AhLWeX4?= X-OriginatorOrg: efficios.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8b00f712-3a77-4dd6-daef-08de01eb8f36 X-MS-Exchange-CrossTenant-AuthSource: YT3PR01MB6392.CANPRD01.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Oct 2025 19:40:36.7551 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4f278736-4ab6-415c-957e-1f55336bd31e X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: wpVc3bdBQbB+aEQ9WqthMGhgUvG+aaf2zvfz8cJl6pw/fVtFDcxEVbRqK3r2V0UFGTHrvbeVjKl2F0zC2FPtSQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: YQBPR01MB10660 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 9/25/25 17:40, Andrew Burgess wrote: > Maybe the answer is as simple as moving the .section assignment into the > earlier if block, something like: > > if (is_function && want_start_sal) > { > sal = find_function_start_sal (func_addr, NULL, self->funfirstline); > > /* This breakpoint is for the ifunc case, FUNC_ADDR is can be > anywhere, in a completely different section to MSYMBOL, or even > in a different objfile! > > TODO: I haven't checked, maybe find_function_start_sal already > fills this stuff in for us? Or maybe it could be made too? > For now I'm assuming all we have is an address, but this needs > checking. */ > sal.section = find_pc_overlay (func_addr); > if (sal.section == nullptr) > sal.section = find_pc_section (func_addr); > } > else > { > sal.objfile = objfile; > sal.msymbol = msymbol; > /* Store func_addr, not the minsym's address in case this was an > ifunc that hasn't been resolved yet. */ > if (is_function) > sal.pc = func_addr; > else > sal.pc = msymbol->value_address (objfile); > sal.pspace = current_program_space; > > /* We can assign the section based on MSYMBOL here because the > breakpoint is actually being placed at (or near) MSYMBOL. */ > sal.section = msymbol->obj_section (objfile); > } > To answer your question on whether find_function_start_sal does fill this for us : it depends. It manages to do it on amd64 but not on amdgpu. By default, the sal does not contain a valid section. It's only when we try to adjust the pc past the prologue (skip_prologue_sal) that a section is computed for the pc at the start of the function. If we do have a prologue, then we assign that section (symtab.c:3914). If not (and that is the case on amdgpu), then we're left with an empty sal.section. I would say the behavior is not really consistent. I would agree it could be made to. > Does this look like a valid path forward maybe? Your solution seems to work for the gnu-ifunc test and fixes the regression for gdb.rocm/displaced-stepping.exp - so I'd say it's a good aproach. I am not familiar with overlays, so I can't really judge if the change would impact how they are handled. I think it would be best to ensure find_function_start_sal has a consistent behavior across architectures. I'll submit a small patch which should address this. This would also at least reduce the chance for another bug like this to appear somewhere else : > So then you'll have to add a find_pc_section in _another_ place.... Sébastien