From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 103362 invoked by alias); 21 Sep 2017 13:20:13 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 103311 invoked by uid 89); 21 Sep 2017 13:20:13 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.9 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 spammy=palves, HDKIM-Filter:v2.10.3 X-HELO: jupiter.monnerat.net Received: from jupiter.monnerat.net (HELO jupiter.monnerat.net) (46.226.111.226) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 21 Sep 2017 13:20:11 +0000 Received: from patrick.monnerat ([192.168.0.128]) by jupiter.monnerat.net (8.14.8/8.14.8) with ESMTP id v8LDJviY009095 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 21 Sep 2017 15:20:03 +0200 DKIM-Filter: OpenDKIM Filter v2.10.3 jupiter.monnerat.net v8LDJviY009095 Subject: Re: [RFA 61/67] Constify some commands in breakpoint.c To: Pedro Alves , Tom Tromey , gdb-patches@sourceware.org References: <20170921051023.19023-1-tom@tromey.com> <20170921051023.19023-62-tom@tromey.com> <3276247a-a93f-d54a-91f8-fb397a1b05bc@redhat.com> From: Patrick Monnerat Message-ID: <6c02521b-0e43-ffa0-b756-634a560e4586@monnerat.net> Date: Thu, 21 Sep 2017 13:20:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <3276247a-a93f-d54a-91f8-fb397a1b05bc@redhat.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2017-09/txt/msg00630.txt.bz2 On 09/21/2017 10:56 AM, Pedro Alves wrote: > On 09/21/2017 06:10 AM, Tom Tromey wrote: >> This also makes delete_command static; but now I wonder if it is used >> in Insight and should not be touched. > .. > gdbtk/generic/gdbtk-cmds.c: delete_command (NULL, 0); > > I guess it'd be mildly nicer to add some "void delete_all_breakpoints();" > API instead of abusing the command callback. > I've just added such an API to the insight code: https://sourceware.org/git/?p=insight.git;a=commit;h=7dc503fbf209ec7f39771c2bf5e45e01974f18c5 It works fine without calling delete_command(). Thus it's OK for me to have static delete_command(). @palves: many thanks for having raised the flag before commit. Patrick