From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 0BPAM7I4AGJvFQAAWB0awg (envelope-from ) for ; Sun, 06 Feb 2022 16:08:02 -0500 Received: by simark.ca (Postfix, from userid 112) id D1EC01F3C6; Sun, 6 Feb 2022 16:08:02 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-3.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,NICE_REPLY_A,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 70A9A1ECEB for ; Sun, 6 Feb 2022 16:08:02 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id B46423858C3A for ; Sun, 6 Feb 2022 21:08:01 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org B46423858C3A DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1644181681; bh=avHaVNsOqRxR4XXWOVr7Z6NoFkU7YjA00CmmmXASFHk=; h=Date:Subject:To:References:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=BEYcZOMCEJyY3j6oULbLCJblvC3zdhtnrD7OfBsevAFS0ANtNQGiMPeDm4aQzIrtr gHiAbMYw3sfPfh3+rbFNWBt9FknKRxsQTqA3/iMtIX9expMlOIv2nCMGxeNX5ihDDi /K85zXkFU7d48fe/nLRi5r8PCJaajcvofghCZcJ8= Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id 034E33858C74 for ; Sun, 6 Feb 2022 21:07:42 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 034E33858C74 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 216L7ajG001659 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sun, 6 Feb 2022 16:07:41 -0500 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 216L7ajG001659 Received: from [10.0.0.11] (192-222-157-6.qc.cable.ebox.net [192.222.157.6]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 9BCC31ECEB; Sun, 6 Feb 2022 16:07:36 -0500 (EST) Message-ID: <6be2dec6-8068-19a9-29e6-41320c4f0cb7@polymtl.ca> Date: Sun, 6 Feb 2022 16:07:36 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.1 Subject: Re: [PATCH 00/33] Remove some more accessor macros Content-Language: en-US To: Joel Brobecker , Simon Marchi via Gdb-patches References: <20220128124531.2302941-1-simon.marchi@polymtl.ca> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Sun, 6 Feb 2022 21:07:36 +0000 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Simon Marchi via Gdb-patches Reply-To: Simon Marchi Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" On 2022-02-06 10:22, Joel Brobecker via Gdb-patches wrote: > Hi Simon, > > On Fri, Jan 28, 2022 at 07:44:58AM -0500, Simon Marchi via Gdb-patches wrote: >> Most of this is mechanical, so probably doesn't need too much review. >> But there are some changes near the beginning that move compunit >> functions and methods, that's probably worth looking at. >> >> Simon Marchi (33): >> gdb: add getter/setter for compunit_symtab::objfile >> gdb: remove COMPUNIT_OBJFILE macro >> gdb: rename compunit_primary_filetab to >> compunit_symtab::primary_filetab >> gdb: add compunit_symtab::add_filetab method >> gdb: add compunit_symtab::set_primary_filetab method >> gdb: move compunit_filetabs to compunit_symtab::filetabs >> gdb: remove COMPUNIT_FILETABS macro >> gdb: remove COMPUNIT_DEBUGFORMAT macro, add getter/setter >> gdb: remove COMPUNIT_PRODUCER macro, add getter/setter >> gdb: remove COMPUNIT_DIRNAME macro, add getter/setter >> gdb: remove COMPUNIT_BLOCKVECTOR macro, add getter/setter >> gdb: remove COMPUNIT_BLOCK_LINE_SECTION macro, add getter/setter >> gdb: remove COMPUNIT_LOCATIONS_VALID macro, add getter/setter >> gdb: remove COMPUNIT_EPILOGUE_UNWIND_VALID macro, add getter/setter >> gdb: remove COMPUNIT_MACRO_TABLE macro, add getter/setter >> gdb: remove SYMTAB_COMPUNIT macro, add getter/setter >> gdb: remove SYMTAB_LINETABLE macro, add getter/setter >> gdb: remove SYMTAB_LANGUAGE macro, add getter/setter >> gdb: remove SYMTAB_BLOCKVECTOR macro >> gdb: remove SYMTAB_OBJFILE macro >> gdb: remove SYMTAB_PSPACE macro >> gdb: remove SYMTAB_DIRNAME macro >> gdb: remove SYMBOL_MATCHES_SEARCH_NAME >> gdb: remove SYMBOL_ACLASS_INDEX macro, add getter/setter >> gdb: remove SYMBOL_IMPL macro, add method >> gdb: remove SYMBOL_CLASS macro, add getter >> gdb: remove SYMBOL_DOMAIN macro >> gdb: remove SYMBOL_OBJFILE_OWNED macro >> gdb: remove SYMBOL_IS_ARGUMENT macro >> gdb: remove SYMBOL_INLINED macro >> gdb: remote SYMBOL_IS_CPLUS_TEMPLATE_FUNCTION macro >> gdb: remove SYMBOL_TYPE macro >> gdb: remove SYMBOL_LINE macro > > Thanks for this patch series. I reviewed the compunit series untit > you started adding the getter/setter or eliminating the macros. > After that, I only scanned the patches (burp, 'scuse me!). > > FWIW, those patches looked good to me. > Thanks for checking, I will push the series shortly. Simon