From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id oJqkKrZVmGkSsQIAWB0awg (envelope-from ) for ; Fri, 20 Feb 2026 07:38:14 -0500 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=labware.com header.i=@labware.com header.a=rsa-sha256 header.s=mimecast20220511 header.b=XKdiaLoI; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 98BA41E0BA; Fri, 20 Feb 2026 07:38:14 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 7148C1E089 for ; Fri, 20 Feb 2026 07:38:13 -0500 (EST) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id DD23F4BAD14E for ; Fri, 20 Feb 2026 12:38:11 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org DD23F4BAD14E Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=labware.com header.i=@labware.com header.a=rsa-sha256 header.s=mimecast20220511 header.b=XKdiaLoI Received: from us-smtp-delivery-114.mimecast.com (us-smtp-delivery-114.mimecast.com [170.10.133.114]) by sourceware.org (Postfix) with ESMTP id 359EF4BA543C for ; Fri, 20 Feb 2026 12:36:37 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 359EF4BA543C Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=labware.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=labware.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 359EF4BA543C Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.114 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1771590997; cv=none; b=YlCsq9ES4Y28HLCcc3Zb/gOBg8Msx7Ihv8DMB5C9UtTrMsGf4xDs2inVegzaRSBBsu3kepf9M10lOwIT/mAPgGG0Ow1UAFqnWiOUEcH0CirxskXVCKDWLS4/DkkRVNLkdwICHqpzRGX7PAsXDJq00kXsZ1CRgPusmxiuoz+J1w8= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1771590997; c=relaxed/simple; bh=Yj/YzwuAR4Hj8nlLSA+UeZalOORt2KI4pIdQ4k2ERrI=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=SyMTd/w4aj6YUGJm1ObXcEPJ0d4wWlLOH07dRTtVF6AdTUpfU1sMaP6927QzC7G0S/Y0SGBhqXPIsx+s3Th/wHk8KNdKrD9Xw2s9R8mT5Z+AcpLz1kxRB/P765BdnCYBaqW2TLDuI11qaaD0BdPwQ9EEfX3NZ5ZG65FfDGmU/qc= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 359EF4BA543C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=labware.com; s=mimecast20220511; t=1771590996; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=En7G1MSQyBG3plhDVuLTuEL0hkUuQQhRqZH/nvUljZA=; b=XKdiaLoIl2r1k9CO1TgTq1LM2e/6jGWyGNXFAYSntGe1+f7BNRC5HIa9JFriOWQ77f+HUL InohJMX0a6ANfxlILj8ITCYmdSQGEK2t36YD6Szq1HuVj0gQ6jhq5Jp8CwSgp5iFJ8qH+H NQy8Mvx1sAWcD0Md8FyUy64e17ntLOY= Received: from DM1PR04CU001.outbound.protection.outlook.com (mail-centralusazon11020113.outbound.protection.outlook.com [52.101.61.113]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-76-h8Uc3NWqMpSXlWIpiGwCRg-2; Fri, 20 Feb 2026 07:36:34 -0500 X-MC-Unique: h8Uc3NWqMpSXlWIpiGwCRg-2 X-Mimecast-MFC-AGG-ID: h8Uc3NWqMpSXlWIpiGwCRg_1771590994 Received: from CO1PR17MB5369.namprd17.prod.outlook.com (2603:10b6:303:e8::10) by BY1PR17MB6781.namprd17.prod.outlook.com (2603:10b6:a03:52b::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9632.17; Fri, 20 Feb 2026 12:36:31 +0000 Received: from CO1PR17MB5369.namprd17.prod.outlook.com ([fe80::c9b4:108c:cf02:e200]) by CO1PR17MB5369.namprd17.prod.outlook.com ([fe80::c9b4:108c:cf02:e200%5]) with mapi id 15.20.9632.017; Fri, 20 Feb 2026 12:36:31 +0000 From: =?iso-8859-15?Q?Jan_Vran=FD?= To: "tom@tromey.com" CC: "gdb-patches@sourceware.org" Subject: Re: [PATCH 1/7] gdb: implement readnow_functions::find_pc_sect_compunit_symtab Thread-Topic: [PATCH 1/7] gdb: implement readnow_functions::find_pc_sect_compunit_symtab Thread-Index: AQHcodGeVjB0dO14AkaTsiJewONJKbWKcXxqgAEV8oA= Date: Fri, 20 Feb 2026 12:36:31 +0000 Message-ID: <6bdb19fc83d8e9c75a32947f1420bfca30a375eb.camel@labware.com> References: <20260219185638.360694-1-jan.vrany@labware.com> <20260219185638.360694-2-jan.vrany@labware.com> <87ms144i5r.fsf@tromey.com> In-Reply-To: <87ms144i5r.fsf@tromey.com> Accept-Language: en-GB, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: CO1PR17MB5369:EE_|BY1PR17MB6781:EE_ x-ms-office365-filtering-correlation-id: 18faa085-323b-4186-76ed-08de707cad38 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0;ARA:13230040|366016|376014|1800799024|38070700021 x-microsoft-antispam-message-info: =?iso-8859-15?Q?vX1iheMjt5CJBzeJ1oKwg7Tikf1fBXGF42fE7tIv+2ocxDTQXmfIri6gM?= =?iso-8859-15?Q?GhdXbUfSK54aAsuudv4n1L3P6a/7lhIOz2PUmHhzLcMj0l8ODzAgXmP4v?= =?iso-8859-15?Q?sfVuHWQCz68a2Zr+vjYGZUCDHtV6np4vdBKTBb2QPyOQRtSZWeMJLGJtX?= =?iso-8859-15?Q?NXaQtXZVJDFWFYjn6CsbjSDk895taG3ZvHgDOV1JlwSY1qB7m5Kj2yJwE?= =?iso-8859-15?Q?kzXgCc1VfM4VmyEbmhnqTHeAS2QNNl61DQ5EDrr3BBJTXNHNUBUISTHJ8?= =?iso-8859-15?Q?/sxeWvKDe5Cflu7ek3hDQEg4I+kzjI1K4H6SMaFyxUdWdmz8oPfAKP7bc?= =?iso-8859-15?Q?PEqB79G372turkukxB+DEZPRjq3OqJb6mMdVAYO46Uxuz0ziTixhR+hq0?= =?iso-8859-15?Q?e6q3cgVVbhHugXhfyg+EJNwCxYieSNDHDtknDnGUGJ0S0pTWRqaLosnE9?= =?iso-8859-15?Q?Chjqn3Njd99pTUIFQNcV3XXRWT0IFgsSoukYBUDTa4cPnBlCTly50g8X4?= =?iso-8859-15?Q?xqx8KzcsHLDMRvWNB+aZU8SpnD7uuPqZlueoijkFTxH7HlT/V9YQbU8m7?= =?iso-8859-15?Q?HOFmGRbQ+Dg7SAPeoodZCbD9AokcE1rD24mavHeW9QskwHnvU2ZoeF5Wo?= =?iso-8859-15?Q?yPfc+JYHOjZlS8m/oIUCOqIkRr3LWQ6vijxZvNhk8V1gUF6GRfHO6mPba?= =?iso-8859-15?Q?b+MyhuIiOsOto8ZgW0T2uzfZqExGsdbxPOpoMU0DqEoDsbrDgA7shLNKq?= =?iso-8859-15?Q?TKLGxz7pNuk1+4yGFyPfM6Sa2Cr7ruP3Ts1BcSErrTB1HCTT/eOC21pg6?= =?iso-8859-15?Q?iuVkCrCxWMil527J9maWFUiHcpMedPtYLprJxo36EApnbdvGN9tI2kSMN?= =?iso-8859-15?Q?bzjMsAUEaabSc5YmkhQ4HGZbxSYDIAzcdjCINcH4aWibOsSIFaaTupbpA?= =?iso-8859-15?Q?MRn0Q/xXDVps2dFCEqnL7B8Fb45xiiQXEvMHGfh6geB2Le2N0FCZ4qaX4?= =?iso-8859-15?Q?0W96y1AFVkkxZJBPwzvEFAis664lEvfSp2RMn3HLYDoxlILDoekcI67Ex?= =?iso-8859-15?Q?tMdiLa7QANyuC2fxSNOrBx0QqXK9qWhuYLsJAd8fltJl3NAlcV3udW+dc?= =?iso-8859-15?Q?rgIRuoeVKszp2VNZfqACs5A77zCTnP852MFWw3Omj6dr6UvMrjtwhbbvz?= =?iso-8859-15?Q?DzzZKiUZiDiTU16kj2gjqStx39cw75zUZRNAXhgks02r/3m6WM1/oksAx?= =?iso-8859-15?Q?ETgRHCrL/Li4x3sZXCE0jl6xqD/Ub7hTpDIv2WNR2hJmRVHnF3fkmf1V5?= =?iso-8859-15?Q?Uux3x4ZMrXcXO0sEbHE6GGvhU3061zsQ11fx7LLglLI9TGd6VncBvEgUr?= =?iso-8859-15?Q?8vk7od0VYXMYK5YdFExsepwToNeANYevJSDH9uYPYWzSIjKEh8ouwOAbK?= =?iso-8859-15?Q?SCTMl4hVBvyHKJQYQu6xMj/5XDkRBODQdtPH+Wj2lMh+dFY6W0eBwXdui?= =?iso-8859-15?Q?87zdM8jPGCHlWOIMlfu+PqFvLb5Sgmd3nzPl7yq5dLwxtdEAlS7hnHR+P?= =?iso-8859-15?Q?8bQ7W/Syhu+pqotVb3RAtMADS3ppCEDhXgVC7QsVAgQsTnACJ+1rkJLJC?= =?iso-8859-15?Q?HQ8TR1yUjyo32BN093DrLrOp7WYVEkKNKPbkkhIXLNtJRHAq9cJUQPkWK?= =?iso-8859-15?Q?Q7aEVriN6t8tvTVlXgwWRGDRozdWNKtpQgqka7kUtsG6Rr0=3D?= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CO1PR17MB5369.namprd17.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(366016)(376014)(1800799024)(38070700021); DIR:OUT; SFP:1102 x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-15?Q?4t8CZMVKGWDPXHcteLU40iCSVvUOfM6zldMC1nhJROicV8lS9Q5PKxRtU?= =?iso-8859-15?Q?N+blmkeKntu6G7vRbNRw1ddVGZqQSeqfAR8J8ouUobeIyba1x0wA0CVKg?= =?iso-8859-15?Q?mks8NC4o7+XzULvvx7t333bNKy9fEEvrW0jv8eHOJGhx03z37pEJPxfhw?= =?iso-8859-15?Q?+4QlnW9Wt0Milqyz/bT8EFszZEx8EfsbeX6CW6ySchsTreCluoU8chtRo?= =?iso-8859-15?Q?xlLFwN396sAgcpn74FKRX86gqmRE6TG6YAxVDw+TSXuzpfSsWHo3sIV16?= =?iso-8859-15?Q?PlCRmQEVo5IDsqLNqdw+EIHTYT4i+wSvaDosk/5TatlYy/TbSQssmz8nh?= =?iso-8859-15?Q?lIIAwbGX1eRhbGfZwXkOVf6sqcFpPMfSCW2FElvGpgId9n/I4MLO3n7X9?= =?iso-8859-15?Q?znZWphrPcD7QOYBu4irHr8wb0ogh39D7gnIUlkIExBVF9fck2Ir+FbL5e?= =?iso-8859-15?Q?YRj+WS7vByTV9bpTtlPrikObVaQILFsTQAJ4I9J5dm5vHukYqFimX0N6p?= =?iso-8859-15?Q?F2PE8DyAQqyGsHh38+3YBpxtoJ2ibqVf4JbeSTAw2rlm49ynS5r9YCEdF?= =?iso-8859-15?Q?U59/kBDt7+oibnk2d8Mo9h/Z7vDusgZn6w/cR/f+7P3ExEOCxmftprZVL?= =?iso-8859-15?Q?RvmRVASy/yxQIZDP9nBzN6G6CCuwHeonCObbkAGUk2xG0RIwYnijG9iVU?= =?iso-8859-15?Q?4XbkRub+/FO5z1PPamOQZ11C5bA5WX5Xt4wnVqp6EUEdedGr0jcL9/TRO?= =?iso-8859-15?Q?LVHduOK+czpEiok7zAiiEioie+pPDR/ZaM2yR2oSM+sWnUDSLNVoiJqxc?= =?iso-8859-15?Q?6j3S4l+G/qYv21r+/p/8HZ9lEiBf5I7L1xN1zfhqpycskEqkkJlJSzW41?= =?iso-8859-15?Q?nECy+sT7EGD77AD2na75+6mZ6D5AYg0qc8CkWI+GMJr7I5h7o1H6S1gR8?= =?iso-8859-15?Q?7UOJgVe5OsSBP/DXO9ZgpLLS/dkeRgtqoWloVdkFgy2L9vurtKSdNsh9z?= =?iso-8859-15?Q?MRvTf/d+qTQP2eKmkkqdjGxVDPTXbp0Dz7Jegzl5tkR2L6B5hJ0lW0ipK?= =?iso-8859-15?Q?QmoI7GRnLhimRu7d15MJr6FL4guSimyFX8PM1IC6IGOyPoJ4s4RMTLuKF?= =?iso-8859-15?Q?e3PvB8eSSC0JzVd8yC8t7x4Thgn6S4mSdObKs79SLIWiBAs8rY2BrJy4Z?= =?iso-8859-15?Q?1h5CTUn3xRc6opKD3Cl1JtowP3MDGBs2YVUQhQB3drXVdSNm7PSiceLhZ?= =?iso-8859-15?Q?8zitRl/AzRu08GEY9iSIdCNnq0UGYranH9g25ZBJey8kbyo0doTcIbtDC?= =?iso-8859-15?Q?nV3VW6+fosmLaa7EzcIVhWIFTW7OriXvVYUn7rBqtoej9745LynmYBwZi?= =?iso-8859-15?Q?wfBua/Ock4cQ7i7kRH1rnzi0xSHFMvwqH61r1jaJa7QS7OKKKVjdfTiMZ?= =?iso-8859-15?Q?D8cyYkuZgnlKvOKt26TQEqv7ju5onbUeVcpMu3OIzEydvCr8Rn8QyuJyi?= =?iso-8859-15?Q?s/DHFCRPTjhgLvm/p/orH9WLelNzebZgpkzP1OwZBw2u39w5YiYS8PcwS?= =?iso-8859-15?Q?0bxGYJMES26MyDeJhH3MQEfI2OBoqoVFb0QpzSWLqi/FTuH6UBECRjeTD?= =?iso-8859-15?Q?rVj48lQGdy3/zbC4iDN/8yLNomjwiA+EyLObJltBCD8ily9UXIPexcT1h?= =?iso-8859-15?Q?tvCktiCUfU7+94drnxGUu2RAk//F1z3Akkneiuna8Lo0wB8pp+8Keh4Cl?= =?iso-8859-15?Q?YLWgdx63LKbJ8liwHJf77J5IPkmX5tSDVA+HanYO9NW2ZoOnLosHfU7wM?= =?iso-8859-15?Q?m56stX6jsScyq2Cw7oyegcO/dbRQntWHCvbuIkpw=3D=3D?= MIME-Version: 1.0 X-OriginatorOrg: labware.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO1PR17MB5369.namprd17.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 18faa085-323b-4186-76ed-08de707cad38 X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Feb 2026 12:36:31.7437 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: b5db0322-1aa0-4c0a-859c-ad0f96966f4c X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: ywhpIUEDJWKnVJH3C8yRfjpOhOzpIIAqB9adgZ0+/GuBPH5aXrvn9JQjAC5HMPFpsrhq/iwDb+65K3bVRjHGJg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY1PR17MB6781 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: p-ttqR4ukNBISvGjy2AFo_RLas8Hqh7EZ22c0OMFvgs_1771590994 X-Mimecast-Originator: labware.com Content-Language: en-US Content-Type: text/plain; charset=ISO-8859-15 Content-ID: Content-Transfer-Encoding: quoted-printable X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On Thu, 2026-02-19 at 13:01 -0700, Tom Tromey wrote: > > > > > > "Jan" =3D=3D Jan Vrany writes: >=20 > Jan> +struct compunit_symtab * > Jan> +readnow_functions::find_pc_sect_compunit_symtab > Jan> +=A0=A0=A0=A0 (struct objfile *objfile, > Jan> +=A0=A0=A0=A0=A0 bound_minimal_symbol msymbol, > Jan> +=A0=A0=A0=A0=A0 CORE_ADDR pc, > Jan> +=A0=A0=A0=A0=A0 struct obj_section *section, > Jan> +=A0=A0=A0=A0=A0 int warn_if_readin) > Jan> +{ > Jan> +=A0 dwarf2_per_objfile *per_objfile =3D get_dwarf2_per_objfile (obj= file); > Jan> +=A0 dwarf2_per_bfd *per_bfd =3D per_objfile->per_bfd; > Jan> + > Jan> +=A0 /* This invariant is documented in read.h=A0 */ > Jan> +=A0 gdb_assert (per_bfd->index_table =3D=3D nullptr); > Jan> + > Jan> +=A0 /* Since we have no index, we simply walk all units until match= ing CU is > Jan> +=A0=A0=A0=A0 found (of there are no more CUs).=A0 */ > Jan> +=A0 for (int i =3D 0; i < per_bfd->all_units.size (); i++) > Jan> +=A0=A0=A0 { > Jan> +=A0=A0=A0=A0=A0 dwarf2_per_cu *data =3D per_bfd->all_units[i].get (= ); > Jan> +=A0=A0=A0=A0=A0 compunit_symtab *result =3D find_pc_sect_compunit_s= ymtab_includes ( > Jan> +=09dw2_instantiate_symtab (data, per_objfile, false), pc); >=20 > There shouldn't be any need to instantiate a symtab here, since for > readnow they are all already expanded. Not always. dwarf2_base_index_functions::expand_all_symtabs skips=20 "partial symtabs", so in some cases not all symtabs are instantiated. An example of this is dwz-symtabs.exp. If I change the code as --- a/gdb/dwarf2/read.c +++ b/gdb/dwarf2/read.c @@ -2181,8 +2181,10 @@ readnow_functions::find_pc_sect_compunit_symtab for (int i =3D 0; i < per_bfd->all_units.size (); i++) { dwarf2_per_cu *data =3D per_bfd->all_units[i].get (); - compunit_symtab *result =3D find_pc_sect_compunit_symtab_includes ( - dw2_instantiate_symtab (data, per_objfile, false), pc); + + gdb_assert (per_objfile->symtab_set_p (data)); + compunit_symtab *result =3D find_pc_sect_compunit_symtab_includes + (per_objfile->get_symtab (data), pc); if (result !=3D nullptr) return result; } I get an assertion failure.=20 dw2_instantiate_symtab checks if the symtab has been instantiated and if=20 yes, it's an no-op so calling it should not hurt much. Jan >=20 > Tom