Re: [PATCH 0/4] Move dyn prop functions to be methods of struct type

[Simon Marchi <simark@simark.ca>]

On 2020-05-07 9:59 a.m., Tom Tromey wrote:
>>>>>> "Simon" == Simon Marchi via Gdb-patches <gdb-patches@sourceware.org> writes:
> 
> Simon> I'd like to start cleaning up gdbtypes.h.  In particular, move some functions
> Simon> and some of the TYPE_* macros to be methods of `struct type`.  To test the
> Simon> waters, I started with the dynamic property stuff, which is quite isolated.
> 
> Looks good to me.  I support this project in general; I don't think
> macros of this form really add value.  There's been a time or two in the
> past where we were able to use the macros to change the representation a
> little -- but that's even easier with methods.

Yeah, it might have made sense before C++.

There is one small thing I would change in this patch series.  I have progressed a bit
on that front (changed more macros to methods) and realized I probably don't want to
use the prefix `get_` in the getters.  It makes it long and verbose for nothing.

  type->get_field (0)->get_type ()->get_name ()

vs

  type->field (0)->type ()->name ()

Plus, existing getters on the objfile struct, for example, don't use get, so it would
be more consistent.  So before pushing, I would change patch 1 to rename get_dyn_prop
to just dyn_prop.

Simon