[ was: Re: [PATCH][gdb/testsuite] Fix PATH error in gdb_file_cmd ]

On 04-06-2020 15:22, Pedro Alves wrote:
> On 6/4/20 2:05 PM, Tom de Vries wrote:
> 
>> OK, I see your point, I'll prepare a patch for this, so let's settle on
>> the error message.  How about:
>> ...
>> -           fail "($arg) (GDB internal error)"
>> +           perror "Couldn't load $arg into $GDB (GDB internal error)."
>> ...
>> ?
> 
> LGTM, since it's what the other -re's use.
> 

OK, committed as attached.

> (That leaves the open question of whether we want to include the
> full paths in the ERROR, but that can be seen as an orthogonal issue
> if you'd like.)

Yes, I'd prefer that.

Thanks,
- Tom