From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 65982 invoked by alias); 30 Nov 2018 17:07:00 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 65950 invoked by uid 89); 30 Nov 2018 17:06:59 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-0.9 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY,SPF_HELO_PASS autolearn=no version=3.3.2 spammy=burgess, Burgess X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 30 Nov 2018 17:06:57 +0000 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 8F7B9155DD; Fri, 30 Nov 2018 17:06:56 +0000 (UTC) Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id 4BC5F1019637; Fri, 30 Nov 2018 17:06:55 +0000 (UTC) Subject: Re: [PATCH 3/4] gdb/riscv: Create each unique target description only once To: Andrew Burgess References: <84ce42bd83dc3d67bd312c4c8772171dd5bf1182.1543509416.git.andrew.burgess@embecosm.com> <6277aa2c-c64e-e7d2-07d9-444ce80ef170@redhat.com> <20181129223227.GI18841@embecosm.com> Cc: gdb-patches@sourceware.org, jimw@sifive.com, palmer@sifive.com, jhb@FreeBSD.org From: Pedro Alves Message-ID: <6babd3ce-36a9-5d55-a471-592a55878dce@redhat.com> Date: Fri, 30 Nov 2018 17:07:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20181129223227.GI18841@embecosm.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2018-11/txt/msg00573.txt.bz2 On 11/29/2018 10:32 PM, Andrew Burgess wrote: > +/* Wrapper used by std::unordered_map to generate hash for feature set. */ > +struct riscv_gdbarch_features_hasher > +{ > + std::size_t > + operator() (struct riscv_gdbarch_features const& features) const noexcept I don't think we do "east const" in gdb. Also, '&' is formatted like '*'. Might as well drop the "struct" while at it (I'd do that in a number of places). That leaves: operator() (const riscv_gdbarch_features &features) const noexcept Otherwise looks fine. Thanks! Pedro Alves