From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30443 invoked by alias); 21 Jun 2017 21:08:14 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 30361 invoked by uid 89); 21 Jun 2017 21:08:14 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-24.1 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,SPF_HELO_PASS,SPF_SOFTFAIL autolearn=ham version=3.3.2 spammy= X-HELO: simark.ca Received: from simark.ca (HELO simark.ca) (158.69.221.121) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 21 Jun 2017 21:08:12 +0000 Received: by simark.ca (Postfix, from userid 33) id 6732C1E4E8; Wed, 21 Jun 2017 17:08:11 -0400 (EDT) To: Sergio Durigan Junior Subject: Re: [PATCH 3/4] dtrace-probe: Put semicolon after while on its own line X-PHP-Originating-Script: 33:rcube.php MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Wed, 21 Jun 2017 21:08:00 -0000 From: Simon Marchi Cc: Simon Marchi , gdb-patches@sourceware.org In-Reply-To: <87d19xcc5t.fsf@sergiodj.net> References: <1498076108-29914-1-git-send-email-simon.marchi@ericsson.com> <1498076108-29914-4-git-send-email-simon.marchi@ericsson.com> <87d19xcc5t.fsf@sergiodj.net> Message-ID: <6b97c3b96161cab3a6e672e6ee8968ed@polymtl.ca> X-Sender: simon.marchi@polymtl.ca User-Agent: Roundcube Webmail/1.2.5 X-IsSubscribed: yes X-SW-Source: 2017-06/txt/msg00613.txt.bz2 On 2017-06-21 22:34, Sergio Durigan Junior wrote: > On Wednesday, June 21 2017, Simon Marchi wrote: > >> clang shows this warning. >> >> /home/emaisin/src/binutils-gdb/gdb/dtrace-probe.c:424:52: error: >> while loop has empty body [-Werror,-Wempty-body] >> while (*p++ != '\0' && p - strtab < strtab_size); >> ^ >> /home/emaisin/src/binutils-gdb/gdb/dtrace-probe.c:424:52: note: put >> the semicolon on a separate line to silence this warning >> >> Putting the semicolon on its own line is not a big sacrifice to get >> rid of this >> warning. I think it's also useful to keep this, because it can catch >> errors >> like this: >> >> while (something); >> { >> ... >> } >> >> although gcc would warn about it in a different way (misleading >> indentation). >> >> This warning is already discussed here in the GCC bugzilla: >> >> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=62184 >> >> gdb/ChangeLog: >> >> * dtrace-probe.c (dtrace_process_dof_probe): Put semi-colon on >> its own line. >> --- >> gdb/dtrace-probe.c | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) >> >> diff --git a/gdb/dtrace-probe.c b/gdb/dtrace-probe.c >> index 122f8de..9a02694 100644 >> --- a/gdb/dtrace-probe.c >> +++ b/gdb/dtrace-probe.c >> @@ -421,7 +421,8 @@ dtrace_process_dof_probe (struct objfile *objfile, >> arg.type_str = xstrdup (p); >> >> /* Use strtab_size as a sentinel. */ >> - while (*p++ != '\0' && p - strtab < strtab_size); >> + while (*p++ != '\0' && p - strtab < strtab_size) >> + ; /* Silence clang's -Wempty-body warning. */ > > Lately I've been choosing to explicitly put "continue;" when the body > doesn't contain anything, like: > > while (*p++ != '\0' && p - strtab < strtab_size) > continue; > > I don't know what others think about it, but it would solve this > problem > and also be more verbose that we're just iterating without a body. I also looks good, but I don't have a preference. I'll do that if others like it too. Thanks, Simon