From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4690 invoked by alias); 14 Aug 2017 14:30:24 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 3815 invoked by uid 89); 14 Aug 2017 14:29:58 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=HTo:U*pmuldoon X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 14 Aug 2017 14:29:57 +0000 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id A1A65C0587DB; Mon, 14 Aug 2017 14:29:55 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com A1A65C0587DB Authentication-Results: ext-mx08.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx08.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=palves@redhat.com Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id 95ED07E8ED; Mon, 14 Aug 2017 14:29:54 +0000 (UTC) Subject: Re: [RFA v2 00/13] various frame filter fixes and cleanups To: Phil Muldoon , Tom Tromey , gdb-patches@sourceware.org References: <20170814034030.20863-1-tom@tromey.com> From: Pedro Alves Message-ID: <6b6b1453-6ce0-08dc-0fd0-8d1327ccac04@redhat.com> Date: Mon, 14 Aug 2017 14:30:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2017-08/txt/msg00297.txt.bz2 On 08/14/2017 02:57 PM, Phil Muldoon wrote: > I'd prefer a "hidden" attribute to the frame decorators (or a callback > API like the rest of the functions). Returns True or False. GDB would > honour this and print/not print the frame according to the value > returned. This is better, to me, than a global override printing/not > printing all elided frames. > The bt command should still have a global > override (IE, elide, or hidden, or show-hidden, or whatever) as > discussed in the patch, and that would allow the user final and manual > control of what is printed or not. I prefer frame decorators to be > able to decide what should, or should not, be printed as the default > as it's the presentation layer. > > What do you think? Hmm, I think I'm missing the point of the difference? Can you expand on when would a filter want to hide elided frames, and when would it want to show them? When would it want to non-elided, but hidden frame? What's semantically different between an elided frame and a hidden frame? Because "hidden" and "elided" sound like synonyms to me: - "To leave out or omit (something).". Thanks, Pedro Alves