From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id YNE5NUUHZ2bYmC4AWB0awg (envelope-from ) for ; Mon, 10 Jun 2024 10:01:41 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=arm.com header.i=@arm.com header.a=rsa-sha256 header.s=selector1 header.b=qxE4ADBS; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.a=rsa-sha256 header.s=selector1 header.b=qxE4ADBS; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id C5B381E0C1; Mon, 10 Jun 2024 10:01:41 -0400 (EDT) Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 7238A1E030 for ; Mon, 10 Jun 2024 10:01:39 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 7E351385842A for ; Mon, 10 Jun 2024 14:01:38 +0000 (GMT) Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2064.outbound.protection.outlook.com [40.107.21.64]) by sourceware.org (Postfix) with ESMTPS id 9DF233858D39 for ; Mon, 10 Jun 2024 14:01:15 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 9DF233858D39 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=arm.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 9DF233858D39 Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=40.107.21.64 ARC-Seal: i=3; a=rsa-sha256; d=sourceware.org; s=key; t=1718028077; cv=pass; b=cJpBApbtgd4ym5EH/y+2ZjmFiae9K8evLMFBLmhhhicl9cyeb+fYDN/cx31ulabwYdicHgC933QC8cBFyNIcArZNt8MF13cKqtPa0NyhWVmFA2vEUHWNseqQnVE4BQfad3EWtJfX1uye96IbwF39kiGZulXePJBDUkfE8UmwjMA= ARC-Message-Signature: i=3; a=rsa-sha256; d=sourceware.org; s=key; t=1718028077; c=relaxed/simple; bh=rOpBqqr/OWzFpDHszGXEiMl1qEb5J7vbbVRbKKnMul8=; h=DKIM-Signature:DKIM-Signature:Message-ID:Date:Subject:To:From: MIME-Version; b=q2KInED4E7LGSM93TYwGd6X5QK6u0sXEpRNrOM1M6gpbvGflZ9LUnOUyTf+Py9GC0+zWKkOqYMKbeaMhcIey3p/dJ9rcZ52M4+gpZUp2pPi3Ptv2d1wvmLggZF9O5dAhZJ7U/uYjK7SizQ71FlOEAGBLwiPRHLBfGIhIxKXudAQ= ARC-Authentication-Results: i=3; server2.sourceware.org ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=OC7qjjYU8crRf8rb+eG/3cirtuY39/MS/A3wcVsyzyyB0B70GfVPQ2DffysMehhbpoiPzonCmhIfAWpfMXSeOnSwnFDBrnUL74CXuIQOToj8Z4MxvwPtLoKgpta574No93FBGpjLC3NHWm/VTeCnIRLmcQxO2lPsqrThl5wObRBk2YUB2cr8egTRWNS2swlMJs2KZsSbRgpG/wc9OoQkLI3bhy7hu1NyCMbNNi1TqFoCA7yaAhpqDOvnHzv9vKNARdqnL9fAL6M3bG9IYMpyvQNAdNVDe1YuF2tE4YEdo8RZAoWJrOsgFsx+yZZIogG/0uFYG+ZbF4mKvyn8PSXbXQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=h+jY8pZ4hVMfDwBFMj8dpyx00G+x/5WCHeHE8tBrQdE=; b=Ajlb6oX9/ZS76XVZDNaD/9vsTNUWfvKetAu3t1tOWfTldOJsKgAKJrG3LtpA3hKn8dOiNVoHINDsQ08UT4Yi1lb7186LxDKPq5lT2iom+XxB1emic7PaQSY3NFRtdtEiAxvDnmndiWRNHHE/3Ln/TpDuM78Reds++I1XcV+YrZwAe4lLjxZyvUQMVqqeT2QBPH+T4xvzZK5P4HZKNsC8q22z34giesMzYRAOnggecXJufZJ86ysIpfZCzknlgpe6zxkXLsjr7AL26LWQFha+snR6fimB8eqf+bnQZNM8HGOZxmZgpxRJzW27D5TkgGXhTeWl2JhoH2X54FRZLsAppQ== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=sourceware.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=arm.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arm.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=h+jY8pZ4hVMfDwBFMj8dpyx00G+x/5WCHeHE8tBrQdE=; b=qxE4ADBSWB9lo9C8xVqXL3yKeVy1gFRYj8TM01i77B3MCANl735YgL9EOhoPPzo/YBok0nVV+x4SELVdTg0JJp+u2RWnCMaK6fUySmp8gvGD975LXLBCaC2zzL/4ZbJtOemuHiMCi1Ml+LnN1fEKOTxWVw+ZUaN0GBt3rGoN8IY= Received: from AS4P190CA0066.EURP190.PROD.OUTLOOK.COM (2603:10a6:20b:656::9) by AS2PR08MB8782.eurprd08.prod.outlook.com (2603:10a6:20b:5e4::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7633.36; Mon, 10 Jun 2024 14:01:12 +0000 Received: from AM4PEPF00027A60.eurprd04.prod.outlook.com (2603:10a6:20b:656:cafe::2b) by AS4P190CA0066.outlook.office365.com (2603:10a6:20b:656::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7656.25 via Frontend Transport; Mon, 10 Jun 2024 14:01:12 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=arm.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM4PEPF00027A60.mail.protection.outlook.com (10.167.16.68) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.7677.15 via Frontend Transport; Mon, 10 Jun 2024 14:01:12 +0000 Received: ("Tessian outbound 5a0abdb578b5:v332"); Mon, 10 Jun 2024 14:01:12 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: ea87623b0eeeb109 X-CR-MTA-TID: 64aa7808 Received: from 96446a9b53a1.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id FB3E02BC-9D91-4AE4-BC00-8A2653C7E7D7.1; Mon, 10 Jun 2024 14:01:05 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 96446a9b53a1.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 10 Jun 2024 14:01:05 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=d03QSHJe6F14UmPM8DodQFiMFZW7f+HHVabFAYJHeSNajNfRJknU09scU+G7Pj5eAYR+fNWhS2TJdmwOLpxuCHQNtKcpQFH8T/bgoUyXaDtFlN0UhpO+EZFwoquXuJfVcq0Ib0rO7cq/D3/lMgZRAMXHdOjWv7Dvzb10slLbfc2AuTaq5GbAmuwguOqaqwWuQ9QaecSFUDYRmVIlUUVHz61x7CcK3kx4x8IeUFT6NuHkeSM2CAotzKBVt+Qr+pIDCQCjSPIY1zBB56WZ42BxirEgcCMMp6JBGl2ji76kXh11BWEwRrEiA6VEqiGiPjQpqjRzPrxyDStSSw1s17WarA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=h+jY8pZ4hVMfDwBFMj8dpyx00G+x/5WCHeHE8tBrQdE=; b=ZKdS13ZvH6yZDTEFO20AXLuLM257Zgy/VxnBAK6MQrjTFMeGvGGGx/BmpCjctsUxNmUYYkjHIjCsHrieLUVS/d8z1gqM6hDO/YcpR88/0LmoivAlkZDoqjL0A7cYZV77xY1JKlKP0bz2hNCzF84isZBIVAUztOPDA0zLW/v0TUSvRToPZ0VzQWRMNLgxBRXeSbvtJp7DSKffRHEKY2tBvNRrIYPdCsKPK3+GPevXsAujGDsBoYnEAaX3TwVNmCV3FrOsNrXYlUsa/tC1O5mD7Me4RFbkDacEMsNQHBd0w4xxthJSr3gGulc/RF38md4oZVidxWE2kqP6Hkb5xit5hg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arm.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=h+jY8pZ4hVMfDwBFMj8dpyx00G+x/5WCHeHE8tBrQdE=; b=qxE4ADBSWB9lo9C8xVqXL3yKeVy1gFRYj8TM01i77B3MCANl735YgL9EOhoPPzo/YBok0nVV+x4SELVdTg0JJp+u2RWnCMaK6fUySmp8gvGD975LXLBCaC2zzL/4ZbJtOemuHiMCi1Ml+LnN1fEKOTxWVw+ZUaN0GBt3rGoN8IY= Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from VI1PR08MB3919.eurprd08.prod.outlook.com (2603:10a6:803:c4::31) by AS2PR08MB9022.eurprd08.prod.outlook.com (2603:10a6:20b:5fc::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7633.30; Mon, 10 Jun 2024 14:01:03 +0000 Received: from VI1PR08MB3919.eurprd08.prod.outlook.com ([fe80::14e2:874a:b20b:78e5]) by VI1PR08MB3919.eurprd08.prod.outlook.com ([fe80::14e2:874a:b20b:78e5%5]) with mapi id 15.20.7633.036; Mon, 10 Jun 2024 14:01:02 +0000 Message-ID: <6b4c166c-245a-4bbf-897c-9f393605f2d7@arm.com> Date: Mon, 10 Jun 2024 15:00:59 +0100 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/3] gdb: Make tagged pointer support configurable. To: "Schimpe, Christina" , "Willgerodt, Felix" , "gdb-patches@sourceware.org" Cc: "eliz@gnu.org" References: <20240527102423.1361410-1-christina.schimpe@intel.com> <20240527102423.1361410-2-christina.schimpe@intel.com> <360846d7-0eb9-47ae-8d5c-d26120acaaab@arm.com> Content-Language: en-US From: Luis Machado In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO2P265CA0207.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:9e::27) To VI1PR08MB3919.eurprd08.prod.outlook.com (2603:10a6:803:c4::31) MIME-Version: 1.0 X-MS-TrafficTypeDiagnostic: VI1PR08MB3919:EE_|AS2PR08MB9022:EE_|AM4PEPF00027A60:EE_|AS2PR08MB8782:EE_ X-MS-Office365-Filtering-Correlation-Id: 6af9317e-e3d5-415f-e7f4-08dc8955c97e x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0;ARA:13230031|376005|1800799015|366007; X-Microsoft-Antispam-Message-Info-Original: =?utf-8?B?d0ZtUDViTVFvbGtTZkRZNkhlaHorWEdENFgyNnRrb0tVY3BtUnRoRnhRU3lE?= =?utf-8?B?NVUrVjhZc0FoTy9mTkdDeGNuMUFUSVA3UGpyamg2c2lxUVV2ZW9sMmJXVUtM?= =?utf-8?B?YU83aG5mb2xoMWE4WnJaYy9meFNBNjRRbkFCZjd3REhCT0lwaFZ5ckMxUmZ4?= =?utf-8?B?bXFreVZ4bmU3SG02OXU1MU1PV0x5TVhlbFN5M1hFem8xUE4ra25XanJWNzFX?= =?utf-8?B?YkluMWxUS041RFdFa0x3NEt5T0NiVk9wVm02Wm80aXRVR2tab1FCc0w2NFJT?= =?utf-8?B?N2dETzJWSVNOTGxqUUFVSDhKQ01OakZoa0RYSjlySzlUVDlWaWN6djBIcWdR?= =?utf-8?B?NU0yLzljT2Fpb0pyRjI4UUI5WlZpMVFxQkZrUEQzSFNuQk5oVG5kcEE5ajRJ?= =?utf-8?B?SCs2MHRNY3VOQ1g4VEZoYTVxc09Yak95QmhYNnJaVHBqTVJYN3VBL3FCdGZP?= =?utf-8?B?MWxWSGhXa3Izd1ZUZmEvTHdnSUxMaHV1YXdqeDVSN0hDMG5wYUJrNmg3ZjFJ?= =?utf-8?B?dXpLWEd1OXpPTEhlQTNFRWduQ2wyV1AzWndsUHRaWEIrMVQydUVsM2xuMFd4?= =?utf-8?B?NldERG5zcVZkZm5zbkkvb0pmRUY3anR6WU9WWHdOOGRIRlFFQkMzTUpHUVF3?= =?utf-8?B?TllUUDQrNXkxQnRNU2U3U00zRlFpbTkyWTMrUHM4cTY5eEQzZEdqcWRmWXpC?= =?utf-8?B?RGVpOHVkcjdZSHVEVUpLN3hvSWZJeVVKT0dCRXkwbWwwVGJxSk4rVjVRc2hU?= =?utf-8?B?emdTdnJEMURLVlROYTMwVmpPaFNIbUxUL1RvcnRuSkluRU84MUVkbS8ybHln?= =?utf-8?B?SzVYdVBCUlBJQy9rUGVUZ2lEK3ZuNm9GcEszb1ZJcUY2OXhoU2NpTFlYeHhU?= =?utf-8?B?R0F6THNoRmJsYXRQQ2hwMXJKNlZvTTlHell3N1d6cmM2WmI0V0lQbXpBYzEz?= =?utf-8?B?NkN2ZkdpbllXcHBBbXE3SkhNWDh0QURCVlI5ak80R1hzL2MwQmliZ0dtQTdL?= =?utf-8?B?WGM1UE1vL1ZXakg3Z3FXRzQrdTVnZnpaQ1hYUVJGZVBIeWNacWhXamZBMnBz?= =?utf-8?B?TVAzUmFDZ1pmS2QwM1NjdmFLUFU3eGFYN1ZDMGFZWU5pMVpuMHBrdW1STTJ5?= =?utf-8?B?dEEzL3ZKQUl0SFZPaVNqcWZpbmdjQng2Zmt6ZzVjMW5Ya0ZTZ2d1SWVZTTdY?= =?utf-8?B?c1kzd0FFdDFPQ1FnbFFmeThmZFBlK2FYc20yODEydXBUdWJ2cGM2aGRSL1cr?= =?utf-8?B?N1l3aTJUS1E5c0N4cm1uVm1WamxOUGVHc2xMdU5KcHBLdHhvM0tZU3Nld0RU?= =?utf-8?B?dkNiVVJXN0lqVXJpMC9FU1BGMkZTRFBEYTNKV2VGNkE4Q2RKN0JjRGdySWhE?= =?utf-8?B?YU1VYkhIVTVtL3hDL2hCQ29KampxUW83dFBSNngrb3NsblR0R3pMZU83SVVX?= =?utf-8?B?N3NDMjVqUy9HSktaRDdRcGczTmRoQ1RURE1pRmRQc2tmakJvWEdETFpjcURw?= =?utf-8?B?c0JkSGFneTZURkdKbUNNTzBMWlNxdEx3ZGxtWlBDVjMvY0JhOVF0Rmw5dm50?= =?utf-8?B?T1BOdlArdGQyWkJ6RkhEOTdydDdRTTRhZldQYm4waXpOU1hRVzByVE1iajdS?= =?utf-8?B?T1BEakpHRHZ2VVNBM1hWbjFtV3pYd2EzWThpanlpVGgyVmRDa0hzdjhRWi9S?= =?utf-8?Q?os+LXXj1H2F/YvVEaV/A?= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI1PR08MB3919.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(376005)(1800799015)(366007); DIR:OUT; SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS2PR08MB9022 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM4PEPF00027A60.eurprd04.prod.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: fc82fe46-7b62-4b4a-5422-08dc8955c32c X-Microsoft-Antispam: BCL:0; ARA:13230031|1800799015|376005|36860700004|82310400017|35042699013; X-Microsoft-Antispam-Message-Info: =?utf-8?B?cE9iQWNFdGJTdGRaSE9CSG1wb0YvWHJ5cnZieHJRQVAvWFM4NDd6Z2NCRHFO?= =?utf-8?B?NnQ0U25HYTE3UFNPY3lnUWh0RFVkbVZKQ1VYOUVqTDY3aXRVeXB1QU44NHgy?= =?utf-8?B?L2x2b2x1MUx6Ly90aHRkYTJSRlJhMGV5MmxBcDZUd2Qzcy9YVWNRY3VFb1R1?= =?utf-8?B?OFViS2w2emdsdUF1MDhWNGtyVnl2OVJWWnpNKzgxbDRqNU42SmZXVDhpakhV?= =?utf-8?B?dzFES2NiTFJEYnRweHU1U2drNm1GdlkvL1A2bUZsYTdkM0NtNi9xb2lHVUJr?= =?utf-8?B?TzRpQ2FBN0lxL3pkSkgwVW83blVodDE1QXZudmV1TUxyMmZrYTZtd3RYWGlv?= =?utf-8?B?TGl2eWllRDVUeWMzNlNMRUlIL09QeVRBamN5RlgvcE9WNTRZVlVVY1pwVnBN?= =?utf-8?B?ZVlHb2I1ZFNudUhIcnNzL1JzOXZoWlcyN1FTUUFkTnhaZUdNTXR5K3FqQWVm?= =?utf-8?B?NzZyLy8zZml4SFEyVE5nQjZhQnpNb3F2b0hiaGtMVVhXMkt2NHdXdm1uVXlo?= =?utf-8?B?Z1hOdUhxWnZoMUhtb0tXTzZ0NUZOb28wSkZvdHRPMmU0V1VDeXFVQmpyejBs?= =?utf-8?B?Ty8yMlYvYmRCL1ZoUC8zcEdNWGZyQlhUME5KS3A4Vm1Bdlo1RWJYYjVkaER3?= =?utf-8?B?VjRzZUdSYmpLTG5nOVdTb0VJOERoR0JpbTQycmkzdTd2N056Mkp6OTY3cWdL?= =?utf-8?B?YytiMkNkVmR6UXBvYTI1Q3k3UzZXWWpsdFZ1SDJlNHcxQ1RpWmt1ZElIYldO?= =?utf-8?B?cDV6Tlo2UmVxYkI1cTlPeHh4SlNOY1d5UTdxZW1CUjFwbENHb2tKYUJVQllF?= =?utf-8?B?YkZoRzg2bmpCZk9Eako4WlJ4Vnl6SC9mdVRIekRwVWNOeDd2WStIcnhkL3VC?= =?utf-8?B?U01PWUxRM1dlUTJrUEI0MzBRT2ExK2xvZElIUDVHQzhKSG5rc1p0T3RTeHdi?= =?utf-8?B?enlBQzhveHEzOW9QR3dRY0kzelBHWHJuMUtKam1vV051cDJyZnpiT0w3TStF?= =?utf-8?B?TVFJTWZOT0FydG9WU284VlBiOHhZaTQwYzhNWTk3cUcyUUJTSXRMT0JjdExa?= =?utf-8?B?ZEpLa3BUOTZjRnd0RGRHcjYzb0ZieXpVVlRLNmkvbFVHVUlnM1hHcUUxQVda?= =?utf-8?B?YWo2UEFBdXBwWUNQRFJzUFdDdkpTQk1mNjMxUHdzQ2p3ZXovYkJDbGV3NE9l?= =?utf-8?B?MXd4SGZXdnJNM3pXNnBkSThJbDBKZlBRN2tNR0hZU1dEcFZET0VHelB1R0FZ?= =?utf-8?B?ODRMUVFrcFhJMU9XUUVPN2ZKd1grVW9tU0tsd1kzOTRuclQrOVhWRkFjYVVD?= =?utf-8?B?aHNXTGdwUDQzS2pyRjJ5OVkwS1YrUUpMdnBReXlXRGxxOVhCQWJDZ0FJUHZY?= =?utf-8?B?K0pIbDFKRVQ0L1hITjdCR1V0M0FtQXlHK0pFOGFmaWtwYVROTXhhaEdEdWVp?= =?utf-8?B?b1I1ZkczdmE0R2U3Y1RVc2Y3cVA3bkgxZE5qS2V2NEtZRTdYVnFKeSs1OTNC?= =?utf-8?B?YlBFQ2c5K1BZbUo0dDVTdnVtUko5Yng5aFAzQzlKYTlMb05peHVXdVNqRzZU?= =?utf-8?B?SHFZTDlJa0trZWFnVmFzSTlabEpCcTJGVGl0WGNQOS9KU1ROLzA0ZUZkcHBC?= =?utf-8?B?S2pscDFGV0ZEVFJPeHlYd3oxUXdJaFhrNU1zMU1VTjA4enJwU3gvZGJqYjJK?= =?utf-8?B?bHhCa2M2Ni9jVnd1MEpyYWJmdmFnYjlMckpZOEFITnVYc3lhNnFVVXRNc2JV?= =?utf-8?B?dE4wWkRCREE2WS9BdjA2UzdBaktNL1lidmtGVHNLaG80cC9NakFnV3hhU0hI?= =?utf-8?Q?K5lZ0+tdw/A8BmA9PYGq6O/Ye4E8Il5vNczWU=3D?= X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFS:(13230031)(1800799015)(376005)(36860700004)(82310400017)(35042699013); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Jun 2024 14:01:12.4280 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 6af9317e-e3d5-415f-e7f4-08dc8955c97e X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM4PEPF00027A60.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS2PR08MB8782 X-Spam-Status: No, score=-4.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FORGED_SPF_HELO, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE, UNPARSEABLE_RELAY autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org On 6/3/24 15:13, Schimpe, Christina wrote: > Hi Luis, > >>>>> -/* AArch64 implementation of the remove_non_address_bits gdbarch >>>> hook. >>>>> Remove >>>>> - non address bits from a pointer value. */ >>>>> - >>>>> -static CORE_ADDR >>>>> +CORE_ADDR >>>>> aarch64_remove_non_address_bits (struct gdbarch *gdbarch, >> CORE_ADDR >>>>> pointer) >>>> >>>> Shouldn't there still be some sort of comment for this function in the c >> file? >>>> At least some "see header file"? Though it seems like no function in >>>> aarch64- tdep.h has any comment, and all comments are in >>>> aarch64-tdep.c. I would also be fine with that for consistency. Maybe >>>> Luis can comment how he prefers it. >>>> >>>> But I am fine with this patch. Let's see if someone else objects this split. >>>> >>>> Reviewed-By: Felix Willgerodt >>>> >>>> Thanks, >>>> Felix >>> >>> Ok, let's wait for further comments here. >> >> Sorry, only spotted this now. >> >> The comment on the above function would be a repetition of the hook >> explanation, and the gdbarch hook explanation covers all the details we >> need. But if the comment is being removed due to it being in the header, we >> should point to the header instead. >> >> "See aarch64-tdep.h" should do. > > Ok, I will add that line. > >> There is something odd about this patch though. The aarch64 code is being >> changed to call aarch64_remove_non_address_bits directly, but 3 new hooks >> are being set: >> >> + set_gdbarch_remove_non_address_bits_watchpoint >> + (gdbarch, aarch64_remove_non_address_bits); >> + set_gdbarch_remove_non_address_bits_breakpoint >> + (gdbarch, aarch64_remove_non_address_bits); >> + set_gdbarch_remove_non_address_bits_memory >> + (gdbarch, aarch64_remove_non_address_bits); >> >> But the above hooks (the gdbarch_remove_non_address_bits_memory at >> least) never get used in aarch64 code. Is there a reason for that? > > I thought it's wrong to call the gdbarch_remove_non_address_bits_memory hook in aarch64 code. > The reason is described here: https://sourceware.org/pipermail/gdb-patches/2024-May/209420.html > > "Also I noticed that the gdbarch function 'gdbarch_remove_non_addr_bits_memory' > should not be used in several functions of aarch64* files (patch 1) due > to the following: > > The function description for 'gdbarch_remove_non_addr_bits_memory' states: > > "Given a pointer for the architecture, this hook removes all the > non-significant bits and sign-extends things as needed. It gets used to > remove non-address bits from any pointer used to access memory. " > > We don't know if the pointer passed to 'gdbarch_remove_non_addr_bits_memory' > by 'gdbarch_tagged_address_p' will be used to access memory. That's why it's > wrong to call this function in 'gdbarch_tagged_address_p'. > > There are several similar wrong calls of 'gdbarch_remove_non_addr_bits_memory' > in the changes of patch 1. I replaced all of them with > 'aarch64_remove_non_address_bits'." > That's fine, but previously the hook was correct for what is was being used for in aarch64. This particular change means we no longer have a hook that aarch64 can use for the same purposes it used before. This part feels a bit odd. It feels like the memory-specific one would be appropriate, but it isn't clear. Also, from the 1/3 patch submission: "- In contrast to the implementation for ARM's TBI, the Linux kernel supports tagged pointers for memory access." Is there a negative impact if we feed the kernel an untagged pointer for a particular memory access? If not, it sounds like it might be simpler (from gdb's perspective) to let gdb always unmask things, no? Of course, there might be a performance impact of checking if a region is tagged. I'm just trying to understand if the additional hooks are really needed/useful. Right now it looks as if we could make it work with the existing hook in place, instead of splitting it into 3 different hooks. > Regards, > Christina > > Intel Deutschland GmbH > Registered Address: Am Campeon 10, 85579 Neubiberg, Germany > Tel: +49 89 99 8853-0, www.intel.de > Managing Directors: Sean Fennelly, Jeffrey Schneiderman, Tiffany Doon Silva > Chairperson of the Supervisory Board: Nicole Lau > Registered Office: Munich > Commercial Register: Amtsgericht Muenchen HRB 186928