From: Andrew Burgess via Gdb-patches <gdb-patches@sourceware.org>
To: gdb-patches@sourceware.org
Cc: Andrew Burgess <aburgess@redhat.com>
Subject: [PATCH 02/16] gdb: add some const in gdb/reggroups.c
Date: Thu, 31 Mar 2022 22:04:08 +0100 [thread overview]
Message-ID: <6b37da75e035a5ebc12ff8e15b62a80889e3e88a.1648760270.git.aburgess@redhat.com> (raw)
In-Reply-To: <cover.1648760270.git.aburgess@redhat.com>
This commit makes the 'struct reggroup *' argument const for the
following functions:
reggroup_next
reggroup_prev
reggroup_name
reggroup_type
There are other places that could benefit from const in the
reggroup.{c,h} files, but these will be changing in further commits.
There should be no user visible changes after this commit.
---
gdb/reggroups.c | 8 ++++----
gdb/reggroups.h | 8 ++++----
2 files changed, 8 insertions(+), 8 deletions(-)
diff --git a/gdb/reggroups.c b/gdb/reggroups.c
index b6afa2f895c..169285b7475 100644
--- a/gdb/reggroups.c
+++ b/gdb/reggroups.c
@@ -63,13 +63,13 @@ reggroup_gdbarch_new (struct gdbarch *gdbarch, const char *name,
/* Register group attributes. */
const char *
-reggroup_name (struct reggroup *group)
+reggroup_name (const struct reggroup *group)
{
return group->name;
}
enum reggroup_type
-reggroup_type (struct reggroup *group)
+reggroup_type (const struct reggroup *group)
{
return group->type;
}
@@ -130,7 +130,7 @@ static struct reggroups default_groups = { NULL, &default_groups.first };
/* A register group iterator. */
struct reggroup *
-reggroup_next (struct gdbarch *gdbarch, struct reggroup *last)
+reggroup_next (struct gdbarch *gdbarch, const struct reggroup *last)
{
struct reggroups *groups;
struct reggroup_el *el;
@@ -161,7 +161,7 @@ reggroup_next (struct gdbarch *gdbarch, struct reggroup *last)
/* See reggroups.h. */
struct reggroup *
-reggroup_prev (struct gdbarch *gdbarch, struct reggroup *curr)
+reggroup_prev (struct gdbarch *gdbarch, const struct reggroup *curr)
{
struct reggroups *groups;
struct reggroup_el *el;
diff --git a/gdb/reggroups.h b/gdb/reggroups.h
index f2e60c4f1da..ef99483f39f 100644
--- a/gdb/reggroups.h
+++ b/gdb/reggroups.h
@@ -50,17 +50,17 @@ extern struct reggroup *reggroup_gdbarch_new (struct gdbarch *gdbarch,
extern void reggroup_add (struct gdbarch *gdbarch, struct reggroup *group);
/* Register group attributes. */
-extern const char *reggroup_name (struct reggroup *reggroup);
-extern enum reggroup_type reggroup_type (struct reggroup *reggroup);
+extern const char *reggroup_name (const struct reggroup *reggroup);
+extern enum reggroup_type reggroup_type (const struct reggroup *reggroup);
/* Iterators for the architecture's register groups. Pass in NULL, returns
the first (for next), or last (for prev) group. Pass in a group,
returns the next or previous group, or NULL when either the end or the
beginning of the group list is reached. */
extern struct reggroup *reggroup_next (struct gdbarch *gdbarch,
- struct reggroup *last);
+ const struct reggroup *last);
extern struct reggroup *reggroup_prev (struct gdbarch *gdbarch,
- struct reggroup *curr);
+ const struct reggroup *curr);
/* Find a reggroup by name. */
extern reggroup *reggroup_find (struct gdbarch *gdbarch, const char *name);
--
2.25.4
next prev parent reply other threads:[~2022-03-31 21:05 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-31 21:04 [PATCH 00/16] Default register groups, and general related cleanup Andrew Burgess via Gdb-patches
2022-03-31 21:04 ` [PATCH 01/16] gdb: don't try to use readline before it's initialized Andrew Burgess via Gdb-patches
2022-03-31 21:04 ` Andrew Burgess via Gdb-patches [this message]
2022-03-31 21:04 ` [PATCH 03/16] gdb: make gdbarch_register_reggroup_p take a const reggroup * Andrew Burgess via Gdb-patches
2022-04-04 22:35 ` Lancelot SIX via Gdb-patches
2022-04-05 8:24 ` Andrew Burgess via Gdb-patches
2022-03-31 21:04 ` [PATCH 04/16] gdb: switch to using 'const reggroup *' in tui-regs.{c, h} Andrew Burgess via Gdb-patches
2022-03-31 21:04 ` [PATCH 05/16] gdb: use 'const reggroup *' in python/py-registers.c file Andrew Burgess via Gdb-patches
2022-03-31 21:04 ` [PATCH 06/16] gdb: have reggroup_find return a const Andrew Burgess via Gdb-patches
2022-03-31 21:04 ` [PATCH 07/16] gdb/tui: avoid theoretical bug with 'tui reg' command Andrew Burgess via Gdb-patches
2022-03-31 21:04 ` [PATCH 08/16] gdb/tui: fix 'tui reg next/prev' command when data window is hidden Andrew Burgess via Gdb-patches
2022-03-31 21:04 ` [PATCH 09/16] gdb: always add the default register groups Andrew Burgess via Gdb-patches
2022-03-31 21:04 ` [PATCH 10/16] gdb: convert reggroups to use a std::vector Andrew Burgess via Gdb-patches
2022-03-31 21:04 ` [PATCH 11/16] gdb: remove reggroup_next and reggroup_prev Andrew Burgess via Gdb-patches
2022-04-05 23:11 ` Lancelot SIX via Gdb-patches
2022-04-06 12:06 ` Andrew Burgess via Gdb-patches
2022-03-31 21:04 ` [PATCH 12/16] gdb: more 'const' in gdb/reggroups.{c,h} Andrew Burgess via Gdb-patches
2022-03-31 21:04 ` [PATCH 13/16] gdb: make the pre-defined register groups const Andrew Burgess via Gdb-patches
2022-03-31 21:04 ` [PATCH 14/16] gdb: convert reggroup to a C++ class with constructor, etc Andrew Burgess via Gdb-patches
2022-03-31 21:04 ` [PATCH 15/16] gdb: move struct reggroup into reggroups.h header Andrew Burgess via Gdb-patches
2022-03-31 21:04 ` [PATCH 16/16] gdb: update comments throughout reggroups.{c,h} files Andrew Burgess via Gdb-patches
2022-04-06 14:28 ` Simon Marchi via Gdb-patches
2022-04-06 12:04 ` [PATCHv2 00/16] Default register groups, and general related cleanup Andrew Burgess via Gdb-patches
2022-04-06 12:04 ` [PATCHv2 01/16] gdb: don't try to use readline before it's initialized Andrew Burgess via Gdb-patches
2022-04-06 12:57 ` Simon Marchi via Gdb-patches
2022-04-06 12:04 ` [PATCHv2 02/16] gdb: add some const in gdb/reggroups.c Andrew Burgess via Gdb-patches
2022-04-06 12:58 ` Simon Marchi via Gdb-patches
2022-04-06 12:04 ` [PATCHv2 03/16] gdb: make gdbarch_register_reggroup_p take a const reggroup * Andrew Burgess via Gdb-patches
2022-04-06 12:04 ` [PATCHv2 04/16] gdb: switch to using 'const reggroup *' in tui-regs.{c, h} Andrew Burgess via Gdb-patches
2022-04-06 12:04 ` [PATCHv2 05/16] gdb: use 'const reggroup *' in python/py-registers.c file Andrew Burgess via Gdb-patches
2022-04-06 12:04 ` [PATCHv2 06/16] gdb: have reggroup_find return a const Andrew Burgess via Gdb-patches
2022-04-06 12:04 ` [PATCHv2 07/16] gdb/tui: avoid theoretical bug with 'tui reg' command Andrew Burgess via Gdb-patches
2022-04-06 13:02 ` Simon Marchi via Gdb-patches
2022-04-06 12:04 ` [PATCHv2 08/16] gdb/tui: fix 'tui reg next/prev' command when data window is hidden Andrew Burgess via Gdb-patches
2022-04-06 13:13 ` Simon Marchi via Gdb-patches
2022-04-06 12:04 ` [PATCHv2 09/16] gdb: always add the default register groups Andrew Burgess via Gdb-patches
2022-04-06 13:22 ` Simon Marchi via Gdb-patches
2022-04-06 12:04 ` [PATCHv2 10/16] gdb: convert reggroups to use a std::vector Andrew Burgess via Gdb-patches
2022-04-06 12:04 ` [PATCHv2 11/16] gdb: remove reggroup_next and reggroup_prev Andrew Burgess via Gdb-patches
2022-04-06 14:22 ` Simon Marchi via Gdb-patches
2022-04-06 14:23 ` Simon Marchi via Gdb-patches
2022-04-06 12:04 ` [PATCHv2 12/16] gdb: more 'const' in gdb/reggroups.{c,h} Andrew Burgess via Gdb-patches
2022-04-06 12:04 ` [PATCHv2 13/16] gdb: make the pre-defined register groups const Andrew Burgess via Gdb-patches
2022-04-06 12:04 ` [PATCHv2 14/16] gdb: convert reggroup to a C++ class with constructor, etc Andrew Burgess via Gdb-patches
2022-04-06 12:04 ` [PATCHv2 15/16] gdb: move struct reggroup into reggroups.h header Andrew Burgess via Gdb-patches
2022-04-06 12:04 ` [PATCHv2 16/16] gdb: update comments throughout reggroups.{c, h} files Andrew Burgess via Gdb-patches
2022-04-06 14:34 ` [PATCHv2 00/16] Default register groups, and general related cleanup Simon Marchi via Gdb-patches
2022-04-07 15:16 ` Andrew Burgess via Gdb-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6b37da75e035a5ebc12ff8e15b62a80889e3e88a.1648760270.git.aburgess@redhat.com \
--to=gdb-patches@sourceware.org \
--cc=aburgess@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox