From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 40642 invoked by alias); 17 Jan 2020 15:18:12 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 40630 invoked by uid 89); 17 Jan 2020 15:18:11 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 spammy= X-HELO: us-smtp-1.mimecast.com Received: from us-smtp-delivery-1.mimecast.com (HELO us-smtp-1.mimecast.com) (205.139.110.120) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 17 Jan 2020 15:18:00 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1579274279; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=hveFFbLL+UeqrVMmJxHQ/MqCS+p171N1Ba24607bQjg=; b=DXgUGSce2b0f+WgbZw6BCx1PVoo31mCivGxdFDVn2tvlr0fxjsaXpds7VWQb910HEZTQta baRRKR6HQbzzIMamQXpLjXIwymfUFxsTxZsXRqMdvNUJ5xv6K5SenW10WtRwjNLVcgg2RQ Tjw0wnb1hT5Q26lCHGtH+d7h6M0/yCE= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-376-mfyTn0vdNwSPsg5xHM0Ang-1; Fri, 17 Jan 2020 10:17:55 -0500 Received: by mail-wm1-f71.google.com with SMTP id y125so3223278wmg.1 for ; Fri, 17 Jan 2020 07:17:55 -0800 (PST) Return-Path: Received: from ?IPv6:2001:8a0:f913:f700:56ee:75ff:fe8d:232b? ([2001:8a0:f913:f700:56ee:75ff:fe8d:232b]) by smtp.gmail.com with ESMTPSA id q11sm34762604wrp.24.2020.01.17.07.17.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 17 Jan 2020 07:17:53 -0800 (PST) Subject: Re: [PATCH v2 0/6] Move gdbsupport to top level To: Simon Marchi , Tom Tromey , gdb-patches@sourceware.org References: <20200109005807.7314-1-tom@tromey.com> <8a8de6a9-37b8-cad3-c818-be903037fe48@redhat.com> <437c1b86-0aa8-57b9-53e2-f21567e2bb14@redhat.com> <87c733a2-2b25-a954-88a1-9bfb1a7eca12@redhat.com> <4fed38dc-aaa7-b76b-880f-bab0b1b5add2@redhat.com> <053b43db-381c-a72d-ea5d-9bcb74a8440c@simark.ca> <78d5599b-9773-954f-ea06-86f65a1c6842@redhat.com> <2cb89dd1-f029-d495-4823-72ae2d5253d2@simark.ca> From: Pedro Alves Message-ID: <6b0b7f90-f526-73a9-3de8-aea958688d15@redhat.com> Date: Fri, 17 Jan 2020 15:32:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <2cb89dd1-f029-d495-4823-72ae2d5253d2@simark.ca> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2020-01/txt/msg00533.txt.bz2 On 1/17/20 2:10 PM, Simon Marchi wrote: > On 2020-01-17 8:35 a.m., Pedro Alves wrote: >>>> So the original solution of adding the gnulib dir to the include path >>>> isn't that bad, though I call it a hack. >>> >>> I would have to see it, but it sounds like the simplest solution. >> >> It was the first patch I posted, here: >> https://sourceware.org/ml/gdb-patches/2020-01/msg00419.html > > Ok thanks, I did not follow this story from the beginning. > >> But, gosh makes me realize there's an even simpler solution... >> Just rename support-config.h to config.h... Do we need to call >> it something else for some reason? I couldn't find one. > > That's a good idea. > >>> >>>>> The gdb-config.h above should be gdbserver-config.h. >>>> Here's v2. WDYT? Which of all the approaches discussed would >>>> you prefer? >>> >>> Probably the solution that involves the least files and indirections. But >>> the one proposed in the latest patch is fine with me too. It's set and >>> forget, once it builds again we won't think about it, at least until the >>> next time it breaks. >> >> Note that we already kind of have the config.h indirections via common-defs.h, >> where we include the multiple config.h files. This just moves those >> indirections to the file actually named config.h. >> >>> The buildbot is struggling with this (sending many breakage emails), so I >>> think you should choose one and push it. Then we can cancel all the builds >>> on the master branch until that commit. >> >> Anyway, here's the simpler patch... Let's call it approach #3. >> >> Approach #1 - add -Ignulib >> Approach #2 - add wrapper config.h files in the source dirs >> Approach #3 - rename support-config.h -> config.h > > I'd say let's go for #3, since that's how gdb and gdbserver already work, > it's been working well for years, so it's proven already. I've merged #3 now. We discussed adding a comment to gdbsupport/Makefile.am about the order of include paths, but it turns out that the -I. is added by automake by default (DEFAULT_INCLUDES), not explicitly set. gdb and gdbserver's Makefile.in have comments about it already. So I applied the patch as it was. Thanks, Pedro Alves