From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id qVCUDpcTB2opKj0AWB0awg (envelope-from ) for ; Fri, 15 May 2026 08:37:43 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=LqEsfqb3; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=wlK3WDO0; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=sE/TaQmj; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=737grHve; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 362881E0B1; Fri, 15 May 2026 08:37:43 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id A19FC1E093 for ; Fri, 15 May 2026 08:37:42 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 643544B0A6D8 for ; Fri, 15 May 2026 12:37:41 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 643544B0A6D8 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=LqEsfqb3; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=wlK3WDO0; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=sE/TaQmj; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=737grHve Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by sourceware.org (Postfix) with ESMTPS id 0CC374B0A6D8 for ; Fri, 15 May 2026 12:37:11 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 0CC374B0A6D8 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 0CC374B0A6D8 Authentication-Results: sourceware.org; arc=none smtp.remote-ip=195.135.223.130 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1778848631; cv=none; b=mk6mYodOJu7A8hp7096io0qOgHKDzHruWYura6P6uU5BqtjL2inpwGuS+ro6U+K4jjm7SFJj7dxALEvdynxqh+5DaC040VkzjaxX0UG+sAr9z7HWv2gk0vMPubtAN/vT0CsNiQJl2Yerp2UuR6sJiiBP6D2YHaQBz0AGQk/oWk0= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1778848631; c=relaxed/simple; bh=vVedJANn8BhG+dhiM7n8KnmVyCid6mA+TA3KydfVWMc=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature: Message-ID:Date:MIME-Version:Subject:To:From; b=mBj/eXm+tztBXkWYTsDhAt1LmxyJ8H+Ox9BYuYYQI/JXvR5GtcyNsmTjKXmUUgEJ70EQIcjKcFqeV3X1kwwyxBHLKjhsBXpHCmQ62FJ4YcK45HlMpoij3CAHaqfiIqHVIstq0tRvK5Mg0QOX+NYxm/NM+KYLsVVawqE0iBhj714= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=LqEsfqb3; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=wlK3WDO0; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=sE/TaQmj; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=737grHve DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 0CC374B0A6D8 Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 0F72A6A88E; Fri, 15 May 2026 12:37:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1778848630; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=CH9iHnXz6zFdBMBHD8aEFb0r2izUhhgMXlbcz73YlRQ=; b=LqEsfqb3bdB26HcaKLd9XiRo+ioakRu7nqmiC9CyMlzouSJkK25DIFaNHFFS1lQte7AV1L hJEwQMwP7dmSZBmJB5amAaOpESkPKLvkp6BdeIcZ20Yq7tUIPPgbUjGlpx1idHPHmbzWjr s0s8FDqeJVRbHtmFnw+tPAEZLvJ0JEU= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1778848630; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=CH9iHnXz6zFdBMBHD8aEFb0r2izUhhgMXlbcz73YlRQ=; b=wlK3WDO0l19cG0qoPg59TGiArvuOd6T1UEY3gnQOWMqKmD/Frj16VhkyLnL08opyQk4rkt yeRMBjEW3srzYxDA== Authentication-Results: smtp-out1.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1778848629; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=CH9iHnXz6zFdBMBHD8aEFb0r2izUhhgMXlbcz73YlRQ=; b=sE/TaQmjyOlAFmOp2d7tlHvkp3dIZdf8d/uOnZ/f9WRM/IcYnZFndfScMT3CuvLObwnuCG QYqRkZRsBBiPqGgya82eilbNE2AU8OGuyEQzqMtlj9xm1d6rW7aQTpiYJEcdEewMKsKfmB dC/cKXF+3qY6r+FHjwa6aE1kWz2dx+M= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1778848629; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=CH9iHnXz6zFdBMBHD8aEFb0r2izUhhgMXlbcz73YlRQ=; b=737grHve1O9VY5yN+pDnEPkVWSr2DTrgMKgYYWJ+7iIUgirECJNJY7l50NbnKvpSIicFgE uH4Yt+R0FniRWWBg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id E8CAC593A9; Fri, 15 May 2026 12:37:08 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id 8qKRN3QTB2rhNQAAD6G6ig (envelope-from ); Fri, 15 May 2026 12:37:08 +0000 Message-ID: <6aebb3c7-0dee-4502-a766-4d3dfaba1f85@suse.de> Date: Fri, 15 May 2026 14:37:08 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 00/10] Mildly better refcount safety for Python To: Simon Marchi , Tom Tromey , gdb-patches@sourceware.org References: <20260220-python-safety-minor-v1-0-4c4b12e445af@adacore.com> Content-Language: en-US From: Tom de Vries In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spamd-Result: default: False [-4.30 / 50.00]; BAYES_HAM(-3.00)[99.99%]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; FUZZY_RATELIMITED(0.00)[rspamd.com]; RCVD_VIA_SMTP_AUTH(0.00)[]; MIME_TRACE(0.00)[0:+]; ARC_NA(0.00)[]; TO_DN_SOME(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; RCVD_TLS_ALL(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[3]; FROM_EQ_ENVFROM(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:helo, sourceware.org:url, suse.de:mid] X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 2/21/26 3:31 AM, Simon Marchi wrote: > > > On 2026-02-20 16:03, Tom Tromey wrote: >> This series converts a number of gdb-to-Python converion functions to >> return a gdbpy_ref<> rather than returning a PyObject* and then simply >> documenting that a new reference is returned. >> >> The hope is that this will make refcount mistakes less likely. >> >> Regression tested on x86-64 Fedora 43. >> >> Signed-off-by: Tom Tromey > > I don't know if someone else wants to review this, but I think this is > good. I think it's good if the references are managed from the point > where we get them from the Python API to the point where we release them > to the Python API. > > I gave it a quick look, since it's very mechanical and I probably > wouldn't spot mistakes anyway. But I asked Claude to review and it said > it looked good. It even noted that you fixed a ref leak in the symbol > patch. > > Approved-By: Simon Marchi Hi, I'd like to ask, is there anything holding back committing this patch series? I'm working on a v3 of this ( https://sourceware.org/pipermail/gdb-patches/2026-May/227374.html ) patches series, and realized I'm touching the same code. FWIW, I asked Gemini Pro 3.1 to review this patch series, and it found the fixed ref leak Simon mentions, and no problems. [ It also reported another fixed ref leak, which turned out to be incorrect. ] Thanks, - Tom