From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id GbqRKJMvRWr3SCEAWB0awg (envelope-from ) for ; Wed, 01 Jul 2026 11:17:39 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=amd.com header.i=@amd.com header.a=rsa-sha256 header.s=selector1 header.b=FufQO+aT; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 9F9451E098; Wed, 01 Jul 2026 11:17:39 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-6.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [IPv6:2620:52:6:3111::32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id CBCDD1E024 for ; Wed, 01 Jul 2026 11:17:38 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 5A8B14BA2E16 for ; Wed, 1 Jul 2026 15:17:37 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 5A8B14BA2E16 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=amd.com header.i=@amd.com header.a=rsa-sha256 header.s=selector1 header.b=FufQO+aT Received: from MW6PR02CU001.outbound.protection.outlook.com (mail-westus2azon11012020.outbound.protection.outlook.com [52.101.48.20]) by sourceware.org (Postfix) with ESMTPS id 7F5864BA2E0A for ; Wed, 1 Jul 2026 15:17:10 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 7F5864BA2E0A Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=amd.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 7F5864BA2E0A Authentication-Results: sourceware.org; arc=pass smtp.remote-ip=52.101.48.20 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1782919030; cv=pass; b=vFIlSOUsDErCk/4ZNlJWwmHh55NFDIWX/qfQnhLViUYkaQWH83xK4100VBFIHa1DBj/4hAk5pgho83sewOT9xB/mljxc0HrRxjSeGmI3uV9K3dSQ5/j0wQzvozVDglbZ28NSBn2fbvk1lnPh0in3y1NStdBlF682FrY1bpV6D+Q= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1782919030; c=relaxed/simple; bh=/VmjirjETsGEexBFdUk8xQhmVA8Dqha50fX4i1GYulY=; h=DKIM-Signature:Message-ID:Date:Subject:To:From:MIME-Version; b=VykE1Hgi2fN9sEpAyqWteKJlt3kqUpph9TTB1Ff3Xkod00JVeiyo6MaO0gxD9aq4P3Mdj8akauocgCWxEYXNeVnJ6D860cQlNcG4Xjc6iyWpsKRghWIjMkE0SRQ0Q7Rkf28+NbQ0dB6YO0gwSnQgGnrQ4BRU1DmOLTrsCp2Lgcg= ARC-Authentication-Results: i=2; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=amd.com header.i=@amd.com header.a=rsa-sha256 header.s=selector1 header.b=FufQO+aT DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 7F5864BA2E0A ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=liNQdtSEY3rTP0IJmdp8kV5+aUDJAuVXk0rMrqc5bssA0P72eRHQKZt7lvHw+u0pHoxW03Eb9ERbaS+YWnN2H+rssG7Tkj37WHux+ZOy746XcmAr7o9rPTJLzdfRNpdXJf0olkgiDd+w+aIOBSbPV9jtguzHHRrVrH/BOcW2tNKh3BGgMKF28/KvfyOwasQaQwATB7/aP6yXmfAphDMJpwkFwjSY37EVs6kpd4+qapsJJvcJGpSqh4B+NKbC6jgEhMviHO/n1Ov/oe1wMMxIFeuVDQpGtqk2mA/DvfobtnHsfUC49le8T4H0fYMuxrqFKNS4x9mNSynfgQKDh9dNhw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=wONbLLlwhK0GC65GDw6oHdtTdGCZH4IWtaHPW3boEEw=; b=ZbH68MsO6SCn26Vu7WZgQQBNtk7FcfloyCu3wsfZhYZoLhFzICD1jXez119IYZSJ7zSdojMgwC2xeDGhrkwBpU6rlKCkgkVeJ7KWCAfl5Ts7XpBx/B3jL2DHHL0N61pJEysCB7LtGyxXOfSnzTl07MG8+VrwihSVNQztV1b+qBT2u79aLiFvFHpql2i2sEUGiBWgQPM/2hiRxxztxcxB9eu7BARxjBWe+7xY/HBk8TjVpzC81Swb9/eZwcGunGMLNvyFBjdT+vXtJyp7lce9Ds5O/n0EBSD5wv3FqCXrP7cuPhAk9n4yIAx8nmvpe7FCNanrgsqTjbvHKPS1jvQeFQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wONbLLlwhK0GC65GDw6oHdtTdGCZH4IWtaHPW3boEEw=; b=FufQO+aTElkKWbRNAp5OvOkYibZVVUdoMVMA1vVYWjYsqxqItEadZ3cd+jIwOG9I9hAiM++ULJXu7+j/PL3cAExJ/F4CYx6AkN0t2ZCooud9dnxDbYA4uFsjdo1XHL2w+KIC3KViNRqPU9zZaqwru1Xu517WsvorsaY9nUClZlk= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH3PR12MB9079.namprd12.prod.outlook.com (2603:10b6:610:1a1::9) by IA0PR12MB7532.namprd12.prod.outlook.com (2603:10b6:208:43e::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.181.9; Wed, 1 Jul 2026 15:17:02 +0000 Received: from CH3PR12MB9079.namprd12.prod.outlook.com ([fe80::5a7a:2adf:1862:35c3]) by CH3PR12MB9079.namprd12.prod.outlook.com ([fe80::5a7a:2adf:1862:35c3%5]) with mapi id 15.21.0181.008; Wed, 1 Jul 2026 15:17:02 +0000 Message-ID: <6ae6dd2b-9577-4711-a0c8-93663a28e997@amd.com> Date: Wed, 1 Jul 2026 16:16:57 +0100 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] gdb, amd-dbgapi-target: use PRIu64 and PRIu32 To: Tankut Baris Aktemur , gdb-patches@sourceware.org References: <20260701142846.2566570-1-tankutbaris.aktemur@amd.com> Content-Language: en-US From: Lancelot SIX In-Reply-To: <20260701142846.2566570-1-tankutbaris.aktemur@amd.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR3P281CA0022.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1c::10) To CH3PR12MB9079.namprd12.prod.outlook.com (2603:10b6:610:1a1::9) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH3PR12MB9079:EE_|IA0PR12MB7532:EE_ X-MS-Office365-Filtering-Correlation-Id: f28bb1d9-1e87-46ff-3c35-08ded783cd4c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|366016|23010399003|1800799024|376014|11063799006|56012099006|22082099003|18002099003; X-Microsoft-Antispam-Message-Info: 1zITX9Tl0J7rSiwyQ5a5xW78TSfjsiVz5efuWgmpYSJ6meEVws8/1WcI6WrRYYRwXJZ7EAKx5qek6bPRdgrEcjS3XM2Xcy4IxefIJkn9E4IbA1ZC5G9E9GatsD9zgtbwJExLkdC4aLVN6luucZJhH0XN6f7LevZqEj7D6djoCqeMaYP87evm+Qk/rPtFR0SKbFGBj9oNo93QyJ7wXEzkrOpy3lrsUZd9kVbPX+/1hrlsMjRkA4nXLQ2Rbe6uzlgaZu/sjCx5OxLBRv/vLH0MJeBHPMcUyJWwkt7RMtgV180xiglSgyAw1PYTQ6EOIFBzKk7bcYN/XfCi1BUUBTxIdc4TTE+aExqbnx8DqeiU+QagE3k8tyVBB5lEp9/f8wY3c56OzgjLLTI7AXzEA+HyA0M6A97XOMeJlz6ZewhY1dcEHyB7Qp+7DiucbSEmGIdwd9tGbkPcs4w9k7y6ToMsh21XK/8KhfajIjLuqakD1nxtrpFFwUozSg4QYay5IrF3SXPAnQkIVxDC0orna706RuJzd8DbLQ2t4ygr2H083NwRXlW7JFi6JUxYgxFXBxu+ZY+RyUoiy/uHgN317cTK0hgdngG6xQz3Cb8ZMmSMzCsgvqPmYNlYVdyAHf3Ue8RN+biFzS5QRcB0f5QNP88Fd/uwbGwAwc5+CY/6udGF/u8= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH3PR12MB9079.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(366016)(23010399003)(1800799024)(376014)(11063799006)(56012099006)(22082099003)(18002099003); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?clVLYkVaQk5vZWdCckU3azdZODNydUI4cXVDczNmR0dIYlNqV2RNZVVDb21k?= =?utf-8?B?MjYxN1RXUjBEcDMyVEdwN1lhMnljNDY5MG0wd3F2WWRGRkR1Zm9pcHc1d3hD?= =?utf-8?B?eGpONVNGa2xEOS9QKy9ieUVHR09CRzZDbi9EQTZwTlkzc0FWV2FadU1KQ0hx?= =?utf-8?B?RDhMazdKa0xWQXk1dzhTb2NESUNDSnk5bmlMN0JJc3VpanBIQ0JwbmxkQlhN?= =?utf-8?B?UVg5UVZBZHF5a3hzQTNOeXJTcHBrdWZJUWE5V1dnYzdSSkpUY1Flc3pJcmJZ?= =?utf-8?B?emdQdk9teVViT1h1VWd1eXVKUDBNRnNpaTdqQ3MyWmhrdVVEWWRYQmhrMG5D?= =?utf-8?B?bVhOeHZDVVF4MmxBUU9LM21WZk9EeDlFWHlJUXJlUi9hVDNuSk9ER0Z1c3lZ?= =?utf-8?B?Y0JlM1cyclhKOWZzL3F5RHp5bG1XNkdRMGkrMWVpNk51OWlmWWpkcGFmZVhL?= =?utf-8?B?bTJ3VlhBUS93VXFVZVRhUmI4R0d4QTdkTFc4QVhSZmtTSllNUmNzeFlZL0cr?= =?utf-8?B?Y1c1S2J0REZBTW1VV3pTUWRQNUtad1JBcFNTZUZ1WSs1N0loa2FoZU5ZMG1Q?= =?utf-8?B?WmNhTXRyWTVVdmU0S0R5VkFUUmI2MTlHZFA4c2JqTnYyTm1SUCt6azIrZnl1?= =?utf-8?B?UUxmUEs3MnJFaVR6NEl6RS9GcldnZGgyNkVLQ0Y5TzVjZ0V4YlhwT2hEQlhU?= =?utf-8?B?eVp1aHpqWFM3by9CUVlMMXlxUFR1NnJUSk1KUkZkUnNlN20zZDNEMlJYV2lu?= =?utf-8?B?d3NtWkpyZjdkbEZLRUlZc1U3cFZ6cWJjUWJPaG8zcDEvQXhvVFNTNG0yb2Fs?= =?utf-8?B?KzFtS1d5bGsraWZUQWVlNmQ3VGMwa0ZJNUVUZzBqV2prU1BnaVUwSk9PZ2ky?= =?utf-8?B?S1I4MmVtZmlUMDk0OTVwdlRpc1JWdHJYaVJPalpIMVB4blE0OWpoeThFTkZv?= =?utf-8?B?b0xvZ1hFZHdMSU8xWnJjdTNobUZxMlU1VTg2L1dnYlo2cjZvNDhlRzFiQldK?= =?utf-8?B?cVI0ZGtYMHlrbHdsSkZYOG0xU2hKTGFjcEtHS0k5a2dHMElTSDZCaWRYd2hD?= =?utf-8?B?KzBISmFvRElXdkxKb1hzb0J3VUNzVmlWSUFNQWwyR2xzM0RTMEQxM0w4V0hP?= =?utf-8?B?QVQwMGw2V2tWcHR0MDJaa1RSakhxbklCZTBPbmN6R25FaWVyUWllOE5saHFR?= =?utf-8?B?NVlteDZtNm5DNVBuV0tWMDYvbnhPTzRxTFBnYzdYSEJVZ1ZNQ2dVbW9zWHZm?= =?utf-8?B?QkRXUTVJUGw1dys5TmN2Rk9hakhFMHZtMHBUelJkdTZXWHBGQUg4dkJKbi9L?= =?utf-8?B?b3hqUUQwMmJkSzF6cm5IM2tFYzhIVmJreDVtb0x1WVluYnMyK2ZlaGRDTU96?= =?utf-8?B?VFpxbzFWVDZhQyszb3RLN3JNUzdDV1J5MjRKRm5oeWNQVGxnUkpJNk5vcUFl?= =?utf-8?B?QzYvMlJqSEg0MCtENjlDbTJqd3pRenlHUkQycTlEOVArRHNlaWVaem52NVA1?= =?utf-8?B?V1lqbSt2T1hZU1BWeHd6UVlYOHZRckc3Q05xbUFqZGkrMytUbll3bFJtZDB4?= =?utf-8?B?WUdvUXdHQXlnZnZMNjVGdk14KzFBKzBJRWdPNnRyVldxSE5HK0lhRU5xUk1Z?= =?utf-8?B?T2dldmZUbWdRWG54OWwxRFlVSmJLdWRNTzVUN1NtMUR0Ti9ld1VUTzRrYkVT?= =?utf-8?B?SU9qSnhuOTNHQTZsS1dINWM2aHBVd0d2V0hkdkd5cFFoZytpZ2FibWtmNkZV?= =?utf-8?B?Q1d2cS9VOVdhaFN4a2hiK1FRVjZVdU9sbnJGZitwN2w1NEFBeDVaWXVnc0x3?= =?utf-8?B?SU1OUGhqQXVZVHZVZGpnaDNhWlB0NVB4T2MvbEx6ZW5yQ0kwUjBkNWhYSitv?= =?utf-8?B?Y2UwTC9INWFxcEVpeDZOaEtLYlVpVjNUenhkL2lQK2FmaHgxRDMrWGk5dko2?= =?utf-8?B?WWlPME1CZ1BQWXJhQ01nMlFyOTBwN0Qzbjd2eXg5VUFXTDhySjhBek05TVVy?= =?utf-8?B?UjN0VjdxRm5sMUVHNjNoNUFEbmhZNXp6VDZPemd5ZjduNERtMW1ZamtoMFBG?= =?utf-8?B?VURCZjRxdFNOU2l4bmZWb1JIb0RuU0dPbm5ZMHJNSUNqc0I2eXVTWFNnUGM3?= =?utf-8?B?WlMyS0tISjhNNG5JTDc5UXF0SVdoRzJLVysvbmFUdGxzTE80eHo1Z3Bwblh6?= =?utf-8?B?SDBCbUpxQ3NDMHhFVzZPUHoycXVTMG1WSDUvSHlhNGswT2U0QUcrVTBrd3Fy?= =?utf-8?B?UWdYUEszN1g0alFKdU9YNVRJK1VFZitCTjFuU3g4bU9mVmV3dUZkMnJHeTkr?= =?utf-8?Q?IeoSDiW57BSxILwa5l?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: f28bb1d9-1e87-46ff-3c35-08ded783cd4c X-MS-Exchange-CrossTenant-AuthSource: CH3PR12MB9079.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Jul 2026 15:17:02.0493 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 78UnqW6BIK3A9WA5SHNcLY//gaxNHfsoUswGQUackXa1Y+IH8mpNB6dT+53Czs6yrOZupLUdWObA2W1WozCpWA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR12MB7532 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Hi, Doesn't GDB have an implicit habit/policy not to use the PRI??? macros? I do not mind them in amd-dbgapi-target.c, but want to make sure global maintainers are fine with this. I guess the alternative is to use pulongest + %s instead of PRIu64. i.e. something like this: str += (agent_id != AMD_DBGAPI_AGENT_NONE ? string_printf (" %s", pulongest (agent_id.handle)) : "?"); Lancelot. On 01/07/2026 15:28, Tankut Baris Aktemur wrote: > In amd-dbgapi-target, there are a number of cases where uint64_t and > uint32_t types are being printed. The uint64_t cases are in > particular about identifier handles obtained from the debug API. For > portability, use PRIu64 for uint64_t and PRIu32 for uint32_t values. > > In one case, `ptid.tid ()` was being printed for the wave id. Change > this to use `wave_id.handle` for consistency with the other cases. > --- > gdb/amd-dbgapi-target.c | 58 ++++++++++++++++++++--------------------- > 1 file changed, 29 insertions(+), 29 deletions(-) > > diff --git a/gdb/amd-dbgapi-target.c b/gdb/amd-dbgapi-target.c > index d0424044e0c..14523fcefb3 100644 > --- a/gdb/amd-dbgapi-target.c > +++ b/gdb/amd-dbgapi-target.c > @@ -392,26 +392,26 @@ wave_coordinates::to_string () const > std::string str = "AMDGPU Wave"; > > str += (agent_id != AMD_DBGAPI_AGENT_NONE > - ? string_printf (" %ld", agent_id.handle) > + ? string_printf (" %" PRIu64, agent_id.handle) > : " ?"); > > str += (queue_id != AMD_DBGAPI_QUEUE_NONE > - ? string_printf (":%ld", queue_id.handle) > + ? string_printf (":%" PRIu64, queue_id.handle) > : ":?"); > > str += (dispatch_id != AMD_DBGAPI_DISPATCH_NONE > - ? string_printf (":%ld", dispatch_id.handle) > + ? string_printf (":%" PRIu64, dispatch_id.handle) > : ":?"); > > - str += string_printf (":%ld", wave_id.handle); > + str += string_printf (":%" PRIu64, wave_id.handle); > > str += (group_ids[0] != UINT32_MAX > - ? string_printf (" (%d,%d,%d)", group_ids[0], group_ids[1], > - group_ids[2]) > + ? string_printf (" (%" PRIu32 ",%" PRIu32 ",%" PRIu32 ")", > + group_ids[0], group_ids[1], group_ids[2]) > : " (?,?,?)"); > > str += (wave_in_group != UINT32_MAX > - ? string_printf ("/%d", wave_in_group) > + ? string_printf ("/%" PRIu32, wave_in_group) > : "/?"); > > return str; > @@ -591,8 +591,8 @@ amd_dbgapi_target_breakpoint::check_status (struct bpstat *bs) > &action); > > if (status != AMD_DBGAPI_STATUS_SUCCESS) > - error (_("amd_dbgapi_report_breakpoint_hit failed for breakpoint %ld " > - "at %s (%s)"), > + error (_("amd_dbgapi_report_breakpoint_hit failed for breakpoint %" PRIu64 > + " at %s (%s)"), > breakpoint_id.handle, paddress (inf->arch (), bs->bp_location_at->address), > get_status_string (status)); > > @@ -624,7 +624,7 @@ amd_dbgapi_target_breakpoint::check_status (struct bpstat *bs) > for our breakpoint_id. */ > if (resume_breakpoint_id != breakpoint_id) > error (_("breakpoint resume event is not for this breakpoint. " > - "Expected breakpoint_%ld, got breakpoint_%ld"), > + "Expected breakpoint_%" PRIu64 ", got breakpoint_%" PRIu64), > breakpoint_id.handle, resume_breakpoint_id.handle); > > amd_dbgapi_event_processed (resume_event_id); > @@ -1055,8 +1055,8 @@ amd_dbgapi_target::resume (ptid_t scope_ptid, int step, enum gdb_signal signo) > indicate that the process has exited. GDB treats resuming a > thread that no longer exists as being successful. */ > && status != AMD_DBGAPI_STATUS_ERROR_INVALID_WAVE_ID) > - error (_("wave_resume for wave_%ld failed (%s)"), wave_id.handle, > - get_status_string (status)); > + error (_("wave_resume for wave_%" PRIu64 " failed (%s)"), > + wave_id.handle, get_status_string (status)); > > wi.stopping = false; > } > @@ -1130,12 +1130,12 @@ amd_dbgapi_target::stop (ptid_t ptid) > } > > if (status != AMD_DBGAPI_STATUS_ERROR_INVALID_WAVE_ID) > - error (_("wave_stop for wave_%ld failed (%s)"), wave_id.handle, > - get_status_string (status)); > + error (_("wave_stop for wave_%" PRIu64 " failed (%s)"), > + wave_id.handle, get_status_string (status)); > } > else if (status != AMD_DBGAPI_STATUS_ERROR_INVALID_WAVE_ID) > - error (_("wave_get_info for wave_%ld failed (%s)"), wave_id.handle, > - get_status_string (status)); > + error (_("wave_get_info for wave_%" PRIu64 " failed (%s)"), > + wave_id.handle, get_status_string (status)); > > /* The status is AMD_DBGAPI_STATUS_ERROR_INVALID_WAVE_ID. The wave > could have terminated since the last time the wave list was > @@ -1145,7 +1145,7 @@ amd_dbgapi_target::stop (ptid_t ptid) > wi.stopping = true; > > amd_dbgapi_debug_printf ("got AMD_DBGAPI_STATUS_ERROR_INVALID_WAVE_ID " > - "for wave_%ld, last_resume_mode=%s, " > + "for wave_%" PRIu64 ", last_resume_mode=%s, " > "report_thread_events=%d", > wave_id.handle, > resume_mode_to_string (wi.last_resume_mode), > @@ -1268,7 +1268,7 @@ dbgapi_notifier_handler (int err, gdb_client_data client_data) > sizeof (runtime_state), > &runtime_state); > if (status != AMD_DBGAPI_STATUS_SUCCESS) > - error (_("event_get_info for event_%ld failed (%s)"), > + error (_("event_get_info for event_%" PRIu64 " failed (%s)"), > event_id.handle, get_status_string (status)); > > switch (runtime_state) > @@ -1404,7 +1404,7 @@ add_gpu_thread (inferior *inf, ptid_t wave_ptid) > > if (!info.wave_info_map.try_emplace (wave_id.handle, > wave_info (wave_id)).second) > - internal_error ("wave ID %ld already in map", wave_id.handle); > + internal_error ("wave ID %" PRIu64 " already in map", wave_id.handle); > > /* Create new GPU threads silently to avoid spamming the terminal > with thousands of "[New Thread ...]" messages. */ > @@ -1436,7 +1436,7 @@ process_one_event (amd_dbgapi_inferior_info &info, > = amd_dbgapi_event_get_info (event_id, AMD_DBGAPI_EVENT_INFO_WAVE, > sizeof (wave_id), &wave_id); > if (status != AMD_DBGAPI_STATUS_SUCCESS) > - error (_("event_get_info for event_%ld failed (%s)"), > + error (_("event_get_info for event_%" PRIu64 " failed (%s)"), > event_id.handle, get_status_string (status)); > > ptid_t event_ptid = make_gpu_ptid (info.inf->pid, wave_id); > @@ -1502,7 +1502,7 @@ process_one_event (amd_dbgapi_inferior_info &info, > } > } > else > - error (_("wave_get_info for wave_%ld failed (%s)"), > + error (_("wave_get_info for wave_%" PRIu64 " failed (%s)"), > wave_id.handle, get_status_string (status)); > > info.wave_events.emplace_back (event_ptid, ws); > @@ -1542,7 +1542,7 @@ process_one_event (amd_dbgapi_inferior_info &info, > AMD_DBGAPI_EVENT_INFO_RUNTIME_STATE, > sizeof (runtime_state), &runtime_state); > if (status != AMD_DBGAPI_STATUS_SUCCESS) > - error (_("event_get_info for event_%ld failed (%s)"), > + error (_("event_get_info for event_%" PRIu64 " failed (%s)"), > event_id.handle, get_status_string (status)); > > gdb_assert (runtime_state == AMD_DBGAPI_RUNTIME_STATE_UNLOADED); > @@ -2069,14 +2069,14 @@ amd_dbgapi_target::thread_architecture (ptid_t ptid) > sizeof (architecture_id), > &architecture_id); > if (status != AMD_DBGAPI_STATUS_SUCCESS) > - error (_("Couldn't get architecture for wave_%ld"), ptid.tid ()); > + error (_("Couldn't get architecture for wave_%" PRIu64), wave_id.handle); > > uint32_t elf_amdgpu_machine; > status = amd_dbgapi_architecture_get_info > (architecture_id, AMD_DBGAPI_ARCHITECTURE_INFO_ELF_AMDGPU_MACHINE, > sizeof (elf_amdgpu_machine), &elf_amdgpu_machine); > if (status != AMD_DBGAPI_STATUS_SUCCESS) > - error (_("Couldn't get elf_amdgpu_machine for architecture_%ld"), > + error (_("Couldn't get elf_amdgpu_machine for architecture_%" PRIu64), > architecture_id.handle); > > struct gdbarch_info info; > @@ -2154,7 +2154,7 @@ amd_dbgapi_target::update_thread_list () > || wi.stopping) > { > amd_dbgapi_debug_printf > - ("wave_%ld disappeared, keeping it" > + ("wave_%" PRIu64 " disappeared, keeping it" > " (last_resume_mode=%s, stopping=%d)", > wave_id.handle, > resume_mode_to_string (wi.last_resume_mode), > @@ -2162,8 +2162,8 @@ amd_dbgapi_target::update_thread_list () > } > else > { > - amd_dbgapi_debug_printf ("wave_%ld disappeared, deleting it", > - wave_id.handle); > + amd_dbgapi_debug_printf ("wave_%" PRIu64 " disappeared, " > + "deleting it", wave_id.handle); > delete_thread_silent (&tp); > } > } > @@ -2283,8 +2283,8 @@ amd_dbgapi_target::displaced_step_finish (thread_info *thread, > sizeof (stop_reason), &stop_reason); > > if (status != AMD_DBGAPI_STATUS_SUCCESS) > - error (_("wave_get_info for wave_%ld failed (%s)"), wave_id.handle, > - get_status_string (status)); > + error (_("wave_get_info for wave_%" PRIu64 " failed (%s)"), > + wave_id.handle, get_status_string (status)); > > status = amd_dbgapi_displaced_stepping_complete (wave_id, stepping_id); >