From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5820 invoked by alias); 10 Apr 2017 04:43:00 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 5797 invoked by uid 89); 10 Apr 2017 04:42:59 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_SOFTFAIL autolearn=no version=3.3.2 spammy= X-HELO: simark.ca Received: from simark.ca (HELO simark.ca) (158.69.221.121) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 10 Apr 2017 04:42:57 +0000 Received: by simark.ca (Postfix, from userid 33) id 9E0571E7F5; Mon, 10 Apr 2017 00:42:57 -0400 (EDT) To: Tom Tromey Subject: Re: [RFA 09/14] Remove some cleanups from location.c X-PHP-Originating-Script: 33:rcube.php MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Mon, 10 Apr 2017 04:43:00 -0000 From: Simon Marchi Cc: gdb-patches@sourceware.org In-Reply-To: <20170408201208.2672-10-tom@tromey.com> References: <20170408201208.2672-1-tom@tromey.com> <20170408201208.2672-10-tom@tromey.com> Message-ID: <6abbc01db4cd1345b3b90c48e0338774@polymtl.ca> X-Sender: simon.marchi@polymtl.ca User-Agent: Roundcube Webmail/1.2.4 X-IsSubscribed: yes X-SW-Source: 2017-04/txt/msg00227.txt.bz2 On 2017-04-08 16:12, Tom Tromey wrote: > This removes some more cleanups from location.c by using > unique_xmalloc_ptr. I was going to ask if you considered using std::string, but when I tried it I realized the explicit_location class was not ready to receive std::strings yet. When we get there, I think the string_to_explicit_location will gain a lot in readability. So given the circumstances, this patch looks good to me. Simon