From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 114534 invoked by alias); 27 Jun 2017 16:46:35 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 114450 invoked by uid 89); 27 Jun 2017 16:46:34 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.4 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RCVD_IN_SORBS_SPAM,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=no version=3.3.2 spammy=Cc X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 27 Jun 2017 16:46:33 +0000 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 423A87F3FF; Tue, 27 Jun 2017 16:46:32 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 423A87F3FF Authentication-Results: ext-mx01.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx01.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=palves@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 423A87F3FF Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id 720FD7F624; Tue, 27 Jun 2017 16:46:31 +0000 (UTC) Subject: Re: [RFA 06/10] Allow C-c to work in backtrace in more cases To: Tom Tromey , gdb-patches@sourceware.org References: <20170425194113.17862-1-tom@tromey.com> <20170425194113.17862-7-tom@tromey.com> From: Pedro Alves Message-ID: <6abadf3e-bea2-8b41-5e0f-0211001b855c@redhat.com> Date: Tue, 27 Jun 2017 16:46:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <20170425194113.17862-7-tom@tromey.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2017-06/txt/msg00739.txt.bz2 On 04/25/2017 08:41 PM, Tom Tromey wrote: > PR cli/17716 notes that it is difficult to C-c (or "q" at a pagination > prompt) while backtracing using a frame filter. One reason for this > is that many places in py-framefilter.c use RETURN_MASK_ALL in a > try/catch. > > This patch changes these spots to use RETURN_MASK_ERROR instead. This > is safe to do because this entire file is exception safe now. Are any of these returning back to the Python runtime? If so, then we can't let C++ exceptions cross it. Thanks, Pedro Alves