From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 111055 invoked by alias); 17 Oct 2016 14:59:18 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 110985 invoked by uid 89); 17 Oct 2016 14:59:18 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.2 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=mine X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 17 Oct 2016 14:59:17 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id D4ECF7F7DE; Mon, 17 Oct 2016 14:59:15 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u9HExEi7003326; Mon, 17 Oct 2016 10:59:15 -0400 Subject: Re: [PATCH 0/3] More cleanup elimination / gdb::unique_ptr To: Tom Tromey References: <1476117992-5689-1-git-send-email-palves@redhat.com> <8a49f675-dc9f-e1e9-73ae-e15522b395ae@redhat.com> <87funwlqo7.fsf@tromey.com> <27e4e7c1-fd80-d178-ecb6-0e93eef3deec@redhat.com> <87d1iz3wbt.fsf@tromey.com> Cc: gdb-patches@sourceware.org From: Pedro Alves Message-ID: <6a9fe026-9ae3-fc6f-1007-d0a6a8d9dd42@redhat.com> Date: Mon, 17 Oct 2016 14:59:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <87d1iz3wbt.fsf@tromey.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2016-10/txt/msg00479.txt.bz2 On 10/17/2016 03:05 PM, Tom Tromey wrote: >>>>>> "Pedro" == Pedro Alves writes: > > Pedro> But I'll be happy to drop my patch instead if you'd prefer. > > No, please keep it. OK. >>> but note mine deletes the do_cleanups, which you don't want to do. > > Pedro> Looks like the last cleanup is this one: > Pedro> name = xstrdup (TYPE_FIELD_NAME (type, 0)); > Pedro> cleanup = make_cleanup (xfree, name); > Pedro> tail = name + strlen (RUST_ENUM_PREFIX); > Pedro> and, I can't figure out why we need to xstrdup at all here? > > The string is modified using strtok_r below. Ah, indeed. Thanks, Pedro Alves