From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 91685 invoked by alias); 21 Jul 2016 10:38:27 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 91668 invoked by uid 89); 21 Jul 2016 10:38:26 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.2 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=regularly, promptly X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Thu, 21 Jul 2016 10:38:16 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 3CA123E2AD; Thu, 21 Jul 2016 10:38:15 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u6LAcDqH024427; Thu, 21 Jul 2016 06:38:14 -0400 Subject: Re: [RFA 0/6] Add -Wunused-but-set-parameter and -Wunused-but-set-variable To: Yao Qi , Tom Tromey References: <1465248812-23902-1-git-send-email-tom@tromey.com> Cc: "gdb-patches@sourceware.org" From: Pedro Alves Message-ID: <6a954e1a-ed72-fc02-b9b6-cce85e9b58e9@redhat.com> Date: Thu, 21 Jul 2016 10:38:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.1.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2016-07/txt/msg00240.txt.bz2 On 06/28/2016 04:02 PM, Yao Qi wrote: > On Mon, Jun 6, 2016 at 10:33 PM, Tom Tromey wrote: >> I built and regression tested this using --enable-targets=all on >> x86-64 Fedora 23. However, I could not update the various nat-* >> files, so there are probably unfixed warnings lurking there. > > Can you use cross compiler to cross build native gdb to catch these warnings? > otherwise, once this patch series go in, gdb build on host other than linux may > be broken. The worse that can happen is a warning becomes a build error due to -Werror. Since people can always use --disable-werror to work around it, and that is enabled by default in releases, I don't think a temporary -Werror build break on master is a major problem. What would you say would be a sufficient set of hosts to test before enabling a warning? Testing all supported hosts and all architectures would be unfeasible, naturally. I'd think it'd be acceptable to just build on a couple of the more common hosts, in the name of forward progress. Cross testing for mingw should be easy (Fedora has a cross mingw toolchain in the main repo). Then there's the GCC compile farm; that could be used to cover AIX and some BSD. Any commonly-used host we miss, the buildbot should detect a problem promptly. Hosts that don't have build slaves set up naturally have to rely on someone interested in them building gdb regularly. If there's no one doing that and the build goes broken for long before someone notices, that just indicates that not many people actually care about the port, and so shouldn't we. Thanks, Pedro Alves