Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Simon Marchi <simon.marchi@polymtl.ca>
To: "Wiederhake, Tim" <tim.wiederhake@intel.com>
Cc: gdb-patches@sourceware.org, "Metzger,
	Markus T" <markus.t.metzger@intel.com>
Subject: Re: [PATCH v3 12/12] btrace: Store function segments as objects.
Date: Wed, 10 May 2017 14:16:00 -0000	[thread overview]
Message-ID: <6a8f64acd68ace619b29497e43621d80@polymtl.ca> (raw)
In-Reply-To: <9676A094AF46E14E8265E7A3F4CCE9AF3C14CFF2@irsmsx105.ger.corp.intel.com>

On 2017-05-10 07:46, Wiederhake, Tim wrote:
>> > +  struct btrace_function bfun {mfun, fun, 0, 0, 0, NULL, 0, 0, 0, 0,
>> > 0};
>> 
>> I think it would be much better to add a simple constructor to
>> btrace_function.  For the fields that should simply be zero'ed, you 
>> can
>> initialize fields directly, like we do in many other places (e.g. 
>> class
>> inferior).
> 
> Having a proper constructor would definitely be beneficial here.
> Nevertheless, I would do such a change in a separate patch set.

Ok, but in this case I'd still prefer if you initialized the fields 
directly in the class right away.  In the (unlikely) event that we add a 
field in btrace_function, we'll have to think to update this.

Thanks,

Simon


  reply	other threads:[~2017-05-10 14:16 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-09  7:01 [PATCH v3 00/12] btrace: Turn linked list of function call segments into vector Tim Wiederhake
2017-05-09  7:01 ` [PATCH v3 09/12] btrace: Remove struct btrace_thread_info::flow Tim Wiederhake
2017-05-10  3:46   ` Simon Marchi
2017-05-10 11:46     ` Wiederhake, Tim
2017-05-10 13:59       ` Simon Marchi
2017-05-09  7:01 ` [PATCH v3 02/12] btrace: Transfer ownership of pointers Tim Wiederhake
2017-05-09 12:21   ` Simon Marchi
2017-05-09  7:01 ` [PATCH v3 03/12] btrace: Add btinfo to instruction interator Tim Wiederhake
2017-05-09  7:01 ` [PATCH v3 11/12] btrace: Remove bfun_s vector Tim Wiederhake
2017-05-10  4:27   ` Simon Marchi
2017-05-10 11:46     ` Wiederhake, Tim
2017-05-09  7:01 ` [PATCH v3 06/12] btrace: Remove constant arguments Tim Wiederhake
2017-05-10  2:45   ` Simon Marchi
2017-05-10 11:46     ` Wiederhake, Tim
2017-05-09  7:01 ` [PATCH v3 08/12] btrace: Replace struct btrace_thread_info::up Tim Wiederhake
2017-05-10  3:26   ` Simon Marchi
2017-05-10 11:46     ` Wiederhake, Tim
2017-05-09  7:01 ` [PATCH v3 04/12] btrace: Use function segment index in call iterator Tim Wiederhake
2017-05-09 12:50   ` Simon Marchi
2017-05-09 13:14     ` Wiederhake, Tim
2017-05-09 14:29       ` Simon Marchi
2017-05-09  7:01 ` [PATCH v3 12/12] btrace: Store function segments as objects Tim Wiederhake
2017-05-10  5:10   ` Simon Marchi
2017-05-10 11:46     ` Wiederhake, Tim
2017-05-10 14:16       ` Simon Marchi [this message]
2017-05-09  7:01 ` [PATCH v3 07/12] btrace: Remove struct btrace_thread_info::{begin,end} Tim Wiederhake
2017-05-10  3:06   ` Simon Marchi
2017-05-09  7:01 ` [PATCH v3 01/12] btrace: Use std::vector in struct btrace_thread_information Tim Wiederhake
2017-05-09 12:10   ` Simon Marchi
2017-05-09  7:01 ` [PATCH v3 10/12] btrace: Replace struct btrace_thread_info::segment Tim Wiederhake
2017-05-10  4:14   ` Simon Marchi
2017-05-10 11:46     ` Wiederhake, Tim
2017-05-10 14:13       ` Simon Marchi
2017-05-09  7:01 ` [PATCH v3 05/12] btrace: Use function segment index in insn iterator Tim Wiederhake
2017-05-10  2:20   ` Simon Marchi
2017-05-10 11:46     ` Wiederhake, Tim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6a8f64acd68ace619b29497e43621d80@polymtl.ca \
    --to=simon.marchi@polymtl.ca \
    --cc=gdb-patches@sourceware.org \
    --cc=markus.t.metzger@intel.com \
    --cc=tim.wiederhake@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox