From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id EQd9HbPm2GecbxMAWB0awg (envelope-from ) for ; Mon, 17 Mar 2025 23:21:23 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1742268083; bh=FpKS606tF3U1AasplVDACMujLKUBqB/iiCUKRNCjgSU=; h=Date:Subject:To:References:From:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=t3DvFdA/Qq2eqIlebQOjp0eKjPvhpTMHQoBj2aGYYeERe8NVs0JrBdfSZiRhQN7Dp r/otm+hwmCVERLAQu48ZtYHG7j5gJDuf6nxUaEJqImtkkwzyCGFOi9j9GDnbsfSlaM oFEk1NBlr2eLu1/lGEgrmmGdaRXvqETb8vLyyD1U= Received: by simark.ca (Postfix, from userid 112) id 679A91E100; Mon, 17 Mar 2025 23:21:23 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=unavailable autolearn_force=no version=4.0.1 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=SmIkIAgd; dkim=pass (1024-bit key) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=DeAO5l9O; dkim-atps=neutral Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id EE1D71E05C for ; Mon, 17 Mar 2025 23:21:22 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id A266B385841E for ; Tue, 18 Mar 2025 03:21:22 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org A266B385841E Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=SmIkIAgd; dkim=pass (1024-bit key) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=DeAO5l9O Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id A87C43858D29 for ; Tue, 18 Mar 2025 03:20:54 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A87C43858D29 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark.ca ARC-Filter: OpenARC Filter v1.0.0 sourceware.org A87C43858D29 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=158.69.221.121 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1742268054; cv=none; b=Z3o24QLdwVPEN5uBkYkO/Tv/li0UiG9Lt72oN5yRfXnG6mSUaO5qI3nGT6tkyBTqyACMOGzNJhKG3PYGbe0UBCXrBUNKc0l3olU+VirjD6eM8cMkINmiNQkpuMGRFWcFiZg5PAwTXVByuAqWpSsOW4dG0GAaJwVjAhM6dm0I+Xc= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1742268054; c=relaxed/simple; bh=FpKS606tF3U1AasplVDACMujLKUBqB/iiCUKRNCjgSU=; h=DKIM-Signature:DKIM-Signature:Message-ID:Date:MIME-Version: Subject:To:From; b=I7OutZsQPbvhE9MJ4nvbvThOIHVf+2HAqI9Vm/gHem+cw/LvWtO3oxfeH9xZqpejIlKNYNUyo4z9Yjyg6esSH4R3RDg3qJhpyjDZO58tI4Wt6LZgp3UU0t82aGBXbQ7ETSM88KNswIm3SR3GnzT7d+D1K0dmNehLRe3v3HliCKQ= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org A87C43858D29 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1742268054; bh=FpKS606tF3U1AasplVDACMujLKUBqB/iiCUKRNCjgSU=; h=Date:Subject:To:References:From:In-Reply-To:From; b=SmIkIAgdQi0K7oicu9qwlRyQcxU87bjXBFDNlWo7YErdLr0HFzWKR4KPVzUU/6CvN AsvbynRRx2aDou88AnetXNUf5iXhGEtc11/WD5heag9TgUkPJkl1Ay5nvR1kyg0ZXJ gTljQ4gpTHLOl4vfqz1z/U4DRdIE18eW9Ub5xAaY= Received: by simark.ca (Postfix, from userid 112) id 649931E100; Mon, 17 Mar 2025 23:20:54 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1742268053; bh=FpKS606tF3U1AasplVDACMujLKUBqB/iiCUKRNCjgSU=; h=Date:Subject:To:References:From:In-Reply-To:From; b=DeAO5l9O9QhSaf0YMoommcRRtjXK37CvMRhrPIVn1bazIpuabyssTDLA2g06bJ9BO QbB1mek5pZznA+qRzZRajKCv+vinFQcoW7f3CEv1OyXiakFsQF639Ct+GnRUHEiqdr l3VA+QgMx76RaKxueAdRcE+QMUef2Dw2fB41UKyM= Received: from [10.0.0.11] (modemcable238.237-201-24.mc.videotron.ca [24.201.237.238]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 98DCE1E05C; Mon, 17 Mar 2025 23:20:53 -0400 (EDT) Message-ID: <6a527305-bf04-47de-90ad-0ec9792c4e23@simark.ca> Date: Mon, 17 Mar 2025 23:20:53 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 17/19] Use gdb unordered set and map in cp-namespace.c To: Tom Tromey , gdb-patches@sourceware.org References: <20250317-replace-std-stuff-v1-0-7ba4ee88e218@tromey.com> <20250317-replace-std-stuff-v1-17-7ba4ee88e218@tromey.com> Content-Language: en-US From: Simon Marchi In-Reply-To: <20250317-replace-std-stuff-v1-17-7ba4ee88e218@tromey.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 2025-03-17 22:15, Tom Tromey wrote: > @@ -391,8 +394,7 @@ cp_lookup_symbol_via_imports (const char *scope, > const int search_scope_first, > const int declaration_only, > const int search_parents, > - std::map - struct block_symbol>& found_symbols) > + symbol_map& found_symbols) Space before &, I think. Simon