Re: [PATCH v6 00/15] Handle variable XSAVE layouts

Willgerodt, Felix via Gdb-patches
2023-07-26T08:32:25Z

Hi John,

Just fyi, this week Intel announced APX:
https://www.intel.com/content/www/us/en/developer/articles/technical/advanced-performance-extensions-apx.html

It adds new GPRs. To cite from there:

"The new GPRs are XSAVE-enabled, which means that they can be automatically saved and restored by XSAVE/XRSTOR sequences during context switches.
They do not change the size and layout of the XSAVE area as they take up the space left behind by the deprecated Intel® MPX registers."

Not sure if that has any influence on your patch series, I thought it might be interesting for you anyway.

Regards,
Felix

> -----Original Message-----
> From: Gdb-patches <gdb-patches-
> bounces+felix.willgerodt=intel.com@sourceware.org> On Behalf Of John Baldwin
> Sent: Freitag, 14. Juli 2023 17:59
> To: gdb-patches@sourceware.org
> Cc: Joel Brobecker <brobecker@adacore.com>; George, Jini Susan
> <JiniSusan.George@amd.com>
> Subject: Re: [PATCH v6 00/15] Handle variable XSAVE layouts
>
> On 7/14/23 8:51 AM, John Baldwin wrote:
> > Changes since V5:
> >
> > - A few fixes not tied to the new layout handling have been merged to
> > master.
> >
> > - Reworded the comment describing i386_*_core_read_xsave_info in patches
> > 6 and 8.
> >
> > Aleksandar Paunovic (2):
> > gdbserver: Refactor the legacy region within the xsave struct
> > gdbserver: Use x86_xstate_layout to parse the XSAVE extended state
> > area.
> >
> > John Baldwin (13):
> > x86: Add an x86_xsave_layout structure to handle variable XSAVE
> > layouts.
> > gdb: Store an x86_xsave_layout in i386_gdbarch_tdep.
> > core: Support fetching x86 XSAVE layout from architectures.
> > nat/x86-cpuid.h: Add x86_cpuid_count wrapper around __get_cpuid_count.
> > x86 nat: Add helper functions to save the XSAVE layout for the host.
> > gdb: Update x86 FreeBSD architectures to support XSAVE layouts.
> > gdb: Support XSAVE layouts for the current host in the FreeBSD x86
> > targets.
> > gdb: Update x86 Linux architectures to support XSAVE layouts.
> > gdb: Support XSAVE layouts for the current host in the Linux x86
> > targets.
> > gdb: Use x86_xstate_layout to parse the XSAVE extended state area.
> > gdbserver: Add a function to set the XSAVE mask and size.
> > x86: Remove X86_XSTATE_SIZE and related constants.
> > gdbserver: Simplify handling of ZMM registers.
>
> I would like to get this series into GDB 14 if possible. Without it one
> cannot examine certain XSAVE registers (e.g. YMM for AVX) in core dumps
> generated on modern AMD CPUs on both Linux and FreeBSD.
>
> --
> John Baldwin

Intel Deutschland GmbH
Registered Address: Am Campeon 10, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de <http://www.intel.de>
Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928