Re: [PATCH v6 03/15] core: Support fetching x86 XSAVE layout from architectures.

John Baldwin
2023-07-26T21:28:37Z

On 7/26/23 12:37 PM, Simon Marchi wrote:
> On 7/14/23 11:51, John Baldwin wrote:
>> Add gdbarch_core_read_x86_xsave_layout to fetch the x86 XSAVE layout
>> structure from a core file.
>>
>> Current OS's do not export the offsets of XSAVE state components in
>> core dumps, so provide an i387_set_xsave_layout helper function to set
>
> Re-reading this after a few months, I wonder if naming this function
> i387_guess_xsave_layout would make it a bit clearer. "set" makes it
> sound like it's a dumb setter (which it is not).

Yeah, that probably is a bit clearer, so I will rename it.

> In any case:
>
> Approved-By: Simon Marchi <simon.marchi@efficios.com>
>
> Simon

--
John Baldwin