From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id GBI5MBuA/GMIUz8AWB0awg (envelope-from ) for ; Mon, 27 Feb 2023 05:04:11 -0500 Received: by simark.ca (Postfix, from userid 112) id B82F31E222; Mon, 27 Feb 2023 05:04:11 -0500 (EST) Authentication-Results: simark.ca; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.a=rsa-sha256 header.s=default header.b=lrIusBEE; dkim-atps=neutral X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-9.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,NICE_REPLY_A, RCVD_IN_DNSWL_HI,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id EC7A31E0D3 for ; Mon, 27 Feb 2023 05:04:10 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 1B2BD3858407 for ; Mon, 27 Feb 2023 10:04:10 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 1B2BD3858407 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1677492250; bh=s0ic0AYwsFNUCBg0i00inGCiPoNo/In8tuToD1iP6Uo=; h=Date:Subject:To:References:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=lrIusBEENC9SODRcAbxeBva9IMLw8qlQLSc92NCNXujXFVewGU+fOIaH/IByA3iq5 rEVsklXQLE6wFZOep9qMuknLfysFTtoLmxxVCdjsipzv0llUhAs69P27y+AKpY/9HV CXioTFQm8/eSi8hv1SS36jrhNGHBTlGHny5iCvy4= Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 9F7E23858D20 for ; Mon, 27 Feb 2023 10:03:49 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 9F7E23858D20 Received: from mail-qt1-f200.google.com (mail-qt1-f200.google.com [209.85.160.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-453-naI1xk8FNH24GS_QK6a4sw-1; Mon, 27 Feb 2023 05:03:47 -0500 X-MC-Unique: naI1xk8FNH24GS_QK6a4sw-1 Received: by mail-qt1-f200.google.com with SMTP id c5-20020ac85185000000b003bfae3b8051so2574000qtn.0 for ; Mon, 27 Feb 2023 02:03:47 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=s0ic0AYwsFNUCBg0i00inGCiPoNo/In8tuToD1iP6Uo=; b=HM+xuQZqqRDYrg6FER0hG+Qy35p6gvtwDC/NKdLwxlk71ozQ3FucOzROPX5aVnNuOq Gtv16aym4UdzaPNYDjk36UEcSdVgPVwS7Dk5x/xqw+oNbhYs1ignlDy2RMZvsRWnDzfd c2N5e8TifHCxR1SXCNJrIq/pqzhjy0rzNq1O3AMEaKLJRjUUu1IcaTNqZcOzeGbJH0xg 3JHwWk6BdQLiQ4w2DSVV47yCLvm+Xji1BcFY+LYB7ABUYXnRor/v/wMiOH7V2UNlGXtj XodGVx9DDbC5Gd2SQ8QUE+hEIlIlQzgFyHWky5HxJr6ezPAtPCH0XHWDEQQlv+JQWau9 hg+w== X-Gm-Message-State: AO0yUKX+Ze33yolUrfQ1HpEeBmXQpNn7AIjabA0UCmIYlFUpUcnV4iZQ qUh3CHcxoCO1P5PMvBEAGY6ZNsDmcOv6ZBK3Rg2gW9MAzuqsqib76ueC64T8IKs6UAmz6160UxG ZW+qqmDTW6tX6B2rd/ibtIMIcLrk= X-Received: by 2002:a05:6214:3008:b0:56e:a07b:f4d1 with SMTP id ke8-20020a056214300800b0056ea07bf4d1mr42332066qvb.2.1677492227027; Mon, 27 Feb 2023 02:03:47 -0800 (PST) X-Google-Smtp-Source: AK7set+XIlVgrTCts/vwTjG7PR4espHxCyxZzvQ9w9TW1C5UNBQ/p1gBFJ35SUCZJz5GfAszWd40Qw== X-Received: by 2002:a05:6214:3008:b0:56e:a07b:f4d1 with SMTP id ke8-20020a056214300800b0056ea07bf4d1mr42332042qvb.2.1677492226746; Mon, 27 Feb 2023 02:03:46 -0800 (PST) Received: from [192.168.0.45] (ip-94-112-225-44.bb.vodafone.cz. [94.112.225.44]) by smtp.gmail.com with ESMTPSA id 69-20020a370348000000b0073bacce6ad7sm4587243qkd.82.2023.02.27.02.03.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 27 Feb 2023 02:03:46 -0800 (PST) Message-ID: <6a15c025-530d-8e9b-6220-563ed95bac06@redhat.com> Date: Mon, 27 Feb 2023 11:03:44 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH] gdb/testsuite: Improve testing of GDB's completion functions To: Tom Tromey , Bruno Larsen via Gdb-patches References: <20230222091110.2995513-1-blarsen@redhat.com> <87bklij32o.fsf@tromey.com> In-Reply-To: <87bklij32o.fsf@tromey.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Bruno Larsen via Gdb-patches Reply-To: Bruno Larsen Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" On 24/02/2023 20:06, Tom Tromey wrote: >>>>>> "Bruno" == Bruno Larsen via Gdb-patches writes: > Bruno> When looking at some failures of gdb.linespec/cp-completion-aliases.exp, > Bruno> I noticed that when a completion test will fail, it always fails with a > Bruno> timeout. This is because most completion tests use gdb_test_multiple > Bruno> and only add a check for the correct output. This commit adds new > Bruno> options for both, tab and command completion. > > Looks good to me. > Approved-By: Tom Tromey > > Tom > Thanks, pushed! -- Cheers, Bruno