From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8668 invoked by alias); 22 Jan 2018 13:22:15 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 8653 invoked by uid 89); 22 Jan 2018 13:22:14 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.5 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy=Alan.Hayward@arm.com, H*f:CAH, AlanHaywardarmcom, H*i:CAH X-HELO: EUR01-HE1-obe.outbound.protection.outlook.com Received: from mail-he1eur01on0055.outbound.protection.outlook.com (HELO EUR01-HE1-obe.outbound.protection.outlook.com) (104.47.0.55) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 22 Jan 2018 13:22:12 +0000 Received: from DB3PR08MB0106.eurprd08.prod.outlook.com (10.161.56.20) by DB3PR08MB0108.eurprd08.prod.outlook.com (10.161.56.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.428.17; Mon, 22 Jan 2018 13:22:08 +0000 Received: from DB3PR08MB0106.eurprd08.prod.outlook.com ([fe80::958e:90c2:6108:af75]) by DB3PR08MB0106.eurprd08.prod.outlook.com ([fe80::958e:90c2:6108:af75%14]) with mapi id 15.20.0428.019; Mon, 22 Jan 2018 13:22:08 +0000 From: Alan Hayward To: Yao Qi CC: "gdb-patches@sourceware.org" , nd Subject: Re: [PATCH 3/6] : Update dat files with arch and osabi Date: Mon, 22 Jan 2018 13:22:00 -0000 Message-ID: <6D4AA708-D4CE-42E6-8D84-54E6B292DB0B@arm.com> References: <737CEA28-7C3E-4A3C-AE7C-C0139A84FAC8@arm.com> In-Reply-To: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Alan.Hayward@arm.com; x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;DB3PR08MB0108;6:vcIo8GwuBqTn1BWvASpL/FlInb8vtKe25opQ2oqhTEv6HqNWywwNP1FCOJy7m9/AJV/aPOZ2MdNIJ4g9dg8M0G6ix8WgbmZjy2zVg5E3dY7JEj1xXoeo7JNAao9cAuGAy7rddg6poh3XjQ/vexOdV/wCQlKpjz52vs5n/ofWtSssR5x6kwPMn9unYnTm2ocleRcAotpfwfQvtFYRoM1x6/tEfWfJqbm308oeTbOzeJLCCn37BNCxBu6PCAupzf6s/ccMFXMnbNAOpw3CiiAyu4U365+SBzm7V7ruvkxhQjsUBPn8rZZCMdzlptr0vLsVmQRKqdnbhDvM5iRwsoVoJ9IARIuKGHYoO4AakhYcPVv9yjAs2k2MsAzGgljduUwO;5:PrVb0PGgHQgve2h5WZH898q6zXHOf0U1vEWryusS1stUmNq/Rt3POwR7QlFQlJemuBCZvjQYhrzdtmzC8vPoxfdPeb+sDHFTywNhDMQ9wZJ0pX4QAZV5VGnkL71IoRV6Wn+IoUsOo8mVJTf/XNB9x4PJB/HHm4qTNcQuVNwAdi4=;24:Px61mD74x9ifAwYI/uHcL5rRcAx/LmcKEMZoYKUS2VErpcI6qAok3vMZs2XQk7nqvOHApELlWjIVeW+Hgq0+DpWvUYBfB3OHbSS95eR5U8E=;7:W5l5+FN7HiDP4OLXX3uGER2jjO86ViXk8DG7vQXz6trPUz/rDEL649QRMEqK1e/cZ8nHVeKtbfI1Thn5tyboN9XmkKVRiBhR4wNB78CG3RXky2JuuAlrviLFtFoHMGXqDGWA/YF4YoahjvS6MEEMmwjsDX535BLcs3it6ccWAdPnuGC18rHTh+fWqTb5j9XrkcKzPxm7qyYxn87pSaca9Gi7i8AAJFLpQzvjqnTNQGdSLzcKAYUX1JDk4Y859rb+ x-ms-exchange-antispam-srfa-diagnostics: SSOS; x-ms-office365-filtering-correlation-id: 45b0bcbc-922a-445e-d8bb-08d5619b2388 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(7020095)(4652020)(5600026)(4604075)(3008032)(48565401081)(2017052603307)(7153060)(7193020);SRVR:DB3PR08MB0108; x-ms-traffictypediagnostic: DB3PR08MB0108: nodisclaimer: True x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(180628864354917)(85827821059158); x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(6040501)(2401047)(5005006)(8121501046)(3231023)(2400081)(944501161)(3002001)(10201501046)(93006095)(93001095)(6055026)(6041288)(20161123562045)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123564045)(20161123558120)(6072148)(201708071742011);SRVR:DB3PR08MB0108;BCL:0;PCL:0;RULEID:(100000803101)(100110400095);SRVR:DB3PR08MB0108; x-forefront-prvs: 0560A2214D x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(39860400002)(376002)(346002)(396003)(366004)(39380400002)(189003)(199004)(97736004)(76176011)(25786009)(6506007)(82746002)(106356001)(53546011)(4326008)(83716003)(3660700001)(3280700002)(6916009)(72206003)(2950100002)(305945005)(6436002)(2900100001)(478600001)(39060400002)(86362001)(59450400001)(1411001)(99286004)(105586002)(81166006)(5250100002)(8936002)(33656002)(6116002)(2906002)(7736002)(8676002)(26005)(81156014)(5660300001)(36756003)(4743002)(68736007)(6486002)(14454004)(54906003)(66066001)(316002)(6246003)(3846002)(53936002)(102836004)(229853002)(6512007);DIR:OUT;SFP:1101;SCL:1;SRVR:DB3PR08MB0108;H:DB3PR08MB0106.eurprd08.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: HJssmSQYdkxyq47zwIAw3lei2ki3NJ7rULE/46IHwoenLQkZs9sXogf3vb+qv/3CPNnpEEvS7tes1j1GThty8A== spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-ID: <56FEAD8EFC2570469D4B576138801078@eurprd08.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-Network-Message-Id: 45b0bcbc-922a-445e-d8bb-08d5619b2388 X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Jan 2018 13:22:08.5851 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB3PR08MB0108 X-IsSubscribed: yes X-SW-Source: 2018-01/txt/msg00440.txt.bz2 > On 19 Jan 2018, at 22:01, Yao Qi wrote: >=20 > On Tue, Jan 16, 2018 at 9:52 AM, Alan Hayward wrot= e: >> This patch simply ensures the osabi and arch fields exist in the dat >> files. Otherwise, they will be missing in later patches when gdbserver >> converts target descriptions to xml. >=20 > I don't think we need to change *.dat. *.dat are used to generate *.c fi= les > in gdbserver build directory for the following two reasons, >=20 > - the port isn't converted to new style flexible target descriptions yet, > - or the generated *.c files are used for test, >=20 > The goal of this series, IMO, is to get rid of the xml features for the p= orts > which already use new style flexible target descriptions, like x86 > and aarch64. >=20 > For the old style target description, they still use xml files for each > description, and osabi/arch is written in these xml files. >=20 If you remove this patch, but keep all the rest of the series, then the por= ts using the new style target descriptions will segfault when printing the xml in print_xml_feature::visit_pre() because the -generated.c files do not contain an arch or osabi. The segfault happens on gdbserver init because the -generated.c functions are calling tdesc_get_features_xml(). Thinking about it, I will remove this call from -generated. That fixes the bug. This leaves a question: Is it required that the generated target descriptions have the osabi and ar= ch? If it does not need this information, then I will delete this patch. Alan. =20