From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 128597 invoked by alias); 23 Jun 2015 15:52:23 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 128587 invoked by uid 89); 23 Jun 2015 15:52:23 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mailapp01.imgtec.com Received: from mailapp01.imgtec.com (HELO mailapp01.imgtec.com) (195.59.15.196) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 23 Jun 2015 15:52:21 +0000 Received: from KLMAIL01.kl.imgtec.org (unknown [192.168.5.35]) by Websense Email Security Gateway with ESMTPS id A890861757522; Tue, 23 Jun 2015 16:52:15 +0100 (IST) Received: from LEMAIL01.le.imgtec.org (192.168.152.62) by KLMAIL01.kl.imgtec.org (192.168.5.35) with Microsoft SMTP Server (TLS) id 14.3.195.1; Tue, 23 Jun 2015 16:52:18 +0100 Received: from LEMAIL01.le.imgtec.org ([fe80::5ae:ee16:f4b9:cda9]) by LEMAIL01.le.imgtec.org ([fe80::5ae:ee16:f4b9:cda9%17]) with mapi id 14.03.0210.002; Tue, 23 Jun 2015 16:52:18 +0100 From: Matthew Fortune To: Joseph Myers CC: "gdb-patches@sourceware.org" Subject: RE: [PATCH, MIPS] Support shared library debug with MIPS PIE (gdb) Date: Tue, 23 Jun 2015 15:52:00 -0000 Message-ID: <6D39441BF12EF246A7ABCE6654B023532117634B@LEMAIL01.le.imgtec.org> References: <6D39441BF12EF246A7ABCE6654B02353211760FA@LEMAIL01.le.imgtec.org> In-Reply-To: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-SW-Source: 2015-06/txt/msg00479.txt.bz2 Joseph Myers writes: > On Tue, 23 Jun 2015, Matthew Fortune wrote: >=20 > > Please note that the new DT_MIPS_RLD_MAP2 support will not be enabled u= nless > > the host's elf.h header has the new tag defined in it. For cross compil= ed GDB > > this may mean hacking the solib-svr4.c file to define the macro until s= uch > > time as distributions update glibc. >=20 > That doesn't make any sense to me. Hosts (e.g. MinGW) may not have elf.h > at all. GDB should get these definitions from the #include "elf/mips.h" > already in solib-svr4.c (i.e. from toplevel's include/elf/mips.h). And so > there should be no #ifdefs there. Thanks. I got this twisted owing to the gdbserver using the host elf.h and = me keeping the binutils and GDB patches separate when I should have had the elf/mips.h changes shared between the two. I'll send an updated patch with the #ifdefs removed and ensure that binutils commit precedes the GDB commit when approved. Matthew