From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11606 invoked by alias); 27 Jul 2009 14:57:31 -0000 Received: (qmail 11596 invoked by uid 22791); 27 Jul 2009 14:57:30 -0000 X-SWARE-Spam-Status: No, hits=-2.3 required=5.0 tests=AWL,BAYES_00,SPF_PASS X-Spam-Check-By: sourceware.org Received: from imr2.ericy.com (HELO imr2.ericy.com) (198.24.6.3) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 27 Jul 2009 14:57:24 +0000 Received: from eusrcmw751.eamcs.ericsson.se (eusrcmw751.exu.ericsson.se [138.85.77.51]) by imr2.ericy.com (8.13.1/8.13.1) with ESMTP id n6REvJx4017023; Mon, 27 Jul 2009 09:57:20 -0500 Received: from ecamlmw720.eamcs.ericsson.se ([142.133.1.72]) by eusrcmw751.eamcs.ericsson.se with Microsoft SMTPSVC(6.0.3790.3959); Mon, 27 Jul 2009 09:56:53 -0500 Content-class: urn:content-classes:message MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: quoted-printable Subject: RE: [RFA] Implement -break-commands Date: Mon, 27 Jul 2009 16:08:00 -0000 Message-ID: <6D19CA8D71C89C43A057926FE0D4ADAA07C69282@ecamlmw720.eamcs.ericsson.se> In-Reply-To: <200907271303.13335.vladimir@codesourcery.com> References: <200907271303.13335.vladimir@codesourcery.com> From: "Marc Khouzam" To: "Vladimir Prus" , X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-07/txt/msg00647.txt.bz2 > -----Original Message----- > From: gdb-patches-owner@sourceware.org=20 > [mailto:gdb-patches-owner@sourceware.org] On Behalf Of Vladimir Prus > Sent: Monday, July 27, 2009 5:03 AM > To: gdb-patches@sources.redhat.com > Subject: [RFA] Implement -break-commands >=20 >=20 > The below patches implement MI -break-commands. As the name implies, > it's the same as CLI 'commands'. There are two patches: one > refactors CLI 'commands' for easier reuse, and the second actually > adds -break-commands. The patches mostly were derived from Apple > branch, and then adjusted for CVS HEAD. One functional change I've > made is that '-break-commands ' does not report the list > of currently set commands -- since -break-info already prints his > information, it does not seem necessary to add another way. I've > also added a test and docs. Nice addition. >=20 > The parts of this patch that are not MI are: > 1. Slight refactoring of cli/cli-script.c > 2. Slight refactoring of breakpoint.c >=20 > I'd appreciate if somebody could review them. >=20 > Eli, there's also doc change here, comments appreciated. I noticed the example in the doc is missing the breakpoint number: > +-break-command "print v" "continue" Unless it is optional? Marc