From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26452 invoked by alias); 7 May 2009 19:28:48 -0000 Received: (qmail 26444 invoked by uid 22791); 7 May 2009 19:28:47 -0000 X-SWARE-Spam-Status: No, hits=-1.7 required=5.0 tests=AWL,BAYES_00,J_CHICKENPOX_16,J_CHICKENPOX_17,SPF_PASS X-Spam-Check-By: sourceware.org Received: from imr1.ericy.com (HELO imr1.ericy.com) (198.24.6.9) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 07 May 2009 19:28:41 +0000 Received: from eusrcmw750.eamcs.ericsson.se (eusrcmw750.exu.ericsson.se [138.85.77.50]) by imr1.ericy.com (8.13.1/8.13.1) with ESMTP id n47JcbQp000884 for ; Thu, 7 May 2009 14:38:45 -0500 Received: from ecamlmw720.eamcs.ericsson.se ([142.133.1.72]) by eusrcmw750.eamcs.ericsson.se with Microsoft SMTPSVC(6.0.3790.1830); Thu, 7 May 2009 14:28:00 -0500 Content-class: urn:content-classes:message MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: quoted-printable Subject: RE: [Patch] [MI] Out-of-scope varObjects no longer trigger a var-update change Date: Thu, 07 May 2009 19:28:00 -0000 Message-ID: <6D19CA8D71C89C43A057926FE0D4ADAA0765BF71@ecamlmw720.eamcs.ericsson.se> In-Reply-To: <6D19CA8D71C89C43A057926FE0D4ADAA0759C401@ecamlmw720.eamcs.ericsson.se> References: <6D19CA8D71C89C43A057926FE0D4ADAA0759C401@ecamlmw720.eamcs.ericsson.se> From: "Marc Khouzam" To: X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-05/txt/msg00162.txt.bz2 Ping? > -----Original Message----- > From: gdb-patches-owner@sourceware.org=20 > [mailto:gdb-patches-owner@sourceware.org] On Behalf Of Marc Khouzam > Sent: Tuesday, April 28, 2009 4:03 PM > To: gdb-patches@sourceware.org > Subject: [Patch] [MI] Out-of-scope varObjects no longer=20 > trigger a var-update change >=20 > Hi, >=20 > I believe a small bug slipped in the refactoring of varobj_update > interface from: > http://sourceware.org/ml/gdb-patches/2008-05/msg00106.html >=20 > From what I see, varobj that are not in scope don't get flagged > as changed, because nothing was being pushed on the result vector. > The attached patch fixes this. >=20 > The MI part of the testsuite passed ok. > I have an test to trigger the bug, if you care to see it. >=20 > Ok? >=20 > 2009-04-28 Marc Khouzam >=20 > * varobj.c (varobj_update): Push an out-of-scope > variable object on the result vector. >=20 > Index: gdb/varobj.c > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > RCS file: /cvs/src/src/gdb/varobj.c,v > retrieving revision 1.126 > diff -u -r1.126 varobj.c > --- gdb/varobj.c 10 Apr 2009 16:00:49 -0000 1.126 > +++ gdb/varobj.c 28 Apr 2009 19:49:24 -0000 > @@ -1188,7 +1188,7 @@ > if (new =3D=3D NULL) > r.status =3D VAROBJ_NOT_IN_SCOPE; >=20=20 > - if (r.type_changed || r.changed) > + if (r.type_changed || r.changed || r.status =3D=3D > VAROBJ_NOT_IN_SCOPE) > VEC_safe_push (varobj_update_result, result, &r); >=20=20 > if (r.status =3D=3D VAROBJ_NOT_IN_SCOPE) >=20