From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18888 invoked by alias); 4 May 2009 17:56:17 -0000 Received: (qmail 18873 invoked by uid 22791); 4 May 2009 17:56:16 -0000 X-SWARE-Spam-Status: No, hits=-2.3 required=5.0 tests=AWL,BAYES_00,SPF_PASS X-Spam-Check-By: sourceware.org Received: from imr2.ericy.com (HELO imr2.ericy.com) (198.24.6.3) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 04 May 2009 17:56:12 +0000 Received: from eusrcmw751.eamcs.ericsson.se (eusrcmw751.exu.ericsson.se [138.85.77.51]) by imr2.ericy.com (8.13.1/8.13.1) with ESMTP id n44Hu96w016219; Mon, 4 May 2009 12:56:09 -0500 Received: from ecamlmw720.eamcs.ericsson.se ([142.133.1.72]) by eusrcmw751.eamcs.ericsson.se with Microsoft SMTPSVC(6.0.3790.1830); Mon, 4 May 2009 12:56:08 -0500 Content-class: urn:content-classes:message MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: quoted-printable Subject: RE: RE: [Patch] [MI] Out-of-scope varObjects no longer trigger a var-update change Date: Mon, 04 May 2009 17:56:00 -0000 Message-ID: <6D19CA8D71C89C43A057926FE0D4ADAA07604464@ecamlmw720.eamcs.ericsson.se> In-Reply-To: A References: <6D19CA8D71C89C43A057926FE0D4ADAA0759C401@ecamlmw720.eamcs.ericsson.se> <18940.53928.936676.982399@totara.tehura.co.nz> A From: "Marc Khouzam" To: "Vladimir Prus" , X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-05/txt/msg00068.txt.bz2 > -----Original Message----- > From: gdb-patches-owner@sourceware.org=20 > [mailto:gdb-patches-owner@sourceware.org] On Behalf Of Vladimir Prus > Sent: Monday, May 04, 2009 1:54 PM > To: gdb-patches@sources.redhat.com > Subject: RE: [Patch] [MI] Out-of-scope varObjects no longer=20 > trigger a var-update change >=20 > Nick Roberts wrote: >=20 > > Marc Khouzam writes: > > > Below is the session. The testcase is part of my Eclipse > > > regression testsuite and basically looks for the content > > > of a variable name the same thing as a previous variable, > > > which is part of a method named the same thing as where the > > > previous variable was. You'll understand better from the code > > > below :-) > >=20 > > OK, I see this now. The failure occurs because `public' is=20 > considered > > an unchangeable field by GDB. > >=20 > > > Note that the below passes after I applied my proposed patch. > >=20 > > As a general principle, if a regression occurs I try to=20 > remove some of the > > added logic, rather than add to it, as I find the latter=20 > tends to make > > the logic more convoluted. > >=20 > > The procedure, varobj_update, used to return a scalar that=20 > corresponded to the > > status field of the structure. varobj_update_result. I=20 > don't know what the > > advantage of returning a vector of structures is but, in=20 > any case, the changed > > field of varobj_update_result appears not to be used=20 > outside varobj_update. I > > would suggest a change something like below. A full patch=20 > would remove the > > changed field altogether. >=20 > Can you post this as unified diff? I can't read context diffs=20 > at all :-( It would make it easier on me as well (for next time). Thanks in advance.=20