Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: "Marc Khouzam" <marc.khouzam@ericsson.com>
To: <gdb-patches@sourceware.org>
Subject: [Patch] [MI] Out-of-scope varObjects no longer trigger a var-update change
Date: Tue, 28 Apr 2009 20:04:00 -0000	[thread overview]
Message-ID: <6D19CA8D71C89C43A057926FE0D4ADAA0759C401@ecamlmw720.eamcs.ericsson.se> (raw)

Hi,

I believe a small bug slipped in the refactoring of varobj_update
interface from:
http://sourceware.org/ml/gdb-patches/2008-05/msg00106.html

From what I see, varobj that are not in scope don't get flagged
as changed, because nothing was being pushed on the result vector.
The attached patch fixes this.

The MI part of the testsuite passed ok.
I have an test to trigger the bug, if you care to see it.

Ok?

2009-04-28  Marc Khouzam  <marc.khouzam@ericsson.com>

	* varobj.c (varobj_update): Push an out-of-scope
	variable object on the result vector.

Index: gdb/varobj.c
===================================================================
RCS file: /cvs/src/src/gdb/varobj.c,v
retrieving revision 1.126
diff -u -r1.126 varobj.c
--- gdb/varobj.c        10 Apr 2009 16:00:49 -0000      1.126
+++ gdb/varobj.c        28 Apr 2009 19:49:24 -0000
@@ -1188,7 +1188,7 @@
       if (new == NULL)
        r.status = VAROBJ_NOT_IN_SCOPE;
 
-      if (r.type_changed || r.changed)
+      if (r.type_changed || r.changed || r.status ==
VAROBJ_NOT_IN_SCOPE)
        VEC_safe_push (varobj_update_result, result, &r);
 
       if (r.status == VAROBJ_NOT_IN_SCOPE)


             reply	other threads:[~2009-04-28 20:04 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-28 20:04 Marc Khouzam [this message]
2009-05-01 12:00 ` Nick Roberts
2009-05-01 13:53   ` Marc Khouzam
2009-05-02 23:09     ` Nick Roberts
2009-05-04 17:26       ` Marc Khouzam
2009-05-05 11:20         ` Nick Roberts
2009-05-04 17:54       ` Vladimir Prus
2009-05-04 17:56         ` Marc Khouzam
2009-05-07 19:28 ` Marc Khouzam
2009-05-17  7:14 ` Vladimir Prus
2009-05-20 14:32   ` Marc Khouzam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6D19CA8D71C89C43A057926FE0D4ADAA0759C401@ecamlmw720.eamcs.ericsson.se \
    --to=marc.khouzam@ericsson.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox