Re: [Patch] Try2: -var-evaluate-expression [-f FORMAT] NAME

Daniel Jacobowitz
2008-04-02T18:18:32Z

On Wed, Apr 02, 2008 at 11:08:15AM -0700, Michael Snyder wrote:
> On Wed, 2008-04-02 at 17:22 +0400, Vladimir Prus wrote:
> > Marc Khouzam wrote:
> >
> > > 2008-04-01 Marc Khouzam <marc.khouzam@ericsson.com>
> > >
> > > * mi/mi-cmd-var.c: Include "mi-getopt.h".
> > > (mi_parse_format): New. Factored out from mi_cmd_var_set_format.
> > > (mi_cmd_var_set_format): Use new mi_parse_format.
> > > (mi_cmd_var_evaluate_expression): Support for -f option to specify
> > > format.
> > > * Makefile.in (mi-cmd-var.o): Update dependencies.
> > >
> > > * varobj.h (varobj_get_formatted_value): Declare.
> > > * varobj.c (my_value_of_variable): Added format parameter.
> > > (cplus_value_of_variable): Likewise.
> > > (java_value_of_variable): Likewise.
> > > (*(value_of_variable)): Likewise.
> >
> > Is '*(value_of_variable)' really a name of a function? :-)
>
> It is, actually -- but not in varobj.c. Thanks for raising this.
> Marc, we prefer not to have identifiers or file names abbreviated
> in changelogs.

Context is:

/* The current value of VAR. */
char *(*value_of_variable) (struct varobj * var);

It's a member of struct language_specifick which is how we usually
attribute the changelog entry.

--
Daniel Jacobowitz
CodeSourcery