From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2309 invoked by alias); 1 Apr 2008 13:56:54 -0000 Received: (qmail 2295 invoked by uid 22791); 1 Apr 2008 13:56:53 -0000 X-Spam-Check-By: sourceware.org Received: from imr1.ericy.com (HELO imr1.ericy.com) (198.24.6.9) by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 01 Apr 2008 13:56:32 +0000 Received: from eusrcmw750.eamcs.ericsson.se (eusrcmw750.exu.ericsson.se [138.85.77.50]) by imr1.ericy.com (8.13.1/8.13.1) with ESMTP id m31DuA3k013308 for ; Tue, 1 Apr 2008 08:56:30 -0500 Received: from ecamlmw720.eamcs.ericsson.se ([142.133.1.72]) by eusrcmw750.eamcs.ericsson.se with Microsoft SMTPSVC(6.0.3790.1830); Tue, 1 Apr 2008 08:56:26 -0500 Content-class: urn:content-classes:message MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Subject: [Patch] mi-var-display regression failures fix Date: Tue, 01 Apr 2008 14:05:00 -0000 Message-ID: <6D19CA8D71C89C43A057926FE0D4ADAA04290FFA@ecamlmw720.eamcs.ericsson.se> From: "Marc Khouzam" To: X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-04/txt/msg00009.txt.bz2 Hi, There are a couple of new unexpected failures in MI regressions. I believe that an xfail marker was removed by mistake, which makes a couple= of tests seem to fail. Instead of putting back the xfail, I thought that fixing the error may be e= ven better :-) This patch fixes those two testcases by having the test program run until v= ariable are initialized. BTW, you should have my Copyright Assignment on file now, and my sourceforg= e account is setup,=20 so I can commit this if I get approval. Thanks --=20 Marc Khouzam Changelog: 2008-04-01 Marc Khouzam * gdb.mi/mi-var-display.exp: Stop at end of do_special_tests instead of beginning to make an extra test pass. * gdb.mi/mi2-var-display.exp: Likewise. Index: gdb/testsuite/gdb.mi/mi-var-display.exp =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D RCS file: /cvs/src/src/gdb/testsuite/gdb.mi/mi-var-display.exp,v retrieving revision 1.23 diff -u -r1.23 mi-var-display.exp --- gdb/testsuite/gdb.mi/mi-var-display.exp 26 Mar 2008 13:36:51 -0000 = 1.23 +++ gdb/testsuite/gdb.mi/mi-var-display.exp 1 Apr 2008 13:50:37 -0000 @@ -329,17 +329,17 @@ # # ##### ##### =20 -# Stop in "do_special_tests" +# Stop at the end of "do_special_tests" =20 -set line_dst_a_1 [gdb_get_line_number "a =3D 1;"] +set line_dst_incr_a_2 [gdb_get_line_number "incr_a(2);"] =20 -mi_gdb_test "200-break-insert do_special_tests" \ - "200\\^done,bkpt=3D\{number=3D\"2\",type=3D\"breakpoint\",disp=3D\"= keep\",enabled=3D\"y\",addr=3D\"$hex\",func=3D\"do_special_tests\",file=3D\= ".*var-cmd.c\",line=3D\"$line_dst_a_1\",times=3D\"0\"\}" \ +mi_gdb_test "200-break-insert $line_dst_incr_a_2" \ + "200\\^done,bkpt=3D\{number=3D\"2\",type=3D\"breakpoint\",disp=3D\"= keep\",enabled=3D\"y\",addr=3D\"$hex\",func=3D\"do_special_tests\",file=3D\= ".*var-cmd.c\",line=3D\"$line_dst_incr_a_2\",times=3D\"0\"\}" \ "break-insert operation" =20 send_gdb "-exec-continue\n" gdb_expect { - -re "\\^running\r\n${mi_gdb_prompt}\\*stopped,reason=3D\"breakpoint-hi= t\",bkptno=3D\"2\",thread-id=3D\"\[01\]\",frame=3D\{addr=3D\"$hex\",func=3D= \"do_special_tests\",args=3D\\\[\\\],file=3D\".*var-cmd.c\",fullname=3D\"${= fullname_syntax}${srcfile}\",line=3D\"$line_dst_a_1\"\}\r\n$mi_gdb_prompt$"= { + -re "\\^running\r\n${mi_gdb_prompt}\\*stopped,reason=3D\"breakpoint-hi= t\",bkptno=3D\"2\",thread-id=3D\"\[01\]\",frame=3D\{addr=3D\"$hex\",func=3D= \"do_special_tests\",args=3D\\\[\\\],file=3D\".*var-cmd.c\",fullname=3D\"${= fullname_syntax}${srcfile}\",line=3D\"$line_dst_incr_a_2\"\}\r\n$mi_gdb_pro= mpt$" { pass "continue to do_special_tests" } timeout { Index: gdb/testsuite/gdb.mi/mi2-var-display.exp =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D RCS file: /cvs/src/src/gdb/testsuite/gdb.mi/mi2-var-display.exp,v retrieving revision 1.16 diff -u -r1.16 mi2-var-display.exp --- gdb/testsuite/gdb.mi/mi2-var-display.exp 26 Mar 2008 13:36:51 -0000 = 1.16 +++ gdb/testsuite/gdb.mi/mi2-var-display.exp 1 Apr 2008 13:50:37 -0000 @@ -331,15 +331,15 @@ =20 # Stop in "do_special_tests" =20 -set line_dst_a_1 [gdb_get_line_number "a =3D 1;"] +set line_dst_incr_a_2 [gdb_get_line_number "incr_a(2);"] =20 -mi_gdb_test "200-break-insert do_special_tests" \ - "200\\^done,bkpt=3D\{number=3D\"2\",type=3D\"breakpoint\",disp=3D\"= keep\",enabled=3D\"y\",addr=3D\"$hex\",func=3D\"do_special_tests\",file=3D\= ".*var-cmd.c\",line=3D\"$line_dst_a_1\",times=3D\"0\"\}" \ +mi_gdb_test "200-break-insert $line_dst_incr_a_2" \ + "200\\^done,bkpt=3D\{number=3D\"2\",type=3D\"breakpoint\",disp=3D\"= keep\",enabled=3D\"y\",addr=3D\"$hex\",func=3D\"do_special_tests\",file=3D\= ".*var-cmd.c\",line=3D\"$line_dst_incr_a_2\",times=3D\"0\"\}" \ "break-insert operation" =20 send_gdb "-exec-continue\n" gdb_expect { - -re "\\^running\r\n${mi_gdb_prompt}\\*stopped,reason=3D\"breakpoint-hi= t\",bkptno=3D\"2\",thread-id=3D\"\[01\]\",frame=3D\{addr=3D\"$hex\",func=3D= \"do_special_tests\",args=3D\\\[\\\],file=3D\".*var-cmd.c\",fullname=3D\"${= fullname_syntax}${srcfile}\",line=3D\"$line_dst_a_1\"\}\r\n$mi_gdb_prompt$"= { + -re "\\^running\r\n${mi_gdb_prompt}\\*stopped,reason=3D\"breakpoint-hi= t\",bkptno=3D\"2\",thread-id=3D\"\[01\]\",frame=3D\{addr=3D\"$hex\",func=3D= \"do_special_tests\",args=3D\\\[\\\],file=3D\".*var-cmd.c\",fullname=3D\"${= fullname_syntax}${srcfile}\",line=3D\"$line_dst_incr_a_2\"\}\r\n$mi_gdb_pro= mpt$" { pass "continue to do_special_tests" } timeout {