From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1672 invoked by alias); 4 Feb 2008 17:00:48 -0000 Received: (qmail 1664 invoked by uid 22791); 4 Feb 2008 17:00:48 -0000 X-Spam-Check-By: sourceware.org Received: from imr1.ericy.com (HELO imr1.ericy.com) (198.24.6.9) by sourceware.org (qpsmtpd/0.31) with ESMTP; Mon, 04 Feb 2008 17:00:15 +0000 Received: from eusrcmw750.eamcs.ericsson.se (eusrcmw750.exu.ericsson.se [138.85.77.50]) by imr1.ericy.com (8.13.1/8.13.1) with ESMTP id m14H02aJ031541; Mon, 4 Feb 2008 11:00:05 -0600 Received: from ecamlmw720.eamcs.ericsson.se ([142.133.1.72]) by eusrcmw750.eamcs.ericsson.se with Microsoft SMTPSVC(6.0.3790.1830); Mon, 4 Feb 2008 11:00:04 -0600 Content-class: urn:content-classes:message MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Subject: RE: [Patch] -var-evaluate-expression NAME [FORMAT] Date: Mon, 04 Feb 2008 17:00:00 -0000 Message-ID: <6D19CA8D71C89C43A057926FE0D4ADAA04290E85@ecamlmw720.eamcs.ericsson.se> In-Reply-To: <20080203214530.GB12139@caradoc.them.org> From: "Marc Khouzam" To: "Daniel Jacobowitz" Cc: "Nick Roberts" , X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-02/txt/msg00075.txt.bz2 > > Here is the revised patch. My patch no longer works with the patch Vladimir applied http://sourceware.org/ml/gdb/2008-02/msg00006.html The reason is that Vladimir's patch has c_value_of_variable() always use the stored print_value which is formatted based on the current display format (and not the one specified as an option to -var-evaluate-expression.) I think that is a good way to do it. One solution is to revert c_value_of_variable: - return xstrdup (var->print_value); + return value_get_print_value (var->value, var->format); Although this is very easy, personally, I don't like that too much. Another option is to not only temporarily set var->format but also var->print_value (by calling varobj_set I think a solution based on=20 http://sourceware.org/ml/gdb-patches/2008-01/msg00531.html >=20 > This looks fine. All it needs, to be checked in, is a ChangeLog > entry. Could you give that a try? I updated gdb/ChangeLog, gdb/testsuite/ChangeLog and gdb/doc/ChangeLog=20 =20 > As for how it gets checked in, I can take care of that; or if you > would like write-after-approval access to the repository, please fill > out the form from the front page of sourceware.org and list me as > approving it. Thanks! I filled the form. I gather you should get it soon. >=20 > Except for one small problem :-( We seem to have skipped a step. Do > you have a copyright assignment in place? I can't find a record of > it.