From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 57208 invoked by alias); 5 Mar 2018 16:35:45 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 57198 invoked by uid 89); 5 Mar 2018 16:35:44 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-26.0 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: EUR01-HE1-obe.outbound.protection.outlook.com Received: from mail-he1eur01on0057.outbound.protection.outlook.com (HELO EUR01-HE1-obe.outbound.protection.outlook.com) (104.47.0.57) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 05 Mar 2018 16:35:42 +0000 Received: from AM3PR08MB0101.eurprd08.prod.outlook.com (10.160.211.19) by AM3PR08MB0135.eurprd08.prod.outlook.com (10.160.236.155) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.548.13; Mon, 5 Mar 2018 16:35:38 +0000 Received: from AM3PR08MB0101.eurprd08.prod.outlook.com ([fe80::fc60:4b4d:7de8:f8b7]) by AM3PR08MB0101.eurprd08.prod.outlook.com ([fe80::fc60:4b4d:7de8:f8b7%16]) with mapi id 15.20.0548.016; Mon, 5 Mar 2018 16:35:38 +0000 From: Alan Hayward To: Markus Metzger CC: "gdb-patches@sourceware.org" , nd Subject: Re: [PATCH v2 1/2] btrace: fix output of "set record btrace" Date: Mon, 05 Mar 2018 16:35:00 -0000 Message-ID: <6BDA00D9-3EA2-4BCC-AA97-42547CFA808F@arm.com> References: <1520247555-4643-1-git-send-email-markus.t.metzger@intel.com> In-Reply-To: <1520247555-4643-1-git-send-email-markus.t.metzger@intel.com> authentication-results: spf=none (sender IP is ) smtp.mailfrom=Alan.Hayward@arm.com; x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;AM3PR08MB0135;7:MdA09AjsWhlP981r5TPs4SkSKxg2F78cA2LaQjF+dGA+MRnAQBT/I7FtAreYjbG78Xl6vpIjdHTJvFCF0Ot2CLUgfEkyNgwfgPXnVeFwcpkSuVbYCuvXsuCINburkANXFvLGDCmv9MRaTPPV6XTUs83htN+Hd4Y2wtBOnK+NPvVqw6aqC+LtFLaCCqXo6ullPfedhRXztU0S2NSF3mfw/qQpeFj4NF6KNcsVcdnz5vpilhQo64YFxF4gdlAsHuUw x-ms-exchange-antispam-srfa-diagnostics: SSOS; x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 4e82023d-2e49-47c2-ba6b-08d582b720ed x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(7020095)(4652020)(48565401081)(5600026)(4604075)(3008032)(4534165)(4627221)(201703031133081)(201702281549075)(2017052603307)(7153060)(7193020);SRVR:AM3PR08MB0135; x-ms-traffictypediagnostic: AM3PR08MB0135: nodisclaimer: True x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(228905959029699); x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(8211001083)(6040501)(2401047)(8121501046)(5005006)(93006095)(93001095)(10201501046)(3231220)(944501244)(52105095)(3002001)(6055026)(6041288)(20161123562045)(20161123558120)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123564045)(20161123560045)(6072148)(201708071742011);SRVR:AM3PR08MB0135;BCL:0;PCL:0;RULEID:;SRVR:AM3PR08MB0135; x-forefront-prvs: 06022AA85F x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(396003)(376002)(39860400002)(366004)(346002)(39380400002)(189003)(377424004)(199004)(3846002)(68736007)(105586002)(5250100002)(6512007)(8676002)(81166006)(316002)(66066001)(106356001)(36756003)(8936002)(6116002)(81156014)(25786009)(6436002)(6486002)(7736002)(305945005)(5660300001)(97736004)(6246003)(4326008)(186003)(33656002)(2906002)(3280700002)(83716003)(102836004)(72206003)(14454004)(2900100001)(6506007)(99286004)(86362001)(59450400001)(3660700001)(53936002)(54906003)(76176011)(2950100002)(478600001)(6916009)(229853002)(82746002)(53546011)(575784001)(26005);DIR:OUT;SFP:1101;SCL:1;SRVR:AM3PR08MB0135;H:AM3PR08MB0101.eurprd08.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: ZNAXnh6SufgbuFuUSEsThA87gCQAT0kARMw0SMUkRUBZiSCtQOPIbeChmptcPqiNZvUV/A3bG8x5RCATECyU3qqu0c0gduHg3IBGaU+uu12/34c/2Pj4sB8iGbLjfoxOF0AtKufuT7wlQGeTE08jdbr1g+t/lDpkC+ureTI0isgPAw9hpAqkU9G6I1CWmiKNtdOHVoFkyH4q9mqyMHyo3OHnf9TRJECgHRjlRebU8whYb4CyIGT8I1y7xla58Egp5HkgKcV5z+OvUSDVrXyJBWDaWg5pdEAGdz0apVbi8XvYONTR0ecaJhnWH89YuyXqTzDAIW6djwM5bVRKXT/uXw== spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-ID: <6241B0D988EBE04DB6EB1F0EB1E10E96@eurprd08.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4e82023d-2e49-47c2-ba6b-08d582b720ed X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Mar 2018 16:35:38.4932 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM3PR08MB0135 X-IsSubscribed: yes X-SW-Source: 2018-03/txt/msg00121.txt.bz2 > On 5 Mar 2018, at 10:59, Markus Metzger wrot= e: >=20 > Instead of giving a message that "set record btrace" needs a sub-command, > GDB crashed. Fix it. A regression test comes with the next patch. >=20 > 2018-03-05 Markus Metzger >=20 > gdb/ > * record-btrace.c (cmd_set_record_btrace): Print sub-commands. > --- > gdb/record-btrace.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) >=20 > diff --git a/gdb/record-btrace.c b/gdb/record-btrace.c > index 48eda54..905f0c4 100644 > --- a/gdb/record-btrace.c > +++ b/gdb/record-btrace.c > @@ -2953,7 +2953,10 @@ cmd_record_btrace_start (const char *args, int fro= m_tty) > static void > cmd_set_record_btrace (const char *args, int from_tty) > { > - cmd_show_list (set_record_btrace_cmdlist, from_tty, ""); > + printf_unfiltered (_("\"set record btrace\" must be followed " > + "by an apporpriate subcommand.\n")); appropriate not apporpriate. Otherwise, looks ok to me, and works when I tested it. > + help_list (set_record_btrace_cmdlist, "set record btrace ", > + all_commands, gdb_stdout); > } >=20 > /* The "show record btrace" command. */ > --=20 > 1.8.3.1 >=20