From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 95166 invoked by alias); 19 Jul 2019 15:08:27 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 95155 invoked by uid 89); 19 Jul 2019 15:08:27 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-16.4 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.1 spammy=mid X-HELO: EUR04-VI1-obe.outbound.protection.outlook.com Received: from mail-eopbgr80089.outbound.protection.outlook.com (HELO EUR04-VI1-obe.outbound.protection.outlook.com) (40.107.8.89) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 19 Jul 2019 15:08:25 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=WO6raLC9cGqza2hC3C1MVuVx/Q+gyaDVs+gC4uUZf8E=; b=GJeBkEQ1GHZMtM1245fBPlJs7+scaLA2frZW8NfvV9LtR1Tk2DqxtV8R3Oqws6BntNxFSwrJprkPBWiiqn72ZdCvf4vyO/s9XuAwFCMAtl35lvb473ZiBIZCKGjA4fFTNnYBnHRlft9yc+wx3PZkq++ogqaKQmTvfB37tX6QrEQ= Received: from VI1PR0802CA0008.eurprd08.prod.outlook.com (2603:10a6:800:aa::18) by AM6PR08MB4951.eurprd08.prod.outlook.com (2603:10a6:20b:e1::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2094.12; Fri, 19 Jul 2019 15:08:20 +0000 Received: from DB5EUR03FT008.eop-EUR03.prod.protection.outlook.com (2a01:111:f400:7e0a::203) by VI1PR0802CA0008.outlook.office365.com (2603:10a6:800:aa::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2094.14 via Frontend Transport; Fri, 19 Jul 2019 15:08:20 +0000 Authentication-Results: spf=temperror (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; sourceware.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;sourceware.org; dmarc=temperror action=none header.from=arm.com; Received-SPF: TempError (protection.outlook.com: error in processing during lookup of arm.com: DNS Timeout) Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DB5EUR03FT008.mail.protection.outlook.com (10.152.20.98) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2052.18 via Frontend Transport; Fri, 19 Jul 2019 15:08:18 +0000 Received: ("Tessian outbound 3c2a520fbb81:v24"); Fri, 19 Jul 2019 15:08:18 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: ff0e27009f225afa X-CR-MTA-TID: 64aa7808 Received: from 4cdf397202b8.1 (cr-mta-lb-1.cr-mta-net [104.47.13.50]) by 64aa7808-outbound-1.mta.getcheckrecipient.com id 878E4C8B-E5DE-46A5-8A55-E8E61E54DC82.1; Fri, 19 Jul 2019 15:08:13 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04lp2050.outbound.protection.outlook.com [104.47.13.50]) by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 4cdf397202b8.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384); Fri, 19 Jul 2019 15:08:13 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kY3hU6BarLlrNjT0mHsEXmjDz6nQ2Hj048qguM2K72/ZgjP3OjzUqQffQklvuV9uEgjPmB68vVhCofDEAR7/ZmJ1eIYmapQy2GXaFaaVp4VAFRnpZEjaIvoMFIclNKGexVXqOyE6LuDFpdIewpBSQl25ee8lfvWcGUqgueHZUfV9JzWt2AAnI1bJFhVQapRh8eCe/9xeXvuMXLVXIBZstnN3/K3qvtAyC6dkpNhULIgYZfSOf31k73SzbO2XguU8yF9T3b9J3PRjdYYjKcZzmnwdAjdSxmQGcTtDsHFlaqbrOazfXZnz/mX28uW0YliNItUOtg1mJ0ip/m59MG9vvg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=WO6raLC9cGqza2hC3C1MVuVx/Q+gyaDVs+gC4uUZf8E=; b=HKJnBjlZdvdvBKaQVMneqQzQhTpV7EaD8pvZKkmSGOpEAmF9qhIZmK2xt2L25lMp8FAVwYmYXzlWWTGAMfZ6KVfR6fSpCpUAwvcVKsM3f6GqkPSYo/gNXIEE003CRwVn6xNP9BVkRHjHsx5DHVO0khiJiB3Su/Fb2l+kXgTXlg69gVw0SNdnI/bfj5DjKplrHsaFv3cXBdcx44MK0AmShmT6l2wp37HISUJMp7p2LSHU5INJDx5PdrYLXAqI1dHOknZC3wRmoQkhZ97g5CTEpAvdOJPyx+EhZ8kG1RRKIS3DtgWa3BFCngJBKrAyK0Iwvi3qKq/aZ8oB00hO01+nCw== ARC-Authentication-Results: i=1; mx.microsoft.com 1;spf=pass smtp.mailfrom=arm.com;dmarc=pass action=none header.from=arm.com;dkim=pass header.d=arm.com;arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=WO6raLC9cGqza2hC3C1MVuVx/Q+gyaDVs+gC4uUZf8E=; b=GJeBkEQ1GHZMtM1245fBPlJs7+scaLA2frZW8NfvV9LtR1Tk2DqxtV8R3Oqws6BntNxFSwrJprkPBWiiqn72ZdCvf4vyO/s9XuAwFCMAtl35lvb473ZiBIZCKGjA4fFTNnYBnHRlft9yc+wx3PZkq++ogqaKQmTvfB37tX6QrEQ= Received: from DB6PR0802MB2133.eurprd08.prod.outlook.com (10.172.227.22) by DB6PR0802MB2405.eurprd08.prod.outlook.com (10.172.250.146) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2073.14; Fri, 19 Jul 2019 15:08:11 +0000 Received: from DB6PR0802MB2133.eurprd08.prod.outlook.com ([fe80::5ce5:cf42:42dd:eda1]) by DB6PR0802MB2133.eurprd08.prod.outlook.com ([fe80::5ce5:cf42:42dd:eda1%6]) with mapi id 15.20.2073.015; Fri, 19 Jul 2019 15:08:11 +0000 From: Alan Hayward To: "gdb-patches@sourceware.org" CC: nd Subject: Re: [PATCH v2 0/5] Arm: Use feature target descriptions Date: Fri, 19 Jul 2019 15:08:00 -0000 Message-ID: <6BC17774-BB2E-4676-A161-14A59EEF71A6@arm.com> References: <20190711134436.47896-1-alan.hayward@arm.com> In-Reply-To: <20190711134436.47896-1-alan.hayward@arm.com> Authentication-Results-Original: spf=none (sender IP is ) smtp.mailfrom=Alan.Hayward@arm.com; X-Microsoft-Antispam-Untrusted: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(711020)(4605104)(1401327)(4618075)(2017052603328)(7193020);SRVR:DB6PR0802MB2405; x-checkrecipientrouted: true x-ms-oob-tlc-oobclassifiers: OLM:9508;OLM:9508; X-Forefront-Antispam-Report-Untrusted: SFV:NSPM;SFS:(10009020)(4636009)(376002)(346002)(39860400002)(136003)(366004)(396003)(199004)(189003)(14444005)(36756003)(102836004)(66066001)(486006)(476003)(76176011)(6116002)(2616005)(50226002)(2906002)(11346002)(8936002)(316002)(6506007)(99286004)(71190400001)(26005)(446003)(186003)(53546011)(6246003)(66446008)(4326008)(5640700003)(91956017)(66556008)(76116006)(64756008)(68736007)(256004)(2501003)(5660300002)(7736002)(6512007)(305945005)(57306001)(2351001)(6486002)(6436002)(81166006)(8676002)(33656002)(6916009)(86362001)(3846002)(71200400001)(229853002)(53936002)(14454004)(66476007)(66946007)(25786009)(81156014)(478600001);DIR:OUT;SFP:1101;SCL:1;SRVR:DB6PR0802MB2405;H:DB6PR0802MB2133.eurprd08.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:1;MX:1; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Message-Info-Original: zSKlAEmq5+uEoMtK7JT/agtKWCpKuUNJ2edu1WV+crxmyTwcB275j1iPiINhylfpPHoav3t4VRbnnCZDmEGtwVgWZRCw9LbNJnAD59MRfzqFLj2oFe3GncLRaXNbF1JDgPcPEO7PhnBMtTXZfqe8qRqGciLbtYMjXKWo3rfaWJx/la5R1xPA9AIUPUYRO7gzQfTue5/+29dttPvDhsjlix2NuKrbYeVRPN4r/eNKu57tMdRB3DAPrIXDpWpX3vxX8hXQQlY/wJlhiFWoj/om9HHrQrjTsE+4Q/DNvZQqbNpILTxBe54lPDdSXLWAMHSIBt8JnGrPilLk0SjBYsiIDM0tAyyJI0xDWkmiP0r+xGxgkocnlNZZkOAIScavTm56B7C+MMKtQD1O2hmQLuf31tISWXBoxgZc9ZmiOVJaCRI= Content-Type: text/plain; charset="us-ascii" Content-ID: <1D462C0EA5191F45B31A707B9A37E490@eurprd08.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Original-Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Alan.Hayward@arm.com; Return-Path: Alan.Hayward@arm.com X-MS-Exchange-Transport-CrossTenantHeadersStripped: DB5EUR03FT008.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: b885292b-f7b4-4369-9e82-08d70c5aea72 X-IsSubscribed: yes X-SW-Source: 2019-07/txt/msg00468.txt.bz2 I pushed this series (including the updated version of 1/5 and fixed the nit in 4/5). Alan. > On 11 Jul 2019, at 14:45, Alan Hayward wrote: >=20 > Version 2. First two patches from the original set have been pushed. > 1 and 4 are updated as per review comments. > Otherwise identical. Will push mid next week if there are no more comment= s. >=20 >=20 > This set of patches is a result of me trying to figure out exactly what > is supported for Arm. It moves Arm over to using feature target descripti= ons, > simplifying the confusion of xml files in the features/arm/ directory. > In addition it helps to further separate out AArch32. >=20 > There are zero functional changes made by this series. The intention is > that all Arm target descriptions are identical before and after the serie= s. > All quirks that might seem odd (for example, the Arm with NEON creates a > vfp3 feature and then a blank neon feature) have been preserved. One of t= he > patches adds tests to prove the new target descriptions are identical. The > final patch then removes these tests (as they block the removal of the xml > files). >=20 > One of the patches breaks the AArch64 gdbserver build, but it is fixed in > the following patch. Preventing this would have meant including addition= al > unused functionality, and then removing again. >=20 > Code has been tested with AArch32, Armv7, and X86 target-all builds. I do= n't > have every Arm target to test this on, but the xml tests should alleviate= any=20 > issue. >=20 > Alan Hayward (5): > Arm: Add read_description read funcs and use in GDB > Arm: Use feature target descriptions > Arm: Add xml unit tests > Arm: Use read_description funcs in gdbserver > Arm: Remove unused feature files and tests >=20 > gdb/Makefile.in | 5 ++ > gdb/aarch32-tdep.c | 33 +++++++++ > gdb/aarch32-tdep.h | 25 +++++++ > gdb/aarch64-linux-nat.c | 6 +- > gdb/arch/aarch32.c | 43 +++++++++++ > gdb/arch/aarch32.h | 27 +++++++ > gdb/arch/arm.c | 84 ++++++++++++++++++++++ > gdb/arch/arm.h | 27 +++++++ > gdb/arm-fbsd-tdep.c | 12 ++-- > gdb/arm-linux-nat.c | 11 +-- > gdb/arm-linux-tdep.c | 11 +-- > gdb/arm-tdep.c | 65 +++++++++++------ > gdb/arm-tdep.h | 12 ++-- > gdb/configure.tgt | 8 ++- > gdb/features/arm/arm-with-iwmmxt.c | 83 --------------------- > gdb/features/arm/arm-with-iwmmxt.xml | 13 ---- > gdb/features/arm/arm-with-m-fpa-layout.c | 46 ------------ > gdb/features/arm/arm-with-m-fpa-layout.xml | 46 ------------ > gdb/features/arm/arm-with-m-vfp-d16.c | 56 --------------- > gdb/features/arm/arm-with-m-vfp-d16.xml | 14 ---- > gdb/features/arm/arm-with-m.c | 37 ---------- > gdb/features/arm/arm-with-m.xml | 12 ---- > gdb/features/arm/arm-with-neon.c | 74 ------------------- > gdb/features/arm/arm-with-neon.xml | 14 ---- > gdb/features/arm/arm-with-vfpv2.c | 56 --------------- > gdb/features/arm/arm-with-vfpv2.xml | 13 ---- > gdb/features/arm/arm-with-vfpv3.c | 72 ------------------- > gdb/features/arm/arm-with-vfpv3.xml | 13 ---- > gdb/gdbserver/configure.srv | 22 ++---- > gdb/gdbserver/linux-aarch32-low.c | 2 - > gdb/gdbserver/linux-aarch32-low.h | 2 - > gdb/gdbserver/linux-aarch32-tdesc.c | 46 ++++++++++++ > gdb/gdbserver/linux-aarch32-tdesc.h | 29 ++++++++ > gdb/gdbserver/linux-aarch64-low.c | 3 +- > gdb/gdbserver/linux-arm-low.c | 77 ++++++++++---------- > gdb/gdbserver/linux-arm-tdesc.c | 62 ++++++++++++++++ > gdb/gdbserver/linux-arm-tdesc.h | 29 ++++++++ > 37 files changed, 532 insertions(+), 658 deletions(-) > create mode 100644 gdb/aarch32-tdep.c > create mode 100644 gdb/aarch32-tdep.h > create mode 100644 gdb/arch/aarch32.c > create mode 100644 gdb/arch/aarch32.h > delete mode 100644 gdb/features/arm/arm-with-iwmmxt.c > delete mode 100644 gdb/features/arm/arm-with-iwmmxt.xml > delete mode 100644 gdb/features/arm/arm-with-m-fpa-layout.c > delete mode 100644 gdb/features/arm/arm-with-m-fpa-layout.xml > delete mode 100644 gdb/features/arm/arm-with-m-vfp-d16.c > delete mode 100644 gdb/features/arm/arm-with-m-vfp-d16.xml > delete mode 100644 gdb/features/arm/arm-with-m.c > delete mode 100644 gdb/features/arm/arm-with-m.xml > delete mode 100644 gdb/features/arm/arm-with-neon.c > delete mode 100644 gdb/features/arm/arm-with-neon.xml > delete mode 100644 gdb/features/arm/arm-with-vfpv2.c > delete mode 100644 gdb/features/arm/arm-with-vfpv2.xml > delete mode 100644 gdb/features/arm/arm-with-vfpv3.c > delete mode 100644 gdb/features/arm/arm-with-vfpv3.xml > create mode 100644 gdb/gdbserver/linux-aarch32-tdesc.c > create mode 100644 gdb/gdbserver/linux-aarch32-tdesc.h > create mode 100644 gdb/gdbserver/linux-arm-tdesc.c > create mode 100644 gdb/gdbserver/linux-arm-tdesc.h >=20 > --=20 > 2.20.1 (Apple Git-117) >=20