From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5736 invoked by alias); 18 Jun 2012 09:12:48 -0000 Received: (qmail 5724 invoked by uid 22791); 18 Jun 2012 09:12:46 -0000 X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,TW_UG X-Spam-Check-By: sourceware.org Received: from mel.act-europe.fr (HELO mel.act-europe.fr) (194.98.77.210) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 18 Jun 2012 09:12:33 +0000 Received: from localhost (localhost [127.0.0.1]) by filtered-smtp.eu.adacore.com (Postfix) with ESMTP id CBF63290011; Mon, 18 Jun 2012 11:12:37 +0200 (CEST) Received: from mel.act-europe.fr ([127.0.0.1]) by localhost (smtp.eu.adacore.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id MDjd37uxOqHe; Mon, 18 Jun 2012 11:12:37 +0200 (CEST) Received: from ulanbator.act-europe.fr (ulanbator.act-europe.fr [10.10.1.67]) (using TLSv1 with cipher AES128-SHA (128/128 bits)) (No client certificate requested) by mel.act-europe.fr (Postfix) with ESMTP id B50B0290008; Mon, 18 Jun 2012 11:12:37 +0200 (CEST) Subject: Re: [RFA] Add set/show debug unwind command Mime-Version: 1.0 (Apple Message framework v1278) Content-Type: text/plain; charset=us-ascii From: Tristan Gingold In-Reply-To: <20120615182236.GY18729@adacore.com> Date: Mon, 18 Jun 2012 09:12:00 -0000 Cc: Pedro Alves , "gdb-patches@sourceware.org ml" Content-Transfer-Encoding: quoted-printable Message-Id: <6ADF55F2-9C07-43D4-AD1E-63380720ACD1@adacore.com> References: <4FDB7C32.3070705@redhat.com> <20120615182236.GY18729@adacore.com> To: Joel Brobecker X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-06/txt/msg00571.txt.bz2 On Jun 15, 2012, at 8:22 PM, Joel Brobecker wrote: >> We also document debug and maintenance commands in the manual. >=20 > Thanks for reminding us! And NEWS as well, in fact. Thanks for the comments. Here is the new version. Tristan. 2012-06-15 Tristan Gingold * frame-unwind.c (show_unwind_debug): New function. (unwind_debug): New variable. (_initialize_frame_unwind): Add show debug unwind command. * frame-unwind.h (unwind_debug): Declare. * doc/gdb.texinfo (Debugging Output): Document set/show debug unwind. * NEWS: Mention it. diff --git a/gdb/NEWS b/gdb/NEWS index 476e5a0..2384489 100644 --- a/gdb/NEWS +++ b/gdb/NEWS @@ -503,6 +503,10 @@ show trace-stop-notes instance as an explanation, if you are stopping a trace run that was started by someone else. =20 +set debug unwind +show debug unwind + Control display of debugging info for some unwinders. + * New remote packets =20 QTEnable diff --git a/gdb/doc/gdb.texinfo b/gdb/doc/gdb.texinfo index 014cfd8..30cd053 100644 --- a/gdb/doc/gdb.texinfo +++ b/gdb/doc/gdb.texinfo @@ -21850,6 +21850,11 @@ message. @item show debug timestamp Displays the current state of displaying timestamps with @value{GDBN} debugging info. +@item set debug unwind +@cindex unwinding debugging info +Turns on or off display debugging info from some unwinders. +@item show debug unwind +Display the current state of displaying unwind debugging info. @item set debugvarobj @cindex variable object debugging info Turns on or off display of @value{GDBN} variable object debugging diff --git a/gdb/frame-unwind.c b/gdb/frame-unwind.c index c90144f..ab67a76 100644 --- a/gdb/frame-unwind.c +++ b/gdb/frame-unwind.c @@ -27,6 +27,8 @@ #include "exceptions.h" #include "gdb_assert.h" #include "gdb_obstack.h" +#include "command.h" +#include "gdbcmd.h" =20 static struct gdbarch_data *frame_unwind_data; =20 @@ -237,6 +239,20 @@ frame_unwind_got_address (struct frame_info *frame, in= t regnum, return reg_val; } =20 +/* Flag to control debugging. */ + +int unwind_debug; + +/* Implements show debug unwind. */ + +static void +show_unwind_debug (struct ui_file *file, int from_tty, + struct cmd_list_element *c, const char *value) +{ + fprintf_filtered (file, _("unwind debugging is %s.\n"), value); +} + + /* -Wmissing-prototypes */ extern initialize_file_ftype _initialize_frame_unwind; =20 @@ -244,4 +260,15 @@ void _initialize_frame_unwind (void) { frame_unwind_data =3D gdbarch_data_register_pre_init (frame_unwind_init); + + /* Debug this files internals. */ + add_setshow_zinteger_cmd ("unwind", class_maintenance, &unwind_debug, + _("Set unwind debugging."), + _("Show unwind debugging."), + _("When non-zero, frame specific internal " + "debugging is enabled."), + NULL, + show_unwind_debug, + &setdebuglist, &showdebuglist); + } diff --git a/gdb/frame-unwind.h b/gdb/frame-unwind.h index f82d763..64405b9 100644 --- a/gdb/frame-unwind.h +++ b/gdb/frame-unwind.h @@ -217,4 +217,8 @@ struct value *frame_unwind_got_bytes (struct frame_info= *frame, int regnum, struct value *frame_unwind_got_address (struct frame_info *frame, int regn= um, CORE_ADDR addr); =20 +/* Flag to control debugging. */ + +extern int unwind_debug; + #endif