From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id ZzfnMy3js2HyZwAAWB0awg (envelope-from ) for ; Fri, 10 Dec 2021 18:30:53 -0500 Received: by simark.ca (Postfix, from userid 112) id C1B5A1F0D0; Fri, 10 Dec 2021 18:30:53 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-3.8 required=5.0 tests=BAYES_00,MAILING_LIST_MULTI, NICE_REPLY_A autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 4A9221EDEE for ; Fri, 10 Dec 2021 18:30:53 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id D243C385780A for ; Fri, 10 Dec 2021 23:30:52 +0000 (GMT) Received: from mail-wm1-f44.google.com (mail-wm1-f44.google.com [209.85.128.44]) by sourceware.org (Postfix) with ESMTPS id 241683858405 for ; Fri, 10 Dec 2021 23:30:42 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 241683858405 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=palves.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-wm1-f44.google.com with SMTP id 133so8026638wme.0 for ; Fri, 10 Dec 2021 15:30:42 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=+KMessw9SZftXAkdF7Oy8IVI8DS8xzgqcXasFLgxGDg=; b=F5I3jMHJk07t2ncsaV7j2IA9RAqdI6suR+ENy4/Go1ldW0LKYUwuQZeSJ9Z8AqkSXA KSC5Qg5XR8wR8a8sxdGxjlNKqzEb7RezvhuINe22B6MukOMscEdwhPTER+XOfq40POZ4 TxjQBGCB0zgA/N4LQpZw3gnbDF9H6NCMvh7Q2dsJ0OHQP9DUkyIrT23eMt8fkxleQyQz Sv3DeMbT9iRpuO7XmFLQp76/DNM/ccnkjWxcNqgDFaEjp2GAfarzpF1TgbKTojbB8LoO dfKczbPcGvW63Dv4+UZLl2gBm0rqOc6sUOwrrxp/sN67QDxaR2YY/6eUPiXzbkGgSHrH BCvA== X-Gm-Message-State: AOAM530nqKsMOUjFz1AhxGNnjpqpBIi8KqKUFgp6+D6IO+4lRJs81Dba aXSM8SPoP2SYCgkdYsLEOB0= X-Google-Smtp-Source: ABdhPJya826X3qNdNvswD74SpXRrwPZT514oBTpeHh+I50a2t4WBpT20Eh+bQ+LwXzDYP6PFt1fRvA== X-Received: by 2002:a05:600c:17c3:: with SMTP id y3mr19883504wmo.136.1639179041151; Fri, 10 Dec 2021 15:30:41 -0800 (PST) Received: from ?IPV6:2001:8a0:f912:1a00:d3db:ac91:4b9e:1449? ([2001:8a0:f912:1a00:d3db:ac91:4b9e:1449]) by smtp.gmail.com with ESMTPSA id o9sm3619925wrs.4.2021.12.10.15.30.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 10 Dec 2021 15:30:40 -0800 (PST) Message-ID: <69e77cb2-d171-e815-de73-0e58444a58f8@palves.net> Date: Fri, 10 Dec 2021 23:30:39 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.3.2 Subject: Re: [PATCH 28/29] gdb/testsuite: Remove duplicates from gdb.base/watchpoints.exp Content-Language: en-US To: Lancelot SIX , gdb-patches@sourceware.org References: <20211121175636.779325-1-lsix@lancelotsix.com> <20211121175636.779325-29-lsix@lancelotsix.com> From: Pedro Alves In-Reply-To: <20211121175636.779325-29-lsix@lancelotsix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" On 2021-11-21 17:56, Lancelot SIX via Gdb-patches wrote: > When running the testsuite, I have: > > Running ../gdb/testsuite/gdb.base/watchpoints.exp ... > DUPLICATE: gdb.base/watchpoints.exp: watchpoint hit, first time > > Fix by adjusting the test nanes where appropriate. "test names" OK. + > > Tested on x86_64-linux. > --- > gdb/testsuite/gdb.base/watchpoints.exp | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/gdb/testsuite/gdb.base/watchpoints.exp b/gdb/testsuite/gdb.base/watchpoints.exp > index 4f4e4980eb1..6582c60b37d 100644 > --- a/gdb/testsuite/gdb.base/watchpoints.exp > +++ b/gdb/testsuite/gdb.base/watchpoints.exp > @@ -63,9 +63,9 @@ with_test_prefix "before inferior start" { > set prev_timeout $timeout > set timeout 600 > > - gdb_test "cont" "Continuing.*\[Ww\]atchpoint.*ival1.*Old value = -1.*New value = 0.*ival1 = count; ival2 = count;.*" "watchpoint hit, first time" > + gdb_test "cont" "Continuing.*\[Ww\]atchpoint.*ival1.*Old value = -1.*New value = 0.*ival1 = count; ival2 = count;.*" "watchpoint ival1 hit, first time" > > - gdb_test "cont" "Continuing.*\[Ww\]atchpoint.*ival3.*Old value = -1.*New value = 0.*ival3 = count; ival4 = count;.*" "watchpoint hit, first time" > + gdb_test "cont" "Continuing.*\[Ww\]atchpoint.*ival3.*Old value = -1.*New value = 0.*ival3 = count; ival4 = count;.*" "watchpoint ival3 hit, first time" > > # Check that the ival3 hit count is reported correctly > gdb_test "info break" ".*watchpoint\[ \t\]+keep\[ \t\]+y\[ \t\]+ival3\r\n\[ \t]+breakpoint already hit 1 time.*" "watchpoint hit count is 1" >