From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 99044 invoked by alias); 18 Dec 2019 16:21:36 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 99034 invoked by uid 89); 18 Dec 2019 16:21:35 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=ham version=3.3.1 spammy= X-HELO: us-smtp-delivery-1.mimecast.com Received: from us-smtp-2.mimecast.com (HELO us-smtp-delivery-1.mimecast.com) (205.139.110.61) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 18 Dec 2019 16:21:35 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1576686093; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ZGKSXXwYDk50nMxYWTEb19Q+zw0X0bsT73rlhddh1BE=; b=HN8A5ExF2pbHO67Xc8nCVcx17BufKaivWA23l7IED8Rqif8ioG2BvuII8K9Ao2oJ8FdAAG S7aoxhal8N1h0P0oI6jizJ6wAPHqJN/B61gXT1cHm6vnLIU/RrZMR1AF8rhclrWTtTyvRn dcKztCIyv/Kf/z6ACxlrO6qI5+l+6Mk= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-110-fMmXMVZMPAu_eZyx5ZNFaQ-1; Wed, 18 Dec 2019 11:21:29 -0500 Received: by mail-wm1-f72.google.com with SMTP id l11so1953999wmi.0 for ; Wed, 18 Dec 2019 08:21:29 -0800 (PST) Return-Path: Received: from ?IPv6:2001:8a0:f913:f700:56ee:75ff:fe8d:232b? ([2001:8a0:f913:f700:56ee:75ff:fe8d:232b]) by smtp.gmail.com with ESMTPSA id q68sm3429592wme.14.2019.12.18.08.21.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 18 Dec 2019 08:21:28 -0800 (PST) Subject: Re: [PATCH] Fix build failure on macOS To: Tom Tromey , gdb-patches@sourceware.org References: <20191218150518.8540-1-tromey@adacore.com> From: Pedro Alves Message-ID: <69bd0545-37c4-9e4b-a3dd-7c7c4cf6e3e6@redhat.com> Date: Wed, 18 Dec 2019 16:21:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <20191218150518.8540-1-tromey@adacore.com> X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2019-12/txt/msg00762.txt.bz2 On 12/18/19 3:05 PM, Tom Tromey wrote: > Let me know what you think. I intend to check this in on the gdb 9 > branch as well. Whoops, should have thought of this. > @@ -78,7 +78,9 @@ enum ui_out_type > enum class field_kind > { > SIGNED, > - STRING, > + /* This has a funny name to avoid clashes with tokens named > + "STRING". See PR build/25250. */ > + FIELD_STRING, > }; I'd rather rename SIGNED to FIELD_SIGNED as well, for consistency. It no longer looks funny that way. Thanks, Pedro Alves