From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 92280 invoked by alias); 27 Jun 2017 16:40:59 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 92171 invoked by uid 89); 27 Jun 2017 16:40:58 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.9 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=no version=3.3.2 spammy=completed, wish X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 27 Jun 2017 16:40:57 +0000 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 44185C054C5A; Tue, 27 Jun 2017 16:40:56 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 44185C054C5A Authentication-Results: ext-mx08.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx08.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=palves@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 44185C054C5A Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id 601BE8D75E; Tue, 27 Jun 2017 16:40:55 +0000 (UTC) Subject: Re: [RFA 04/10] Remove EXT_LANG_BT_COMPLETED To: Phil Muldoon , Tom Tromey , gdb-patches@sourceware.org References: <20170425194113.17862-1-tom@tromey.com> <20170425194113.17862-5-tom@tromey.com> <2cc665c2-ea5b-efd3-deac-f2fc61e1feeb@redhat.com> From: Pedro Alves Message-ID: <69a8541d-bc06-282c-863b-d1cfd7550083@redhat.com> Date: Tue, 27 Jun 2017 16:40:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <2cc665c2-ea5b-efd3-deac-f2fc61e1feeb@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2017-06/txt/msg00737.txt.bz2 On 04/28/2017 03:52 PM, Phil Muldoon wrote: > On 25/04/17 20:41, Tom Tromey wrote: >> While looking at the frame filter code, I noticed that >> EXT_LANG_BT_COMPLETED is not really needed. Semantically there is no >> difference between the "completed" and "ok" results. So, this patch >> removes this constant. >> >> ChangeLog >> 2017-04-25 Tom Tromey >> >> * python/py-framefilter.c (py_print_frame): Return >> EXT_LANG_BT_OK. >> (gdbpy_apply_frame_filter): Update comment. >> * extension.h (enum ext_lang_bt_status) : >> Remove. >> : Change value. > > I wish I could remember why I added this. OTOH it could have been a relic even from the initial code submission. > > Anyway, patch LGTM. LGTM too. Thanks, Pedro Alves