Re: [PATCH][gdb/testsuite] Support -fPIE/-fno-PIE/-pie/-no-pie in gdb_compile_rust

[Tom de Vries via Gdb-patches <gdb-patches@sourceware.org>]

On 9/23/21 8:01 PM, Tom Tromey wrote:
>>>>>> "Tom" == Tom de Vries via Gdb-patches <gdb-patches@sourceware.org> writes:
> 
> Tom> Fix this by translating the gcc options to rustc options in gdb_compile_rust,
> Tom> similar to how that is done for ada in target_compile_ada_from_dir.
> 
> Thanks for doing this.
> 
> Tom> +    global board
> Tom> +    set board [target_info name]
> Tom> +    set multilib_flags_orig [board_info $board multilib_flags]
> Tom> +    set multilib_flags ""
> Tom> +    foreach op $multilib_flags_orig {
> 
> This iterates over the flags as if they are a list, but constructs the
> new flags as if it is a string:
> 
> Tom> +		append multilib_flags " -C link-arg=$op"
> 
> This could in principle cause some quoting issues, though in practice
> this would only occur with relatively weird values.
> 
> If that's a concern, a fix would be to use:
> 
>     set multilib_flags {}  ;# this is more idiomatic, not critical
> ...
>        lappend multilib_flags -C link-arg=$op
> 
> 
> Other than this, this seems fine to me.

Thanks for pointing this out, fixed and committed.

Thanks,
- Tom

> Maybe even fine as-is, up to you.
> 
> Tom
>