From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 84071 invoked by alias); 5 Jun 2017 13:32:52 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 83391 invoked by uid 89); 5 Jun 2017 13:32:52 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 05 Jun 2017 13:32:50 +0000 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id AF8E8C057F90; Mon, 5 Jun 2017 13:32:53 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com AF8E8C057F90 Authentication-Results: ext-mx08.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx08.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=palves@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com AF8E8C057F90 Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id 18D2081ECA; Mon, 5 Jun 2017 13:32:52 +0000 (UTC) Subject: Re: [RFA 17/23] Use a scoped_restore for user_call_depth To: Tom Tromey , gdb-patches@sourceware.org References: <20170503224626.2818-1-tom@tromey.com> <20170503224626.2818-18-tom@tromey.com> From: Pedro Alves Message-ID: <698b7dc8-a1df-5ded-bd46-a5e716e90238@redhat.com> Date: Mon, 05 Jun 2017 13:32:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <20170503224626.2818-18-tom@tromey.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2017-06/txt/msg00115.txt.bz2 On 05/03/2017 11:46 PM, Tom Tromey wrote: > - > void > execute_user_command (struct cmd_list_element *c, char *args) > { > @@ -398,15 +388,15 @@ execute_user_command (struct cmd_list_element *c, char *args) > return; > > scoped_user_args_level push_user_args (args); > + scoped_restore restore_call_depth > + = make_scoped_restore (&user_call_depth, user_call_depth + 1); > > - if (++user_call_depth > max_user_call_depth) > + if (user_call_depth > max_user_call_depth) > error (_("Max user call depth exceeded -- command aborted.")); > How about we remove the user_call_depth variable and check user_args_stack.size () instead ? Thanks, Pedro Alves