From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6997 invoked by alias); 28 Jun 2007 22:17:25 -0000 Received: (qmail 6989 invoked by uid 22791); 28 Jun 2007 22:17:25 -0000 X-Spam-Check-By: sourceware.org Received: from b.mail.sonic.net (HELO b.mail.sonic.net) (64.142.19.5) by sourceware.org (qpsmtpd/0.31) with ESMTP; Thu, 28 Jun 2007 22:17:20 +0000 Received: from webmail.sonic.net (b.webmail.sonic.net [64.142.100.148]) by b.mail.sonic.net (8.13.8.Beta0-Sonic/8.13.7) with ESMTP id l5SMHIHC029306; Thu, 28 Jun 2007 15:17:18 -0700 Received: from 12.7.175.2 (SquirrelMail authenticated user msnyder) by webmail.sonic.net with HTTP; Thu, 28 Jun 2007 15:17:18 -0700 (PDT) Message-ID: <6989.12.7.175.2.1183069038.squirrel@webmail.sonic.net> In-Reply-To: <20070628215829.GA10350@caradoc.them.org> References: <13902.12.7.175.2.1183067383.squirrel@webmail.sonic.net> <20070628215829.GA10350@caradoc.them.org> Date: Thu, 28 Jun 2007 22:27:00 -0000 Subject: Re: [OB] cli/cli-script.c, null ptr guard From: msnyder@sonic.net To: msnyder@sonic.net, gdb-patches@sourceware.org User-Agent: SquirrelMail/1.4.9a MIME-Version: 1.0 Content-Type: text/plain;charset=iso-8859-1 Content-Transfer-Encoding: 8bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-06/txt/msg00501.txt.bz2 > No, I don't think this is obvious. What does it mean to have a null > string here and how can it happen? I'm pretty sure it can't, and the > if check is just clutter. The reasoning is that, since we checked it for NULL in the first statement of the function, we must believe that the possibility exists for it to be NULL.