From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 119001 invoked by alias); 6 Sep 2017 15:32:03 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 118784 invoked by uid 89); 6 Sep 2017 15:32:01 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.9 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=no version=3.3.2 spammy=humans, H*M:7ce5, Hx-languages-length:763 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 06 Sep 2017 15:32:00 +0000 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 287E04E909; Wed, 6 Sep 2017 15:31:59 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 287E04E909 Authentication-Results: ext-mx09.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx09.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=palves@redhat.com Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id 837EC80F8E; Wed, 6 Sep 2017 15:31:58 +0000 (UTC) Subject: Re: [PATCH, gdb/testsuite] Fix calls in gdb.arch/thumb2-it.exp To: Thomas Preudhomme , GDB Patches References: <58a6af50-7bd9-f6c7-dbed-98c473e5e07d@foss.arm.com> From: Pedro Alves Message-ID: <69663edc-817b-17c3-7ce5-930f1bf0e949@redhat.com> Date: Wed, 06 Sep 2017 15:32:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <58a6af50-7bd9-f6c7-dbed-98c473e5e07d@foss.arm.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2017-09/txt/msg00153.txt.bz2 On 09/06/2017 04:26 PM, Thomas Preudhomme wrote: > Hi, > > Tests in gdb.arch/thumb2-it.exp call functions defined in assembly > without type debugging information. Since > 7022349d5c86bae74b49225515f42d2e221bd368 I find Linux's style to refer to past commits helpful when reading commit logs. I.e., also mention the commit subject, like: ... Since 7022349d5c86 ("Stop assuming no-debug-info functions return int"), this triggers ... This gives a clue to humans what the commit is about. > this triggers an error which > leads to many tests to FAIL. This patch cast the call to indicate the > return type of the functions when calling them. > > Is this ok for master? OK. Thanks, Pedro Alves