Re: Unreviewed PATCH: SH Simulator - MAC.L implementation and MAC.W correction

Daniel Jacobowitz
2003-02-25T13:53:05Z

On Tue, Feb 25, 2003 at 05:32:22PM +0530, Shrinivas Atre wrote:
> Hi,
>
> Could someone please review the following patch for the SH-simulator?
>
> http://sources.redhat.com/ml/gdb/2002-11/msg00365.html

Shrinivas,

The patch looks good to me; I'm not all that fond of the xor games for
the sign bit but the SH simulator already uses that construct so it's
OK.

However, I'm not very familiar with SH, I don't know the algorithm in
question, and the SH sim doesn't have a specific maintainer. Elena,
you're GDB's SH maintainer; do you have any comments on this patch?
Or J"orn?

--
Daniel Jacobowitz
MontaVista Software Debian GNU/Linux Developer