Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Simon Marchi <simon.marchi@ericsson.com>
To: Andrew Burgess <andrew.burgess@embecosm.com>
Cc: GDB Patches <gdb-patches@sourceware.org>
Subject: riscv-tdep.c in 32-bits build
Date: Thu, 20 Dec 2018 17:26:00 -0000	[thread overview]
Message-ID: <6948b903-63f2-b0d2-4f66-738b95b51385@ericsson.com> (raw)

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="utf-8", Size: 864 bytes --]

Hi Andrew,

I just noticed this error when building for i386-linux-gnu.

  CXX    riscv-tdep.o
/home/emaisin/src/binutils-gdb/gdb/riscv-tdep.c: In function ‘CORE_ADDR riscv_scan_prologue(gdbarch*, CORE_ADDR, CORE_ADDR, riscv_unwind_cache*)’:
/home/emaisin/src/binutils-gdb/gdb/riscv-tdep.c:1548:43: error: format ‘%ld’ expects argument of type ‘long int’, but argument 4 has type ‘CORE_ADDR {aka long long unsigned int}’ [-Werror=format=]
                                     offset);
                                           ^
I looked at it a bit and decided to let you choose how you wanted to fix
it.  Since this is a CORE_ADDR, I first thought we should call paddress.
But this variable represents an offset, not an absolute address, so I am
not sure if paddress is really appropriate.

Simon
\x16º&Öéj×!zÊÞ¶êçם¼÷™b²Ö«r\x18\x1dn–­r\x17¬

             reply	other threads:[~2018-12-20 17:26 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-20 17:26 Simon Marchi [this message]
2018-12-21  0:57 ` Andrew Burgess
2018-12-21 15:22   ` Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6948b903-63f2-b0d2-4f66-738b95b51385@ericsson.com \
    --to=simon.marchi@ericsson.com \
    --cc=andrew.burgess@embecosm.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox