From: Pedro Alves <palves@redhat.com>
To: Simon Marchi <simark@simark.ca>, Tom Tromey <tom@tromey.com>,
gdb-patches@sourceware.org
Subject: Re: [RFA 11/13] Remove unused variables from gdbserver
Date: Mon, 16 Jul 2018 14:16:00 -0000 [thread overview]
Message-ID: <6939e165-bdb7-9d5b-d537-c235ec3d5b41@redhat.com> (raw)
In-Reply-To: <de77c070-e89e-59a4-7afc-9a19ff0cf2e2@simark.ca>
On 07/14/2018 03:47 AM, Simon Marchi wrote:
> On 2018-07-12 04:52 PM, Tom Tromey wrote:
>> This removes a few unused variables from gdbserver.
>>
>> The x86-tdesc.h change is a bit unusual for this series. This file
>> was not defining the multiple-include guard symbol, so I've added that
>> here. Also, it is hard to determine when i386_expedite_regs will be
>> needed, so this patch simply marks it ATTRIBUTE_UNUSED.
>
> That sounds reasonable to me, LGTM.
To me too, but I'd suggest adding a comment, something around:
/* The "expedite" registers for x86 targets. Since whether the
variable is used depends on host/configuration, we mark
it ATTRIBUTE_UNUSED to keep it simple here. */
Thanks,
Pedro Alves
next prev parent reply other threads:[~2018-07-16 14:16 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-12 20:52 [RFA 00/13] Add -Wunused-variable Tom Tromey
2018-07-12 20:52 ` [RFA 13/13] Add -Wunused-variable to warnings.m4 Tom Tromey
2018-07-12 20:52 ` [RFA 02/13] Unused variable fixes related to conditional compilation Tom Tromey
2018-07-14 1:16 ` Simon Marchi
2018-07-14 21:50 ` Simon Marchi
2018-07-16 13:45 ` Pedro Alves
2018-07-22 2:25 ` Simon Marchi
2018-07-12 20:52 ` [RFA 04/13] Call some functions in guile/ for effect Tom Tromey
2018-07-14 1:19 ` Simon Marchi
2018-07-14 12:39 ` Tom Tromey
2018-07-16 13:54 ` Pedro Alves
2018-07-16 15:58 ` Tom Tromey
2018-07-12 20:52 ` [RFA 08/13] Fix ravenscar-thread.c to use arch_ops Tom Tromey
2018-07-14 1:25 ` Simon Marchi
2018-07-16 13:59 ` Pedro Alves
2018-07-16 15:36 ` Tom Tromey
2018-07-16 16:43 ` Pedro Alves
2018-07-12 20:52 ` [RFA 06/13] Remove dead code from m32c-tdep.c Tom Tromey
2018-07-12 22:18 ` Simon Marchi
2018-07-13 20:49 ` Tom Tromey
2018-07-12 20:52 ` [RFA 10/13] Remove unused declaration from value.c Tom Tromey
2018-07-13 2:52 ` Simon Marchi
2018-07-13 20:51 ` Tom Tromey
2018-07-13 21:49 ` Simon Marchi
2018-07-16 14:02 ` Pedro Alves
2018-07-16 15:34 ` Tom Tromey
2018-07-12 20:52 ` [RFA 09/13] Pass the correct argument to the observer in reread_symbols Tom Tromey
2018-07-13 2:49 ` Simon Marchi
2018-07-14 1:25 ` Simon Marchi
2018-07-12 20:52 ` [RFA 11/13] Remove unused variables from gdbserver Tom Tromey
2018-07-14 2:47 ` Simon Marchi
2018-07-16 14:16 ` Pedro Alves [this message]
2018-07-12 20:52 ` [RFA 07/13] Remove unused declaration from py-prettyprint.c Tom Tromey
2018-07-14 1:24 ` Simon Marchi
2018-07-14 12:39 ` Tom Tromey
2018-07-16 14:11 ` Pedro Alves
2018-07-12 20:52 ` [RFA 01/13] Simple unused variable removals Tom Tromey
2018-07-14 1:15 ` Simon Marchi
2018-07-14 12:40 ` Tom Tromey
2018-07-14 21:54 ` Simon Marchi
2018-07-14 21:56 ` Simon Marchi
2018-07-16 13:38 ` Pedro Alves
2018-07-16 13:33 ` Pedro Alves
2018-07-16 15:35 ` Tom Tromey
2018-07-12 20:52 ` [RFA 05/13] Make a few calls in *-tdep.c for effect Tom Tromey
2018-07-12 21:58 ` Simon Marchi
2018-07-13 20:47 ` Tom Tromey
2018-07-16 14:03 ` Pedro Alves
2018-07-12 20:52 ` [RFA 03/13] Use a previously unused variable in bfin-tdep.c Tom Tromey
2018-07-14 1:17 ` Simon Marchi
2018-07-12 20:52 ` [RFA 12/13] Add ATTRIBUTE_UNUSED to regdat.sh output Tom Tromey
2018-07-16 15:11 ` Pedro Alves
2018-07-16 16:41 ` Tom Tromey
2018-07-16 17:54 ` Pedro Alves
2018-07-16 19:06 ` Tom Tromey
2018-07-16 21:12 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6939e165-bdb7-9d5b-d537-c235ec3d5b41@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=simark@simark.ca \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox