From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23272 invoked by alias); 22 Apr 2009 17:45:39 -0000 Received: (qmail 23258 invoked by uid 22791); 22 Apr 2009 17:45:37 -0000 X-SWARE-Spam-Status: No, hits=-2.2 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from ugmailsb.ugent.be (HELO ugmailsb.ugent.be) (157.193.71.46) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 22 Apr 2009 17:45:33 +0000 Received: from localhost (localhost [127.0.0.1]) by ugmailsb.ugent.be (Postfix) with ESMTP id 2B5A52AAFCF for ; Wed, 22 Apr 2009 19:45:30 +0200 (CEST) Received: from ugmailsb.ugent.be ([127.0.0.1]) by localhost (ugmailsb.ugent.be [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id qrA3LXjLvKRN for ; Wed, 22 Apr 2009 19:45:30 +0200 (CEST) Received: from cypress.ugent.be (cypress.ugent.be [157.193.71.48]) by ugmailsb.ugent.be (Postfix) with ESMTP id ED1012AAFCC for ; Wed, 22 Apr 2009 19:45:29 +0200 (CEST) X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: ApoEAHv07kmdwc4w/2dsb2JhbADRWoN0Bg Received: from mail.elis.ugent.be ([157.193.206.48]) by relayrec.ugent.be with ESMTP; 22 Apr 2009 19:45:29 +0200 Received: from localhost (localhost [127.0.0.1]) by mail.elis.UGent.be (Postfix) with ESMTP id DF09A2BABC3; Wed, 22 Apr 2009 19:45:22 +0200 (CEST) Received: from [127.0.0.1] (ssh2.elis.UGent.be [157.193.206.127]) by mail.elis.UGent.be (Postfix) with ESMTP id B99F22BABAF; Wed, 22 Apr 2009 19:45:22 +0200 (CEST) Cc: gdb-patches ml Message-Id: <691B0BA8-C606-42FF-A796-76CC9C31556A@elis.ugent.be> From: Jonas Maebe To: Tom Tromey In-Reply-To: Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes Content-Transfer-Encoding: 7bit Mime-Version: 1.0 (Apple Message framework v926) Subject: Re: [patch] Set calling convention of methods Date: Wed, 22 Apr 2009 17:45:00 -0000 References: <7B6EF4DA-76C8-4D9C-8B9F-94153EF1C4E1@elis.ugent.be> Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-04/txt/msg00598.txt.bz2 On 20 Apr 2009, at 20:25, Tom Tromey wrote: > "dwarf2.h" is not included in many places in gdb, and not by any > header. So, assuming your uses of this field will end up in truly > generic code, I think the thing to do is introduce a new enum, and > then translate values in the DWARF reader. It is tempting to simply > reuse the DWARF enum internally, but I think that goes against the GDB > style. Ok, I can adapt my patch to clean that up. I'd prefer my i386 Borland fastcall patch to be committed first though, since changing this calling convention stuff would also affect that patch. Is that possible given my current in-progress state as far as the copyright assignment process is concerned? If so, Mark, could you tell me whether anything should still be changed in the last version I sent you? Thanks, Jonas